encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Suppress vkUpdateDescriptorSets-None-03047" 

This reverts commit afc3f9d4c7.

Reason for revert: crbug.com/dawn/1615 should be fixed now that
vulkan-deps has rolled into Chromium.

Original change's description:
> Suppress vkUpdateDescriptorSets-None-03047
>
> Bug: dawn:1615
> Change-Id: I40f745fe7f7736c9c5ece34fc9fb114d478c9118
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116926
> Commit-Queue: Austin Eng <enga@chromium.org>
> Reviewed-by: Zhaoming Jiang <zhaoming.jiang@intel.com>
> Auto-Submit: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:1615
Change-Id: I5dbd7ae82a0c4f3b3b88ea70a9faac35507a0418
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117320
Kokoro: Austin Eng <enga@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Auto-Submit: Austin Eng <enga@google.com>
Commit-Queue: Austin Eng <enga@google.com>
This commit is contained in:
Austin Eng 2023-01-17 19:32:46 +00:00 committed by Dawn LUCI CQ
parent 1177c970d6
commit cdec06a2aa
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/dawn/native/vulkan/BackendVk.cpp
View File

@ -102,9 +102,6 @@ constexpr SkippedMessage kSkippedMessages[] = {
{"VUID-vkCmdBindDescriptorSets-pDescriptorSets-00358",
"is empty (has no bindings). Use VK_NULL_HANDLE to indicate this set is unused if using "
"VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT"},
// http://crbug.com/dawn/1615
{"VUID-vkUpdateDescriptorSets-None-03047",
"Cannot call vkUpdateDescriptorSets() to perform write update on VkDescriptorSet"},
// A warning that's generated on valid usage of the WebGPU API where a fragment output doesn't
// have a corresponding attachment

2
src/dawn/tests/end2end/BindGroupTests.cpp
View File

@ -1231,8 +1231,6 @@ TEST_P(BindGroupTests, DynamicBindingNoneVisibility) {
TEST_P(BindGroupTests, ArbitraryBindingNumbers) {
// TODO(crbug.com/dawn/736): Test output is wrong with D3D12 + WARP.
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsWARP());
// TODO(crbug.com/dawn/1617): VUID-vkUpdateDescriptorSets-None-03047 on Windows
DAWN_SUPPRESS_TEST_IF(IsWindows() && IsVulkan() && IsBackendValidationEnabled());
utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize);