encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unneeded TODO for SetScissorRect in unittests 

This change also fixed a small style issue in dawn.json.

BUG=

Change-Id: I731aca5558ebe1eb0d6bd144a0e2a9b01963558a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6261
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Yunchao He 2019-04-02 14:31:29 +00:00 committed by Commit Bot service account
parent 2a30e14074
commit cfea934e2b
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dawn.json
View File

@ -553,8 +553,8 @@
"filter mode": { "filter mode": {
"category": "enum", "category": "enum",
"values": [ "values": [
{"value": 0, "name":"nearest"}, {"value": 0, "name": "nearest"},
{"value": 1, "name":"linear"} {"value": 1, "name": "linear"}
] ]
}, },
"float": { "float": {

2
src/tests/unittests/validation/DynamicStateCommandValidationTests.cpp
View File

@ -62,8 +62,6 @@ TEST_F(SetScissorRectTest, EmptyScissor) {
} }
// Test to check that a scissor larger than the framebuffer is allowed // Test to check that a scissor larger than the framebuffer is allowed
// TODO(cwallez@chromium.org): scissor values seem to be integers in all APIs do the same
// and test negative values?
TEST_F(SetScissorRectTest, ScissorLargerThanFramebuffer) { TEST_F(SetScissorRectTest, ScissorLargerThanFramebuffer) {
DummyRenderPass renderPass(device); DummyRenderPass renderPass(device);