encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Lift suppression for incorrect VVL image layout tracking 

Fixed: dawn:785
Change-Id: I618d2d44c02ae5e256841392cb2359f3992e32dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64020
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brandon Jones <bajones@google.com>
Commit-Queue: Brandon Jones <bajones@google.com>
This commit is contained in:
Corentin Wallez 2021-09-10 15:02:24 +00:00 committed by Dawn LUCI CQ
parent 7a446220a1
commit d4b85fbd76
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/dawn_native/vulkan/BackendVk.cpp
View File

@ -52,12 +52,6 @@ constexpr char kVulkanLibName[] = "libvulkan.so";
# error "Unimplemented Vulkan backend platform" # error "Unimplemented Vulkan backend platform"
#endif #endif
// List of Vulkan MessageIdNames to suppress validation messages for. These should be used sparingly
// but may be useful to temporarily quiet issues while a fix is in the works.
constexpr const char* kSuppressedValidationMessageNames[] = {
"UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout", // (ISSUE: dawn:785)
};
namespace dawn_native { namespace vulkan { namespace dawn_native { namespace vulkan {
namespace { namespace {
@ -67,13 +61,6 @@ namespace dawn_native { namespace vulkan {
VkDebugUtilsMessageTypeFlagsEXT /* messageTypes */, VkDebugUtilsMessageTypeFlagsEXT /* messageTypes */,
const VkDebugUtilsMessengerCallbackDataEXT* pCallbackData, const VkDebugUtilsMessengerCallbackDataEXT* pCallbackData,
void* /* pUserData */) { void* /* pUserData */) {
// If the message is of a suppressed type, ignore it.
for (const char* msgName : kSuppressedValidationMessageNames) {
if (strstr(pCallbackData->pMessageIdName, msgName) != nullptr) {
return VK_FALSE;
}
}
dawn::WarningLog() << pCallbackData->pMessage; dawn::WarningLog() << pCallbackData->pMessage;
ASSERT((messageSeverity & VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT) == 0); ASSERT((messageSeverity & VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT) == 0);