encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

resolver: Temporarily disable vertex position validation 

CTS needs updating to fix this validation error, and this is blocking autorolls for tint and dawn.

Change-Id: Ie3aaa37f0914fdb39099e7c15e65be0bcca0677a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48682
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Ben Clayton 2021-04-21 22:55:42 +00:00 committed by Commit Bot service account
parent 3980c4eb49
commit d5ceafee16
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/resolver/entry_point_validation_test.cc
View File

@ -500,7 +500,9 @@ TEST_F(ResolverEntryPointValidationTest, Parameter_Struct_DuplicateLocation) {
12:34 note: while analysing entry point main)"); 12:34 note: while analysing entry point main)");
} }
TEST_F(ResolverEntryPointValidationTest, VertexShaderMustReturnPosition) { // TODO(bclayton): Reenable after CTS is updated
TEST_F(ResolverEntryPointValidationTest,
DISABLED_VertexShaderMustReturnPosition) {
// [[stage(vertex)]] // [[stage(vertex)]]
// fn main() {} // fn main() {}
Func(Source{{12, 34}}, "main", {}, ty.void_(), {}, Func(Source{{12, 34}}, "main", {}, ty.void_(), {},

3
src/resolver/resolver.cc
View File

@ -811,7 +811,8 @@ bool Resolver::ValidateEntryPoint(const ast::Function* func,
} }
} }
} }
if (!found) { // TODO(bclayton): Reenable after CTS is updated
if (((false)) && !found) {
diagnostics_.add_error( diagnostics_.add_error(
"a vertex shader must include the 'position' builtin in its return " "a vertex shader must include the 'position' builtin in its return "
"type", "type",