encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable CompareFunctionsCompute test 

This is blocking the Tint roll which adds validation that
textureSampleCompare cannot be used in the compute stage.

Simply disabling this test for now since WGSL discussions seem to
indicate there may be a builtin added with a different name and
semantics.

Change-Id: Iaecf5865c9fb38aea3231c3ae823d783a665984d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53320
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
This commit is contained in:
Austin Eng 2021-06-03 23:25:36 +00:00 committed by Dawn LUCI CQ
parent cac1d35f71
commit d637cc5482
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/end2end/DepthStencilSamplingTests.cpp
View File

@ -722,7 +722,8 @@ TEST_P(DepthStencilSamplingTest, CompareFunctionsRender) {
}
// Test that sampling in a render pipeline with all of the compare functions works.
TEST_P(DepthStencilSamplingTest, CompareFunctionsCompute) {
// WGSL disallows |textureSampleCompare| in compute stages.
TEST_P(DepthStencilSamplingTest, DISABLED_CompareFunctionsCompute) {
// Initialization via renderPass loadOp doesn't work on Mac Intel.
DAWN_SUPPRESS_TEST_IF(IsMetal() && IsIntel());