encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GN: Use the hermetic XCode if available. 

This matches Chromium's logic and make it less likely to break developer
workflow in the subsequent roll of Chromium's buildtools.

Bug: dawn:339
Change-Id: Ic42553827be125985a3d16b4f5d003b6662ead39
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/16520
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2020-03-06 12:25:20 +00:00 committed by Commit Bot service account
parent 1d54767364
commit ddc5cacc27
1 changed files with 29 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
build_overrides/build.gni
View File

@ -12,16 +12,35 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# Tell Dawn and dependencies to not do Chromium-specific things declare_args() {
build_with_chromium = false # Tell Dawn and dependencies to not do Chromium-specific things
build_with_chromium = false
# Use Chromium's binutils to have "hermetic" builds on bots # Use Chromium's binutils to have "hermetic" builds on bots
linux_use_bundled_binutils_override = true linux_use_bundled_binutils_override = true
# In standalone Dawn builds, don't try to use the hermetic install of Xcode # In standalone Dawn builds, don't try to use the hermetic install of Xcode
# that Chromium uses # that Chromium uses
use_system_xcode = true use_system_xcode = ""
# Android 32-bit non-component, non-clang builds cannot have symbol_level=2 # Android 32-bit non-component, non-clang builds cannot have symbol_level=2
# due to 4GiB file size limit, see https://crbug.com/648948. # due to 4GiB file size limit, see https://crbug.com/648948.
ignore_elf32_limitations = false ignore_elf32_limitations = false
}
# Detect whether we can use the hermetic XCode like in Chromium and do so if
# possible.
if (host_os == "mac" && use_system_xcode == "") {
_result = exec_script("//build/mac/should_use_hermetic_xcode.py",
[ target_os ],
"value")
assert(_result != 2,
"Do not allow building targets with the default" +
"hermetic toolchain if the minimum OS version is not met.")
assert(_result != 3,
"iOS does not support building with a hermetic toolchain. " +
"Please install Xcode.")
use_system_xcode = _result != 1
}