encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-16 00:17:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "MSL writer: make signed int overflow defined behaviour"

Browse Source 
This reverts commit e5dbe24e94.

Reason for revert: Makes the Tint-Dawn roll fails because of
MSL compilation errors on as_type<uint>(-2147483648):
as_type cast from 'long' to 'uint' (aka 'unsigned int') is not allowed
   
as_type<uint>(-2147483647) compiles fine, so this is most
likely because the MSL compiler types the literal as a long
(since without the - it is larger than the max int32).

Original change's description:
> MSL writer: make signed int overflow defined behaviour
>
> Bug: tint:124
> Change-Id: Icf545b633d6390ceb7f639e80111390005e311a1
> Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60100
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
> Reviewed-by: David Neto <dneto@google.com>

TBR=dneto@google.com,bclayton@google.com,jrprice@google.com,amaiorano@google.com,noreply+kokoro@google.com,tint-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I3e3384a9185013bb141a1b7b9b22bad8571bbc50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: tint:124
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60345
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Corentin Wallez
2021-07-30 08:22:58 +00:00
committed by Tint LUCI CQ
parent 13969024c9
commit e33b0baa08
651 changed files with 3048 additions and 3963 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/vk-gl-cts/graphicsfuzz/cov-left-shift-array-access/0-opt.spvasm.expected.msl
View File

@@ -23,7 +23,7 @@ void main_1(constant buf1& x_6, thread float4* const tint_symbol_5) {
int a = 0;
tint_array_wrapper indexable = {};
int const x_27 = x_6.x_GLF_uniform_int_values.arr[1].el;
idx = as_type<int>((as_type<uint>(1) << as_type<uint>(x_27)));
idx = (1 << as_type<uint>(x_27));
int const x_30 = x_6.x_GLF_uniform_int_values.arr[1].el;
int const x_32 = x_6.x_GLF_uniform_int_values.arr[0].el;
int const x_34 = idx;

2
test/vk-gl-cts/graphicsfuzz/cov-left-shift-array-access/0-opt.wgsl.expected.msl
View File

@@ -23,7 +23,7 @@ void main_1(constant buf1& x_6, thread float4* const tint_symbol_5) {
int a = 0;
tint_array_wrapper indexable = {};
int const x_27 = x_6.x_GLF_uniform_int_values.arr[1].el;
idx = as_type<int>((as_type<uint>(1) << as_type<uint>(x_27)));
idx = (1 << as_type<uint>(x_27));
int const x_30 = x_6.x_GLF_uniform_int_values.arr[1].el;
int const x_32 = x_6.x_GLF_uniform_int_values.arr[0].el;
int const x_34 = idx;