encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-13 07:06:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "MSL writer: make signed int overflow defined behaviour"

Browse Source 
This reverts commit e5dbe24e94.

Reason for revert: Makes the Tint-Dawn roll fails because of
MSL compilation errors on as_type<uint>(-2147483648):
as_type cast from 'long' to 'uint' (aka 'unsigned int') is not allowed
   
as_type<uint>(-2147483647) compiles fine, so this is most
likely because the MSL compiler types the literal as a long
(since without the - it is larger than the max int32).

Original change's description:
> MSL writer: make signed int overflow defined behaviour
>
> Bug: tint:124
> Change-Id: Icf545b633d6390ceb7f639e80111390005e311a1
> Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60100
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
> Reviewed-by: David Neto <dneto@google.com>

TBR=dneto@google.com,bclayton@google.com,jrprice@google.com,amaiorano@google.com,noreply+kokoro@google.com,tint-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I3e3384a9185013bb141a1b7b9b22bad8571bbc50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: tint:124
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60345
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Corentin Wallez
2021-07-30 08:22:58 +00:00
committed by Tint LUCI CQ
parent 13969024c9
commit e33b0baa08
651 changed files with 3048 additions and 3963 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/vk-gl-cts/graphicsfuzz/increment-value-in-nested-for-loop/0.spvasm.expected.msl
View File

@@ -99,7 +99,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
}
if (x_78) {
{
x_87 = as_type<int>((as_type<uint>(x_86) + as_type<uint>(1)));
x_87 = (x_86 + 1);
x_86_phi = x_87;
}
continue;
@@ -110,7 +110,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_87 = as_type<int>((as_type<uint>(x_86) + as_type<uint>(1)));
x_87 = (x_86 + 1);
x_86_phi = x_87;
}
}
@@ -125,7 +125,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
x_66 = x_66_phi;
x_63 = as_type<int>(as_type<int>((as_type<uint>(x_62) + as_type<uint>(x_66))));
x_63 = as_type<int>((x_62 + x_66));
if (x_41) {
while (true) {
if (x_41) {
@@ -143,7 +143,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_68 = as_type<int>((as_type<uint>(x_67) + as_type<uint>(1)));
x_68 = (x_67 + 1);
x_62_phi = x_63;
x_65_phi = x_66;
x_67_phi = x_68;
@@ -163,7 +163,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_53 = as_type<int>((as_type<uint>(x_52) + as_type<uint>(1)));
x_53 = (x_52 + 1);
x_45_phi = x_46;
x_48_phi = x_49;
x_50_phi = x_51;
@@ -215,7 +215,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
}
if (x_135) {
{
x_144 = as_type<int>((as_type<uint>(x_143) + as_type<uint>(1)));
x_144 = (x_143 + 1);
x_143_phi = x_144;
}
continue;
@@ -226,7 +226,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_144 = as_type<int>((as_type<uint>(x_143) + as_type<uint>(1)));
x_144 = (x_143 + 1);
x_143_phi = x_144;
}
}
@@ -242,13 +242,13 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
}
int x_119 = 0;
x_119 = x_119_phi;
x_116 = as_type<int>(as_type<int>((as_type<uint>(x_115) + as_type<uint>(x_119))));
x_116 = as_type<int>((x_115 + x_119));
if (select(x_41, false, !(x_41))) {
x_161_phi = x_116;
break;
}
{
x_121 = as_type<int>((as_type<uint>(x_120) + as_type<uint>(1)));
x_121 = (x_120 + 1);
x_115_phi = x_116;
x_118_phi = x_119;
x_120_phi = x_121;

18
test/vk-gl-cts/graphicsfuzz/increment-value-in-nested-for-loop/0.wgsl.expected.msl
View File

@@ -99,7 +99,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
}
if (x_78) {
{
x_87 = as_type<int>((as_type<uint>(x_86) + as_type<uint>(1)));
x_87 = (x_86 + 1);
x_86_phi = x_87;
}
continue;
@@ -110,7 +110,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_87 = as_type<int>((as_type<uint>(x_86) + as_type<uint>(1)));
x_87 = (x_86 + 1);
x_86_phi = x_87;
}
}
@@ -125,7 +125,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
x_66 = x_66_phi;
x_63 = as_type<int>(as_type<int>((as_type<uint>(x_62) + as_type<uint>(x_66))));
x_63 = as_type<int>((x_62 + x_66));
if (x_41) {
while (true) {
if (x_41) {
@@ -143,7 +143,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_68 = as_type<int>((as_type<uint>(x_67) + as_type<uint>(1)));
x_68 = (x_67 + 1);
x_62_phi = x_63;
x_65_phi = x_66;
x_67_phi = x_68;
@@ -163,7 +163,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_53 = as_type<int>((as_type<uint>(x_52) + as_type<uint>(1)));
x_53 = (x_52 + 1);
x_45_phi = x_46;
x_48_phi = x_49;
x_50_phi = x_51;
@@ -215,7 +215,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
}
if (x_135) {
{
x_144 = as_type<int>((as_type<uint>(x_143) + as_type<uint>(1)));
x_144 = (x_143 + 1);
x_143_phi = x_144;
}
continue;
@@ -226,7 +226,7 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
break;
}
{
x_144 = as_type<int>((as_type<uint>(x_143) + as_type<uint>(1)));
x_144 = (x_143 + 1);
x_143_phi = x_144;
}
}
@@ -242,13 +242,13 @@ void main_1(constant buf0& x_6, thread float4* const tint_symbol_5, thread float
}
int x_119 = 0;
x_119 = x_119_phi;
x_116 = as_type<int>(as_type<int>((as_type<uint>(x_115) + as_type<uint>(x_119))));
x_116 = as_type<int>((x_115 + x_119));
if (select(x_41, false, !(x_41))) {
x_161_phi = x_116;
break;
}
{
x_121 = as_type<int>((as_type<uint>(x_120) + as_type<uint>(1)));
x_121 = (x_120 + 1);
x_115_phi = x_116;
x_118_phi = x_119;
x_120_phi = x_121;