encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-16 00:17:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "MSL writer: make signed int overflow defined behaviour"

Browse Source 
This reverts commit e5dbe24e94.

Reason for revert: Makes the Tint-Dawn roll fails because of
MSL compilation errors on as_type<uint>(-2147483648):
as_type cast from 'long' to 'uint' (aka 'unsigned int') is not allowed
   
as_type<uint>(-2147483647) compiles fine, so this is most
likely because the MSL compiler types the literal as a long
(since without the - it is larger than the max int32).

Original change's description:
> MSL writer: make signed int overflow defined behaviour
>
> Bug: tint:124
> Change-Id: Icf545b633d6390ceb7f639e80111390005e311a1
> Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60100
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
> Reviewed-by: David Neto <dneto@google.com>

TBR=dneto@google.com,bclayton@google.com,jrprice@google.com,amaiorano@google.com,noreply+kokoro@google.com,tint-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I3e3384a9185013bb141a1b7b9b22bad8571bbc50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: tint:124
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60345
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Corentin Wallez
2021-07-30 08:22:58 +00:00
committed by Tint LUCI CQ
parent 13969024c9
commit e33b0baa08
651 changed files with 3048 additions and 3963 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.spvasm.expected.msl
View File

@@ -718,7 +718,7 @@ void main_1(thread float4* const tint_symbol_23) {
case 17: {
x_391_phi = x_356;
if ((x_354 == as_type<int>(x_358))) {
x_390 = as_type<int>(as_type<int>((as_type<uint>(x_356) + as_type<uint>(as_type<int>(1)))));
x_390 = as_type<int>((x_356 + as_type<int>(1)));
x_391_phi = x_390;
}
x_391 = x_391_phi;
@@ -728,7 +728,7 @@ void main_1(thread float4* const tint_symbol_23) {
default: {
x_396_phi = x_356;
if ((x_354 == as_type<int>(-1))) {
x_395 = as_type<int>(as_type<int>((as_type<uint>(x_356) + as_type<uint>(as_type<int>(1)))));
x_395 = as_type<int>((x_356 + as_type<int>(1)));
x_396_phi = x_395;
}
x_396 = x_396_phi;
@@ -738,7 +738,7 @@ void main_1(thread float4* const tint_symbol_23) {
}
int const x_357 = x_357_phi;
{
x_359 = as_type<int>((as_type<uint>(x_358) + as_type<uint>(1)));
x_359 = (x_358 + 1);
x_353_phi = x_354;
x_356_phi = x_357;
x_358_phi = x_359;

6
test/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.wgsl.expected.msl
View File

@@ -718,7 +718,7 @@ void main_1(thread float4* const tint_symbol_23) {
case 17: {
x_391_phi = x_356;
if ((x_354 == as_type<int>(x_358))) {
x_390 = as_type<int>(as_type<int>((as_type<uint>(x_356) + as_type<uint>(as_type<int>(1)))));
x_390 = as_type<int>((x_356 + as_type<int>(1)));
x_391_phi = x_390;
}
x_391 = x_391_phi;
@@ -728,7 +728,7 @@ void main_1(thread float4* const tint_symbol_23) {
default: {
x_396_phi = x_356;
if ((x_354 == as_type<int>(-1))) {
x_395 = as_type<int>(as_type<int>((as_type<uint>(x_356) + as_type<uint>(as_type<int>(1)))));
x_395 = as_type<int>((x_356 + as_type<int>(1)));
x_396_phi = x_395;
}
x_396 = x_396_phi;
@@ -738,7 +738,7 @@ void main_1(thread float4* const tint_symbol_23) {
}
int const x_357 = x_357_phi;
{
x_359 = as_type<int>((as_type<uint>(x_358) + as_type<uint>(1)));
x_359 = (x_358 + 1);
x_353_phi = x_354;
x_356_phi = x_357;
x_358_phi = x_359;

8
test/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/1.spvasm.expected.msl
View File

@@ -258,7 +258,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
}
}
{
x_120 = as_type<int>((as_type<uint>(x_119) + as_type<uint>(1)));
x_120 = (x_119 + 1);
x_119_phi = x_120;
}
}
@@ -1070,7 +1070,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
case 17: {
x_607_phi = x_572;
if ((x_570 == as_type<int>(x_574))) {
x_606 = as_type<int>(as_type<int>((as_type<uint>(x_572) + as_type<uint>(as_type<int>(1)))));
x_606 = as_type<int>((x_572 + as_type<int>(1)));
x_607_phi = x_606;
}
x_607 = x_607_phi;
@@ -1080,7 +1080,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
default: {
x_612_phi = x_572;
if ((x_570 == as_type<int>(-1))) {
x_611 = as_type<int>(as_type<int>((as_type<uint>(x_572) + as_type<uint>(as_type<int>(1)))));
x_611 = as_type<int>((x_572 + as_type<int>(1)));
x_612_phi = x_611;
}
x_612 = x_612_phi;
@@ -1090,7 +1090,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
}
int const x_573 = x_573_phi;
{
x_575 = as_type<int>((as_type<uint>(x_574) + as_type<uint>(1)));
x_575 = (x_574 + 1);
x_569_phi = x_570;
x_572_phi = x_573;
x_574_phi = x_575;

8
test/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/1.wgsl.expected.msl
View File

@@ -258,7 +258,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
}
}
{
x_120 = as_type<int>((as_type<uint>(x_119) + as_type<uint>(1)));
x_120 = (x_119 + 1);
x_119_phi = x_120;
}
}
@@ -1070,7 +1070,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
case 17: {
x_607_phi = x_572;
if ((x_570 == as_type<int>(x_574))) {
x_606 = as_type<int>(as_type<int>((as_type<uint>(x_572) + as_type<uint>(as_type<int>(1)))));
x_606 = as_type<int>((x_572 + as_type<int>(1)));
x_607_phi = x_606;
}
x_607 = x_607_phi;
@@ -1080,7 +1080,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
default: {
x_612_phi = x_572;
if ((x_570 == as_type<int>(-1))) {
x_611 = as_type<int>(as_type<int>((as_type<uint>(x_572) + as_type<uint>(as_type<int>(1)))));
x_611 = as_type<int>((x_572 + as_type<int>(1)));
x_612_phi = x_611;
}
x_612 = x_612_phi;
@@ -1090,7 +1090,7 @@ void main_1(constant buf0& x_8, thread float4* const tint_symbol_24, thread floa
}
int const x_573 = x_573_phi;
{
x_575 = as_type<int>((as_type<uint>(x_574) + as_type<uint>(1)));
x_575 = (x_574 + 1);
x_569_phi = x_570;
x_572_phi = x_573;
x_574_phi = x_575;