encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[spirv-reader] Remove TODO about nested selections 

Remove TOOD about special code for finding badly nested selections.
This is already adequately covered by the dominance-violation checks,
and related tests:

  ClassifyCFGEdges_DomViolation_BeforeIfToSelectionInterior
  ClassifyCFGEdges_DomViolation_BeforeSwitchToSelectionInterior
  ClassifyCFGEdges_DomViolation_BeforeLoopToLoopBodyInterior
  ClassifyCFGEdges_DomViolation_BeforeContinueToContinueInterior
  ClassifyCFGEdges_DomViolation_AfterContinueToContinueInterior

Bug: tint:3
Change-Id: I8c547474d1422a54078d748b39a7d22a500d5d1d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/21482
Reviewed-by: dan sinclair <dsinclair@google.com>
This commit is contained in:
David Neto 2020-05-19 14:37:10 +00:00 committed by dan sinclair
parent c02de8fc45
commit e3d235662a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/reader/spirv/function.cc
View File

@ -479,7 +479,6 @@ bool FunctionEmitter::EmitBody() {
if (!FindIfSelectionInternalHeaders()) { if (!FindIfSelectionInternalHeaders()) {
return false; return false;
} }
// TODO(dneto): FindInvalidNestingBetweenSelections
if (!EmitFunctionVariables()) { if (!EmitFunctionVariables()) {
return false; return false;