encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-15 08:06:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor getting number of coordinate dimensions

Browse Source 
Change-Id: Ibafffb29bc33c722b8a4da25ed7a9c1986d13a24
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/38162
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Auto-Submit: David Neto <dneto@google.com>
This commit is contained in:
David Neto
2021-01-19 03:29:35 +00:00
committed by Commit Bot service account
parent 71012dcc2f
commit ed14524b1e
6 changed files with 85 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/reader/spirv/function.cc
View File

@@ -4340,41 +4340,12 @@ ast::ExpressionList FunctionEmitter::MakeCoordinateOperandsForImageAccess(
ast::type::TextureDimension dim =
unwrapped_type->As<ast::type::Texture>()->dim();
// Number of regular coordinates.
uint32_t num_axes = 0;
bool is_arrayed = false;
switch (dim) {
case ast::type::TextureDimension::k1d:
num_axes = 1;
break;
case ast::type::TextureDimension::k1dArray:
num_axes = 1;
is_arrayed = true;
break;
case ast::type::TextureDimension::k2d:
num_axes = 2;
break;
case ast::type::TextureDimension::k2dArray:
num_axes = 2;
is_arrayed = true;
break;
case ast::type::TextureDimension::k3d:
num_axes = 3;
break;
case ast::type::TextureDimension::kCube:
// For cubes, 3 coordinates form a direction vector.
num_axes = 3;
break;
case ast::type::TextureDimension::kCubeArray:
// For cubes, 3 coordinates form a direction vector.
num_axes = 3;
is_arrayed = true;
break;
default:
Fail() << "unsupported image dimensionality for " << type->type_name()
<< " prompted by " << inst.PrettyPrint();
return {};
uint32_t num_axes = ast::type::NumCoordinateAxes(dim);
bool is_arrayed = ast::type::IsTextureArray(dim);
if ((num_axes == 0) || (num_axes > 3)) {
Fail() << "unsupported image dimensionality for " << type->type_name()
<< " prompted by " << inst.PrettyPrint();
}
assert(num_axes <= 3);
const auto num_coords_required = num_axes + (is_arrayed ? 1 : 0);
uint32_t num_coords_supplied = 0;
auto* component_type = raw_coords.type;