mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-12-20 10:25:28 +00:00
Triage Dawn TODOs
Change-Id: Ia010e534df1ac8a82008b38c44cfd9dc3f0b1aa6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53340 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
@@ -23,7 +23,7 @@
|
||||
#include <limits>
|
||||
|
||||
// This is ANGLE's BitSetIterator class with a customizable return type
|
||||
// TODO(cwallez@chromium.org): it could be optimized, in particular when N <= 64
|
||||
// TODO(crbug.com/dawn/306): it could be optimized, in particular when N <= 64
|
||||
|
||||
template <typename T>
|
||||
T roundUp(const T value, const T alignment) {
|
||||
|
||||
@@ -95,7 +95,7 @@ namespace gpu_info {
|
||||
}
|
||||
}
|
||||
|
||||
// TODO(jiawei.shao@intel.com): support other GPU vendors
|
||||
// TODO(crbug.com/dawn/823): support other GPU vendors
|
||||
UNREACHABLE();
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -209,7 +209,7 @@ void SlabAllocatorImpl::Deallocate(void* ptr) {
|
||||
mRecycledSlabs.Prepend(slab);
|
||||
}
|
||||
|
||||
// TODO(enga): Occasionally prune slabs if |blocksInUse == 0|.
|
||||
// TODO(crbug.com/dawn/825): Occasionally prune slabs if |blocksInUse == 0|.
|
||||
// Doing so eagerly hurts performance.
|
||||
}
|
||||
|
||||
@@ -228,7 +228,7 @@ void SlabAllocatorImpl::GetNewSlab() {
|
||||
return;
|
||||
}
|
||||
|
||||
// TODO(enga): Use aligned_alloc with C++17.
|
||||
// TODO(crbug.com/dawn/824): Use aligned_alloc with C++17.
|
||||
char* allocation = new char[mTotalAllocationSize];
|
||||
char* alignedPtr = AlignPtr(allocation, mAllocationAlignment);
|
||||
|
||||
|
||||
@@ -57,7 +57,7 @@ class SlabAllocatorImpl {
|
||||
public:
|
||||
// Allocations host their current index and the index of the next free block.
|
||||
// Because this is an index, and not a byte offset, it can be much smaller than a size_t.
|
||||
// TODO(enga): Is uint8_t sufficient?
|
||||
// TODO(crbug.com/dawn/825): Is uint8_t sufficient?
|
||||
using Index = uint16_t;
|
||||
|
||||
SlabAllocatorImpl(SlabAllocatorImpl&& rhs);
|
||||
|
||||
Reference in New Issue
Block a user