encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update tools/format 

This Cl updates tools/format to match the various Dawn extensions and to
use the `clang_format.py` file from depot_tools instead of the one from
clang. This fixes up some formatting differences so `tools/format` will
now match `git cl format`.

Bug: dawn:1339
Change-Id: I32a2cdbd2d7e950794268616fae38b5bf54ab370
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86874
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-04-19 14:44:14 +00:00 committed by Dawn LUCI CQ
parent f80a759897
commit f0469eb65a
5 changed files with 42 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/dawn/native/Limits.cpp
View File

@ -153,8 +153,8 @@ namespace dawn::native {
Limits out;
#define X(Class, limitName, base, ...) \
if (IsLimitUndefined(limits.limitName) || \
CheckLimit<LimitClass::Class>::IsBetter( \
static_cast<decltype(limits.limitName)>(base), limits.limitName)) { \
CheckLimit<LimitClass::Class>::IsBetter(static_cast<decltype(limits.limitName)>(base), \
limits.limitName)) { \
/* If the limit is undefined or the default is better, use the default */ \
out.limitName = base; \
} else { \
@ -168,8 +168,8 @@ namespace dawn::native {
MaybeError ValidateLimits(const Limits& supportedLimits, const Limits& requiredLimits) {
#define X(Class, limitName, ...) \
if (!IsLimitUndefined(requiredLimits.limitName)) { \
DAWN_TRY_CONTEXT(CheckLimit<LimitClass::Class>::Validate( \
supportedLimits.limitName, requiredLimits.limitName), \
DAWN_TRY_CONTEXT(CheckLimit<LimitClass::Class>::Validate(supportedLimits.limitName, \
requiredLimits.limitName), \
"validating " #limitName); \
}
LIMITS(X)

2
src/dawn/node/interop/Core.h
View File

@ -119,7 +119,7 @@ namespace wgpu::interop {
// stringified values append to the error message.
// If Result is a success, then a success Result is returned.
template <typename... VALUES>
Result Append(VALUES&&... values) {
Result Append(VALUES && ... values) {
if (*this) {
return *this;
}

1
src/tint/reader/spirv/parser_impl_module_var_test.cc
View File

@ -1272,7 +1272,6 @@ TEST_F(SpvModuleScopeVarParserTest, DescriptorGroupDecoration_Valid) {
<< module_str;
}
TEST_F(SpvModuleScopeVarParserTest, BindingDecoration_Valid) {
auto p = parser(test::Assemble(Preamble() + FragMain() + R"(
OpDecorate %1 DescriptorSet 0 ; WGSL validation requires this already

10
tools/format
View File

@ -13,7 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
find src -name "*.h" -exec clang-format -i {} \;
find src -name "*.cc" -exec clang-format -i {} \;
find src/tint/cmd -name "*.h" -exec clang-format -i {} \;
find src/tint/cmd -name "*.cc" -exec clang-format -i {} \;
find src -name "*.h" -exec clang_format.py -i {} \;
find src -name "*.cc" -exec clang_format.py -i {} \;
find src -name "*.cpp" -exec clang_format.py -i {} \;
find src -name "*.m" -exec clang_format.py -i {} \;
find src -name "*.mm" -exec clang_format.py -i {} \;
find include -name "*.h" -exec clang_format.py -i {} \;