Refer TODO to Dawn issue 944

Refer the TODO in ShaderModuleBase::InjectCompilationMessages to
issue dawn:944 for further tracking.

Bug: dawn:753
Change-Id: I2ff09ba5914f2df0182bf26e9001a66782811f06
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/55223
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
This commit is contained in:
Zhaoming Jiang 2021-06-18 16:46:40 +00:00 committed by Dawn LUCI CQ
parent aef81d7406
commit f21d1f4d7a
1 changed files with 7 additions and 7 deletions

View File

@ -1293,13 +1293,13 @@ namespace dawn_native {
void ShaderModuleBase::InjectCompilationMessages(
std::unique_ptr<OwnedCompilationMessages> compilationMessages) {
// TODO(zhaoming.jiang@intel.com): ensure the InjectCompilationMessages is properly
// handled for shader module returned from cache.
// InjectCompilationMessages should be called only once for a shader module, after
// it is created. However currently InjectCompilationMessages may be called on a
// shader module returned from cache rather than newly created, and violate the rule.
// We just skip the injection in this case for now, but a proper solution including
// ensure the cache goes before the validation is required.
// TODO(dawn:944): ensure the InjectCompilationMessages is properly handled for shader
// module returned from cache.
// InjectCompilationMessages should be called only once for a shader module, after it is
// created. However currently InjectCompilationMessages may be called on a shader module
// returned from cache rather than newly created, and violate the rule. We just skip the
// injection in this case for now, but a proper solution including ensure the cache goes
// before the validation is required.
if (mCompilationMessages != nullptr) {
return;
}