encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-18 01:15:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

tint/writer/msl: Generate an array<T,N> helper

Browse Source 
And remove the WrapArraysInStructs transform.

Wrapping arrays in structures becomes troublesome for `const` arrays, as
currently WGSL does not allow `const` structures.

MSL 2.0+ has a builtin array<> helper, but we're targetting MSL 1.2, so
we have to emit our own. Fortunately, it can be done with a few lines of
templated code.

This produces significantly cleaner output.

Change-Id: Ifc92ef21e09befa252a07c856c4b5afdc51cc2e4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94540
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
This commit is contained in:
Ben Clayton
2022-06-24 17:01:59 +00:00
committed by Dawn LUCI CQ
parent 3c054304a8
commit f47887d207
218 changed files with 3637 additions and 2269 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/tint/statements/compound_assign/complex_lhs.wgsl.expected.msl
View File

@@ -1,12 +1,21 @@
#include <metal_stdlib>
using namespace metal;
struct tint_array_wrapper {
int4 arr[4];
template<typename T, size_t N>
struct tint_array {
const constant T& operator[](size_t i) const constant { return elements[i]; }
device T& operator[](size_t i) device { return elements[i]; }
const device T& operator[](size_t i) const device { return elements[i]; }
thread T& operator[](size_t i) thread { return elements[i]; }
const thread T& operator[](size_t i) const thread { return elements[i]; }
threadgroup T& operator[](size_t i) threadgroup { return elements[i]; }
const threadgroup T& operator[](size_t i) const threadgroup { return elements[i]; }
T elements[N];
};
struct S {
tint_array_wrapper a;
tint_array<int4, 4> a;
};
int foo(thread int* const tint_symbol_4) {
@@ -24,6 +33,6 @@ void tint_symbol(thread int* const tint_symbol_6) {
int const tint_symbol_3 = foo(tint_symbol_6);
int const tint_symbol_1_save = tint_symbol_3;
int const tint_symbol_2 = bar(tint_symbol_6);
x.a.arr[tint_symbol_1_save][tint_symbol_2] = as_type<int>((as_type<uint>(x.a.arr[tint_symbol_1_save][tint_symbol_2]) + as_type<uint>(5)));
x.a[tint_symbol_1_save][tint_symbol_2] = as_type<int>((as_type<uint>(x.a[tint_symbol_1_save][tint_symbol_2]) + as_type<uint>(5)));
}

25
test/tint/statements/compound_assign/for_loop.wgsl.expected.msl
View File

@@ -1,6 +1,19 @@
#include <metal_stdlib>
using namespace metal;
template<typename T, size_t N>
struct tint_array {
const constant T& operator[](size_t i) const constant { return elements[i]; }
device T& operator[](size_t i) device { return elements[i]; }
const device T& operator[](size_t i) const device { return elements[i]; }
thread T& operator[](size_t i) thread { return elements[i]; }
const thread T& operator[](size_t i) const thread { return elements[i]; }
threadgroup T& operator[](size_t i) threadgroup { return elements[i]; }
const threadgroup T& operator[](size_t i) const threadgroup { return elements[i]; }
T elements[N];
};
struct S {
int a;
float4 b;
@@ -22,19 +35,15 @@ int idx3(thread uint* const tint_symbol_7) {
return 1;
}
struct tint_array_wrapper {
float arr[4];
};
void foo(thread uint* const tint_symbol_8) {
tint_array_wrapper a = {.arr={}};
tint_array<float, 4> a = tint_array<float, 4>{};
int const tint_symbol_2 = idx1(tint_symbol_8);
int const tint_symbol_save = tint_symbol_2;
{
a.arr[tint_symbol_save] = (a.arr[tint_symbol_save] * 2.0f);
a[tint_symbol_save] = (a[tint_symbol_save] * 2.0f);
while (true) {
int const tint_symbol_3 = idx2(tint_symbol_8);
if (!((a.arr[tint_symbol_3] < 10.0f))) {
if (!((a[tint_symbol_3] < 10.0f))) {
break;
}
{
@@ -42,7 +51,7 @@ void foo(thread uint* const tint_symbol_8) {
{
int const tint_symbol_4 = idx3(tint_symbol_8);
int const tint_symbol_1_save = tint_symbol_4;
a.arr[tint_symbol_1_save] = (a.arr[tint_symbol_1_save] + 1.0f);
a[tint_symbol_1_save] = (a[tint_symbol_1_save] + 1.0f);
}
}
}