encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change UNREACHABLE to ASSERT(false) in OnDebugUtilsCallback 

In cases that a debug message does happen, we shouldn't use
unreachable as it will make the compiler use a false assumption.
Instead, only ASSERT(false) which crashes in debug, and does
nothing in release builds.

Bug: chromium:1375131
Change-Id: I7733151c241ee875ac40969ce22f037351141e89
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/110600
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
This commit is contained in:
Austin Eng 2022-11-17 20:54:14 +00:00 committed by Dawn LUCI CQ
parent c2e2013c2d
commit f6181d0365
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dawn/native/vulkan/BackendVk.cpp
View File

@ -157,7 +157,7 @@ OnDebugUtilsCallback(VkDebugUtilsMessageSeverityFlagBitsEXT messageSeverity,
// We get to this line if no device was associated with the message. Crash so that the failure // We get to this line if no device was associated with the message. Crash so that the failure
// is loud and makes tests fail in Debug. // is loud and makes tests fail in Debug.
dawn::ErrorLog() << pCallbackData->pMessage; dawn::ErrorLog() << pCallbackData->pMessage;
UNREACHABLE(); ASSERT(false);
return VK_FALSE; return VK_FALSE;
} }