encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-13 23:26:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disallow using cube or cube array texture views as storage textures

Browse Source 
This patch adds validations to forbid using cube or cube array texture
views as storage textures in Dawn as they are not supported on D3D12.

BUG=dawn:267
TEST=dawn_unittests

Change-Id: Iafb705a4bedae25ee54cfa45f710b2f3b7aab912
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22166
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
This commit is contained in:
Jiawei Shao
2020-05-28 00:17:08 +00:00
committed by Commit Bot service account
parent 55c85f66d2
commit f62ab75a5c
5 changed files with 98 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/tests/unittests/validation/ValidationTest.cpp
View File

@@ -51,7 +51,7 @@ wgpu::Device ValidationTest::CreateDeviceFromAdapter(
const std::vector<const char*>& requiredExtensions) {
wgpu::Device deviceToTest;
// Always keep the code path to test creating a device without a device descriptor.
// Always keep this code path to test creating a device without a device descriptor.
if (requiredExtensions.empty()) {
deviceToTest = wgpu::Device::Acquire(adapterToTest.CreateDevice());
} else {