encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Broaden -Wno-tautological-type-limit-compare 

In https://dawn-review.googlesource.com/c/dawn/+/24162 it was added
inside the is_win condition so it didn't take effect on Linux.

TBR=enga@chromium.org
TBR=senorblanco@chromium.org
Bug: None
Change-Id: Icc9ea20ed3a5ae4e5c514ce32bff88009ad82b1a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24240
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2020-07-02 09:21:08 +00:00 committed by Commit Bot service account
parent 4d007f34f3
commit f695264d30
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/common/BUILD.gn
View File

@ -108,6 +108,12 @@ config("dawn_internal") {
"-Wtautological-unsigned-zero-compare", "-Wtautological-unsigned-zero-compare",
] ]
# Allow comparison against type limits that might be tautological on 32bit
# or 64bit systems. Without this the following produces an error on 64bit:
#
# if (myUint64 > std::numeric_limits<size_t>::max()) {...}
cflags += [ "-Wno-tautological-type-limit-compare" ]
if (is_win) { if (is_win) {
cflags += [ cflags += [
# clang-cl doesn't know -pedantic, pass it explicitly to the clang driver # clang-cl doesn't know -pedantic, pass it explicitly to the clang driver
@ -115,13 +121,6 @@ config("dawn_internal") {
# Allow the use of __uuidof() # Allow the use of __uuidof()
"-Wno-language-extension-token", "-Wno-language-extension-token",
# Allow comparison against type limits that might be tautological on
# 32bit or 64bit systems. Without this the following produces an error
# on 64bit:
#
# if (myUint64 > std::numeric_limits<size_t>::max()) {...}
"-Wno-tautological-type-limit-compare",
] ]
} else { } else {
cflags += [ "-pedantic" ] cflags += [ "-pedantic" ]