encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-14 15:46:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add dynamic attribute in bind group layout binding

Browse Source 
WebGPU remove dynamic-uniform-buffer and dynamic-storage-buffer but add a new attribute in
BindgroupLayoutBinding to record whether a buffer resource is dynamic.
Dawn need to align with this change.

BUG=dawn:180

Change-Id: I873ad2ec75575e72d184f89a6e3698dff6df50d7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8520
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Yan, Shaobo
2019-07-09 07:58:57 +00:00
committed by Commit Bot service account
parent 8f93871dff
commit f697fe3b7d
19 changed files with 48 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn_native/opengl/CommandBufferGL.cpp
View File

@@ -266,11 +266,7 @@ namespace dawn_native { namespace opengl {
binding.offset, binding.size);
} break;
// TODO(shaobo.yan@intel.com): Implement dynamic buffer offset.
case dawn::BindingType::DynamicUniformBuffer:
case dawn::BindingType::DynamicStorageBuffer:
UNREACHABLE();
break;
// TODO(shaobo.yan@intel.com): Implement dynamic buffer offset.
}
}
}

4
src/dawn_native/opengl/PipelineGL.cpp
View File

@@ -136,10 +136,6 @@ namespace dawn_native { namespace opengl {
break;
// TODO(shaobo.yan@intel.com): Implement dynamic buffer offset.
case dawn::BindingType::DynamicUniformBuffer:
case dawn::BindingType::DynamicStorageBuffer:
UNREACHABLE();
break;
}
}
}

4
src/dawn_native/opengl/PipelineLayoutGL.cpp
View File

@@ -55,10 +55,6 @@ namespace dawn_native { namespace opengl {
break;
// TODO(shaobo.yan@intel.com): Implement dynamic buffer offset
case dawn::BindingType::DynamicUniformBuffer:
case dawn::BindingType::DynamicStorageBuffer:
UNREACHABLE();
break;
}
}
}