encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[validation] Validate if entry point functions accept parameters 

Bug: tint: 6
Change-Id: I7e9f50759e65ed6ef3dc25a6c004bec3dfbd4648
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27122
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Sarah Mashayekhi 2020-08-24 16:03:36 +00:00 committed by Commit Bot service account
parent c3038ddfa6
commit f70065f622
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/validator_function_test.cc
View File

@ -312,7 +312,7 @@ TEST_F(ValidateFunctionTest, EntryPointFunctionNotVoid_Fail) {
"12:34: v-0024: Entry point function must return void: 'vtx_main'"); "12:34: v-0024: Entry point function must return void: 'vtx_main'");
} }
TEST_F(ValidateFunctionTest, DISABLED_EntryPointFunctionWithParams_Fail) { TEST_F(ValidateFunctionTest, EntryPointFunctionWithParams_Fail) {
// entry_point vertex as "func" = vtx_func // entry_point vertex as "func" = vtx_func
// fn vtx_func(a : i32) -> void { return; } // fn vtx_func(a : i32) -> void { return; }
ast::type::I32Type i32; ast::type::I32Type i32;

6
src/validator_impl.cc
View File

@ -76,6 +76,12 @@ bool ValidatorImpl::ValidateEntryPoints(const ast::EntryPointList& eps) {
ep_ptr->function_name() + "'"); ep_ptr->function_name() + "'");
return false; return false;
} }
if (func->params().size() != 0) {
set_error(ep_ptr->source(),
"v-0023: Entry point function must accept no parameters: '" +
ep_ptr->function_name() + "'");
return false;
}
} }
return true; return true;
} }