encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-15 09:35:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add toggle to warn the dst-alpha issue on Intel GPUs

Browse Source 
Bug: dawn:1579
Change-Id: Ifdf09aefcdd62be82bd874a6e185b18ab96cb29a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114920
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Jiawei Shao 2022-12-21 02:22:53 +00:00 committed by Dawn LUCI CQ
parent 0493c24875
commit f8277d0ae4
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/dawn/native/Toggles.cpp
View File

@ -343,7 +343,12 @@ static constexpr ToggleEnumAndInfoList kToggleNameAndInfoList = {{
{"no_workaround_indirect_base_vertex_not_applied", {"no_workaround_indirect_base_vertex_not_applied",
"MacOS Intel < Gen9 has a bug where indirect base vertex is not applied for " "MacOS Intel < Gen9 has a bug where indirect base vertex is not applied for "
"drawIndexedIndirect. Draws are done as if it is always zero.", "drawIndexedIndirect. Draws are done as if it is always zero.",
"https://crbug.com/dawn/966"}} "https://crbug.com/dawn/966"}},
{Toggle::NoWorkaroundDstAlphaBlendDoesNotWork,
{"no_workaround_dst_alpha_blend_does_not_work",
"Using D3D12_BLEND_DEST_ALPHA as blend factor doesn't work correctly on the D3D12 backend "
"using Intel Gen9 or Gen9.5 GPUs.",
"https://crbug.com/dawn/1579"}},
// Comment to separate the }} so it is clearer what to copy-paste to add a toggle. // Comment to separate the }} so it is clearer what to copy-paste to add a toggle.
}}; }};
} // anonymous namespace } // anonymous namespace

1
src/dawn/native/Toggles.h
View File

@ -87,6 +87,7 @@ enum class Toggle {
// Unresolved issues. // Unresolved issues.
NoWorkaroundSampleMaskBecomesZeroForAllButLastColorTarget, NoWorkaroundSampleMaskBecomesZeroForAllButLastColorTarget,
NoWorkaroundIndirectBaseVertexNotApplied, NoWorkaroundIndirectBaseVertexNotApplied,
NoWorkaroundDstAlphaBlendDoesNotWork,
EnumCount, EnumCount,
InvalidEnum = EnumCount, InvalidEnum = EnumCount,

6
src/dawn/native/d3d12/DeviceD3D12.cpp
View File

@ -734,6 +734,12 @@ void Device::InitTogglesFromDriver() {
gpu_info::IsIntelGen11(vendorId, deviceId)) { gpu_info::IsIntelGen11(vendorId, deviceId)) {
SetToggle(Toggle::D3D12Allocate2DTexturewithCopyDstAsCommittedResource, true); SetToggle(Toggle::D3D12Allocate2DTexturewithCopyDstAsCommittedResource, true);
} }
// Currently this toggle is only needed on Intel Gen9 and Gen9.5 GPUs.
// See http://crbug.com/dawn/1579 for more information.
if (gpu_info::IsIntelGen9(vendorId, deviceId)) {
SetToggle(Toggle::NoWorkaroundDstAlphaBlendDoesNotWork, true);
}
} }
MaybeError Device::WaitForIdleForDestruction() { MaybeError Device::WaitForIdleForDestruction() {