encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reenable DepthBias tests on Swiftshader 

The fix in Swiftshader has been rolled into Dawn so they pass.

Bug: dawn:524
Change-Id: I0328672f6cdb829cb28799160d9f584ebed2e422
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/31666
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2020-11-04 15:59:11 +00:00 committed by Commit Bot service account
parent a0f1725c4f
commit fb367e32c6
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/tests/end2end/DepthBiasTests.cpp
View File

@ -139,10 +139,6 @@ TEST_P(DepthBiasTests, PositiveBiasOnFloat) {
// NVIDIA GPUs under Vulkan seem to be using a different scale than everyone else. // NVIDIA GPUs under Vulkan seem to be using a different scale than everyone else.
DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia()); DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia());
// SwiftShader incorrectly uses depthBias directly when calculating bias.
// TODO(enrico.galli@intel.com): Remove once it has been fixed upstream.
DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader());
// OpenGL uses a different scale than the other APIs // OpenGL uses a different scale than the other APIs
DAWN_SKIP_TEST_IF(IsOpenGL()); DAWN_SKIP_TEST_IF(IsOpenGL());
@ -162,10 +158,6 @@ TEST_P(DepthBiasTests, PositiveBiasOnFloat) {
// Test adding positive bias to output with a clamp // Test adding positive bias to output with a clamp
TEST_P(DepthBiasTests, PositiveBiasOnFloatWithClamp) { TEST_P(DepthBiasTests, PositiveBiasOnFloatWithClamp) {
// SwiftShader incorrectly uses depthBias directly when calculating bias.
// TODO(enrico.galli@intel.com): Remove once it has been fixed upstream.
DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader());
// Clamping support in OpenGL is spotty // Clamping support in OpenGL is spotty
DAWN_SKIP_TEST_IF(IsOpenGL()); DAWN_SKIP_TEST_IF(IsOpenGL());
@ -188,10 +180,6 @@ TEST_P(DepthBiasTests, NegativeBiasOnFloat) {
// NVIDIA GPUs seems to be using a different scale than everyone else // NVIDIA GPUs seems to be using a different scale than everyone else
DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia()); DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia());
// SwiftShader incorrectly uses depthBias directly when calculating bias.
// TODO(enrico.galli@intel.com): Remove once it has been fixed upstream.
DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader());
// OpenGL uses a different scale than the other APIs // OpenGL uses a different scale than the other APIs
DAWN_SKIP_TEST_IF(IsOpenGL()); DAWN_SKIP_TEST_IF(IsOpenGL());
@ -211,10 +199,6 @@ TEST_P(DepthBiasTests, NegativeBiasOnFloat) {
// Test adding negative bias to output with a clamp // Test adding negative bias to output with a clamp
TEST_P(DepthBiasTests, NegativeBiasOnFloatWithClamp) { TEST_P(DepthBiasTests, NegativeBiasOnFloatWithClamp) {
// SwiftShader incorrectly uses depthBias directly when calculating bias.
// TODO(enrico.galli@intel.com): Remove once it has been fixed upstream.
DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader());
// Clamping support in OpenGL is spotty // Clamping support in OpenGL is spotty
DAWN_SKIP_TEST_IF(IsOpenGL()); DAWN_SKIP_TEST_IF(IsOpenGL());
@ -234,10 +218,6 @@ TEST_P(DepthBiasTests, NegativeBiasOnFloatWithClamp) {
// Test adding positive infinite slope bias to output // Test adding positive infinite slope bias to output
TEST_P(DepthBiasTests, PositiveInfinitySlopeBiasOnFloat) { TEST_P(DepthBiasTests, PositiveInfinitySlopeBiasOnFloat) {
// SwiftShader incorrectly uses depthBias directly when calculating bias.
// TODO(enrico.galli@intel.com): Remove once it has been fixed upstream.
DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader());
// NVIDIA GPUs do not clamp values to 1 when using Inf slope bias. // NVIDIA GPUs do not clamp values to 1 when using Inf slope bias.
DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia()); DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia());
@ -257,10 +237,6 @@ TEST_P(DepthBiasTests, PositiveInfinitySlopeBiasOnFloat) {
// Test adding positive infinite slope bias to output // Test adding positive infinite slope bias to output
TEST_P(DepthBiasTests, NegativeInfinityBiasOnFloat) { TEST_P(DepthBiasTests, NegativeInfinityBiasOnFloat) {
// SwiftShader incorrectly uses depthBias directly when calculating bias.
// TODO(enrico.galli@intel.com): Remove once it has been fixed upstream.
DAWN_SKIP_TEST_IF(IsVulkan() && IsSwiftshader());
// NVIDIA GPUs do not clamp values to 0 when using -Inf slope bias. // NVIDIA GPUs do not clamp values to 0 when using -Inf slope bias.
DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia()); DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia());