encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-14 23:56:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

sem::Type: Replace GetDefaultAlignAndSize() with Size() and Align()

Browse Source 
This is a cleaner API, and the implementation doesn't have to know a bunch of information about all the derived types.

Change-Id: I96bebcb9f3ceda86fa34bd8e70961dee63fd7e13
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/59301
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
This commit is contained in:
Ben Clayton
2021-07-22 18:56:54 +00:00
committed by Tint LUCI CQ
parent f5ed2ba906
commit fced350b3d
26 changed files with 205 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/resolver/resolver.cc
View File

@@ -693,9 +693,7 @@ bool Resolver::ValidateStorageClassLayout(const sem::Struct* str,
};
auto required_alignment_of = [&](const sem::Type* ty) {
uint32_t actual_align = 0;
uint32_t actual_size = 0;
ty->GetDefaultAlignAndSize(actual_align, actual_size);
uint32_t actual_align = ty->Align();
uint32_t required_align = actual_align;
if (is_uniform_struct_or_array(ty)) {
required_align = utils::RoundUp(16u, actual_align);
@@ -3813,9 +3811,8 @@ sem::Array* Resolver::Array(const ast::Array* arr) {
return nullptr;
}
uint32_t el_align = 0;
uint32_t el_size = 0;
el_ty->GetDefaultAlignAndSize(el_align, el_size);
uint32_t el_align = el_ty->Align();
uint32_t el_size = el_ty->Size();
if (!ValidateNoDuplicateDecorations(arr->decorations())) {
return nullptr;
@@ -4035,9 +4032,8 @@ sem::Struct* Resolver::Structure(const ast::Struct* str) {
}
uint32_t offset = struct_size;
uint32_t align = 0;
uint32_t size = 0;
type->GetDefaultAlignAndSize(align, size);
uint32_t align = type->Align();
uint32_t size = type->Size();
if (!ValidateNoDuplicateDecorations(member->decorations())) {
return nullptr;