encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-03 11:46:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable EntryPointTests

Browse Source 
Tint now produces SPIRV that is sufficient for these tests to pass, so
re-enabling them.

The multiple entry point problem for HLSL mentioned in one of the other
skip statements appears to still be a KI, so not removing it.

Change-Id: I47005c815dc3cb9093d293e71caa3152c11bf0ac
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39100
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ryan Harrison 2021-02-02 22:01:40 +00:00 committed by Commit Bot service account
parent 299a3fafb3
commit fd5fd05db0
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tests/end2end/EntryPointTests.cpp
View File

@ -21,9 +21,8 @@ class EntryPointTests : public DawnTest {};
// Test creating a render pipeline from two entryPoints in the same module. // Test creating a render pipeline from two entryPoints in the same module.
TEST_P(EntryPointTests, FragAndVertexSameModule) { TEST_P(EntryPointTests, FragAndVertexSameModule) {
// TODO: Reenable once Tint is able to produce Vulkan 1.0 / 1.1 SPIR-V. // TODO(crbug.com/dawn/658): Crashes on bots
DAWN_SKIP_TEST_IF(IsVulkan() || IsOpenGL() || IsOpenGLES()); DAWN_SKIP_TEST_IF(IsOpenGL());
wgpu::ShaderModule module = utils::CreateShaderModuleFromWGSL(device, R"( wgpu::ShaderModule module = utils::CreateShaderModuleFromWGSL(device, R"(
[[builtin(position)]] var<out> Position : vec4<f32>; [[builtin(position)]] var<out> Position : vec4<f32>;
@ -67,9 +66,6 @@ TEST_P(EntryPointTests, FragAndVertexSameModule) {
// Test creating two compute pipelines from the same module. // Test creating two compute pipelines from the same module.
TEST_P(EntryPointTests, TwoComputeInModule) { TEST_P(EntryPointTests, TwoComputeInModule) {
// TODO: Reenable once Tint is able to produce Vulkan 1.0 / 1.1 SPIR-V.
DAWN_SKIP_TEST_IF(IsVulkan());
// TODO: Reenable once Tint's HLSL writer supports multiple entryPoints on a single stage. // TODO: Reenable once Tint's HLSL writer supports multiple entryPoints on a single stage.
// https://crbug.com/tint/297 // https://crbug.com/tint/297
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));