encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-09 13:38:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,833 Commits 2 Branches 0 Tags
12e858c35f6a1e77ecdfd529bac1a6a66a2b801b
Commit Graph

8833 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Corentin Wallez
d51b47ac67 remove_files.py: Print warnings on removals 
This will make it easier to debug build issues happening because if this
script in the future.

Bug: chromium:1314527
Change-Id: I5bbb4082ac816f98860e621917bc35b26ba7cb29
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87700
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-22 12:13:41 +00:00
Dawn Autoroller
5c284f456c Roll ANGLE from 0439d9cd25b4 to 8f56edfdd361 (2 revisions) 
0439d9cd25..8f56edfdd3

2022-04-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 408793418c48 to 192db13f8509 (548 revisions)
2022-04-21 ianelliott@google.com Revert "CGL, MTL: pbuffer for IOSurface fails for some formats"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I35e72539a30ab72a10548c60e694e7f4a563c159
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87676
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-22 11:23:11 +00:00
Fumitoshi Ukai
a238e7bf9d tint_generator_wgsl_corpus should wait for remove_stale_autogen_files 
remove_stale_autogen_files will remove files in
gen/third_party/daw/src/tint/fuzzers, so build
failed flakey with no such file under this directory
if remove_stale_autogen_files run after tint_generator_wsg_corpus
action.

add deps to remove_stale_autogen_files to make sure
tint_generator_wgsl_corpus runs after remove_stale_autogen_files run.

Bug: crbug.com/1314527
Change-Id: Ic072d1c80719cd1c1cf29b1ad4463792018ebb94
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87680
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
 2022-04-22 10:08:52 +00:00
Austin Eng
390b5a2176 Generalize expectation for recently added suppression. 
intel-0x3e92 was not added, but intel-0x5912 was - leading
to flaky CQ rejection depending on what bot happened to run
the task.

Generalize this expectation since it fails on all platforms
anyway.

Bug: dawn:1387
Change-Id: Iccd4806de456a817edf538041445ee2ac93099e7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87675
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-22 08:10:51 +00:00
Stephen Gutekanst
c2f9fea56b dawn/native: Fix undefined behaviour in BindGroupTracker when passing no dynamic offsets 
In [Mach engine](https://machengine.org), we compile Dawn's C++ sources using Zig as the C/C++
compiler and Zig's build system (we don't use Dawn's regular build system.) Zig uses clang
with UBSan enabled by default: this caught this instance of undefined behavior, where passing
no dynamic offsets would result in memcpy being called with size 0.

We've encountered at least [one other instance of undefined behavior](https://github.com/hexops/mach/issues/239)
via UBSan in addition to this one, which I will send another CL to fix soon. I'll also verify
we don't see any other instances of UB.

Bug: dawn:1371

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Change-Id: Ifc3b938e990b6a0a3b203796ea99ee5abb9a4a09
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87380
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
 2022-04-22 04:53:21 +00:00
Austin Eng
81a3c7cbdf Add back fail expectation on CTS Windows x86 
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel
Change-Id: I229846e8a9a4e8b047f23fc5b9134691022c96a9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87611
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
 2022-04-22 02:39:51 +00:00
Austin Eng
0c12837348 Make the dawn-try-win10-x86-rel trybot includable 
So manual builds can be triggered against it.

Change-Id: Ib47bf7bf4a74cef4aebf57e95f3b1c23694a5509
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87669
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
 2022-04-21 23:37:19 +00:00
Ben Clayton
66b70ec1a0 Roll third_party/webgpu-cts/ a06666e00..45d2ccd25 (3 commits) 
Update expectations and ts_sources

a06666e000..45d2ccd250
 - 45d2cc Fixed TS errors
 - 5eacfb Take new createView() dimension default logic into account
 - cbdcbd Explicitly destroy devices created by requestDevice_limits

Created with './tools/run cts roll'

Change-Id: I701bc9e6fa6b1996b1ed40b08766cc9dedaf20d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87621
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-04-21 23:18:10 +00:00
Dawn Autoroller
63f44b8b30 Roll ANGLE from b2a1f0d28a62 to 0439d9cd25b4 (25 revisions) 
b2a1f0d28a..0439d9cd25

2022-04-21 jmadill@chromium.org Vulkan: Update glslang wrapper TODO.
2022-04-21 jmadill@chromium.org Revert "Re-land: "Vulkan: Support Wayland""
2022-04-21 jmadill@chromium.org Expand Vulkan end2end_test skip.
2022-04-21 sugoi@google.com Disable MSAN in the Vulkan loader
2022-04-21 jmadill@chromium.org Android: Add //build to blueprint.
2022-04-21 Guoxing.Wu@arm.com Vulkan: use "undefined" for layerProvokingVertex
2022-04-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ea5f37f39193 to 71f3089b729c (5 revisions)
2022-04-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a434f1de2483 to 408793418c48 (456 revisions)
2022-04-21 lexa.knyazev@gmail.com Avoid IOError in capture_replay_tests.py
2022-04-21 steven@valvesoftware.com EGL: allow eglQueryString(EGL_NO_DISPLAY, EGL_VERSION)
2022-04-21 syoussefi@chromium.org Add a test for backwards mip generation with draw
2022-04-20 cclao@google.com Vulkan: Remove BufferVk::mHasBeenReferencedByGPU
2022-04-20 senorblanco@chromium.org D3D: unsuppress some now-passing tests.
2022-04-20 abdolrashidi@google.com Vulkan: Add perf test for MSAA swapchain resolve
2022-04-20 syoussefi@chromium.org Vulkan: Fix surface invalidate w.r.t shared present mode
2022-04-20 cnorthrop@google.com Tests: Add Free Fire Max trace
2022-04-20 jmadill@chromium.org Vulkan: Cache ImageView serials on texture changes.
2022-04-20 romanl@google.com Use adb directly (instead of catapult) in gold tests.
2022-04-20 jmadill@chromium.org Fix validate state cache after XFB buffer deleted.
2022-04-20 gman@chromium.org Metal:Clear Backbuffer when Robust Resource Init enabled
2022-04-20 kkinnunen@apple.com CGL, MTL: pbuffer for IOSurface fails for some formats
2022-04-20 jmadill@chromium.org Vulkan: Renaming "ShaderBuffers" to "ShaderResources".
2022-04-20 antonio.caggiano@collabora.com Re-land: "Vulkan: Support Wayland"
2022-04-20 syoussefi@chromium.org Fix ANGLEGetDisplayPlatform after method deprecation
2022-04-20 wnwen@chromium.org Switch to using //build/android:build_java

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I4120222ee498e0fb82dd935ee4e62f03202328ce
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87668
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-21 22:37:16 +00:00
Aleksi Sapon
4e1c65d030 Fix dawn_version_generator.py on Windows when not using depot_tools 
Find git using shutil.which() so extensions are resolved according to PATHEXT.

Remove the "print(e)" that is breaking the expected output.

Bug: dawn:1383
Change-Id: If299b744add0797036598129e08ba7d8c64002e1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87481
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
 2022-04-21 21:35:26 +00:00
James Price
aacad7c65e tint: Update FirstIndexOffsetTest expected results 
The change in https://dawn-review.googlesource.com/c/dawn/+/84240
modified the code generated by this transform, but didn't update the
Tint unit tests (which are not yet being run on Dawn's CQ).

Change-Id: I32d097d052f01628c3f8f5520c900b83422707e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87605
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-21 20:52:36 +00:00
dan sinclair
a2e94a5ac3 Fix readability/todo issues. 
This CL adds names to the TODOs which did not have them and enables
the readability/todo lint. The names are based on the git blame for
the TODO lines.

Bug: dawn:1339
Change-Id: I25a2920bc8fa9606f5dda67a629fdef1c10f8948
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87600
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-21 20:48:11 +00:00
dan sinclair
b0acbd436d Fix build/namespaces issues 
This CL fixes up various build/namespaces lint errors and enables
the lint check.

Bug: dawn:1339
Change-Id: Ib2edd0019cb010e2c6226abce6cfee50a0b4b763
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87482
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-21 16:46:56 +00:00
Brandon Jones
6cb57a9847 Change External Texture YUV-to-RGB Conversion to Use Matrix 
Changes Dawn and Tint to use a 3x3 matrix for external texture
YUV-to-RGB conversions. This will allow us to use standard matrices
as they exist in SkYuvMath.

Bugs: dawn::1082
Change-Id: I8e0c7c3dc1c085d8f336da956aea9496913b70fa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86847
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
 2022-04-21 16:02:36 +00:00
Ben Clayton
931a4ddb1c Update WebGPU CTS expectations 
• Remove a number of expectations that are no longer needed.
• Change a number of expectation tags to be more specific.
• Sort the expectations per chunk.
• Add a few more wide-wildcard 'Failure' rules for tests that commonly flake.

Bug: dawn:1342
Change-Id: I0e23cd546f7ab54a5720e24c52e3782b5df6b99f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87520
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-04-21 14:58:23 +00:00
dan sinclair
f05575bb21 [tint] Move validation code into a Validator class. 
This CL moves the Validate methods from the Resolver into a specific
Validator class used by the Resolver.

Bug: tint:1313
Change-Id: Ida21a0cc65f2679739c8499de7065ff8b58c4efc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87150
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-21 13:40:16 +00:00
Loko Kung
4091e0fa9c Factor out common cache testing code. 
- To be used for pipeline cache testing.
- Plumbs overriding the platform to the adapters for testing.
- Restructures build a little bit so that the test infrastructure can have full access to dawn native internals. Also differentiates end2end and white_box a bit more to make it clear that end2end should not have access to dawn native internals.

Bug: dawn:549, dawn:1374
Change-Id: Ibcc6c44a116c7967ee2317c74409f613e896eb0a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86841
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
 2022-04-21 03:14:37 +00:00
Yunchao He
12d45e2068 Update webgpu-cts/expectations.txt 
Fixed: dawn:1289
Change-Id: I5229653973990550d6c867e17100bf83de16a6e2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87500
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
 2022-04-21 02:55:55 +00:00
Enrico Galli
45ec7c3528 D3D12: Duplicate first/baseVertex on Draw[Indexed]Indirect 
Adds support for non-zero first/baseVertex on Draw[Indexed]Indirect by
duplicating the first/baseVertex indirect parameter onto a root
constant in the indirect buffer.

Change-Id: I280149065179806d3e57b07f1a396f9e2e4e8fcb
Bug: dawn:548
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84240
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Enrico Galli <enrico.galli@intel.com>
Auto-Submit: Enrico Galli <enrico.galli@intel.com>
 2022-04-21 02:25:35 +00:00
Loko Kung
cf078766c2 Adds typing to cache keys to avoid clashes. 
Bug: dawn:549
Change-Id: Ic3c737e62ae3bfcd1b20d923373a66f380d96149
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86401
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-21 02:04:57 +00:00
dawn-autoroll
65426d9325 Roll vulkan-deps from 158676f39f3b to df3a617e7556 (6 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/158676f39f3b..df3a617e7556

Changed dependencies:
* spirv-headers: 82becc8a8a..46b7918218
* spirv-tools: 2b2b0282af..671f6e633f
* vulkan-validation-layers: 5896a701e1..d3be3175c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I685c925f2ce284f00864f3a83d789c3d7207635b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87462
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-21 01:38:23 +00:00
Dawn Autoroller
c4b03ed854 Roll SwiftShader from ea5f37f39193 to 71f3089b729c (5 revisions) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea5f37f39193..71f3089b729c

2022-04-20 capn@google.com Revert "Temporarily ignore unsupported feature struct"
2022-04-20 swiftshader.regress@gmail.com Regres: Update test lists @ 88fe9ce0
2022-04-20 capn@google.com Automate downloading .git/hooks/commit-msg
2022-04-20 capn@google.com Run all LLVM passes in LLVMJIT.cpp
2022-04-20 swiftshader.regress@gmail.com Regres: Update test lists @ ea5f37f3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I38baad166c75e19f0534dc519bea947505111012
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87401
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-21 00:08:25 +00:00
Loko Kung
6d9b322958 Adds new BlobCache "re-declaration" of PersistentCache. 
- Note: goal is to merge the two into the same class, but to avoid breaking/fixing the current D3D12 shader caching, introducing a new one, and will merge the old one later on.
- Adds instance of BlobCache to the Instance, and passthrough for the Device to get to it. (We want the cache to be at the Instance so that eventually different devices can still use the cache (assuming same isolation key)).

Bug: dawn:549
Change-Id: Ib7c82a439f32b306f0cccd3db424fb0e427a90a1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86400
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
 2022-04-20 23:56:25 +00:00
Austin Eng
775fee6b6a Check GLFW window creation before discovering GL adapters 
GLFW window creation can fail. If so, we should not attempt to
make the context current and create adapters on it.

Bug: dawn:1375
Change-Id: Ie1a94a42d1f56514b41a715add7a2b4eebb763f0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87460
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
 2022-04-20 20:56:15 +00:00
Ben Clayton
2363ad16ea tools/src/cts/result: Add more helpers 
Add result.List.StatusTree() for building a query.Tree[Status].
Add helpers for serializing results.
Add helpers for merging and de-duplicating results.

Change the interface of result.List.ReplaceDuplicates() so that the
merging function takes a status set instead of a list of results.

Bug: dawn:1342
Change-Id: I77580ec5fd4c8f12109fb6e9e83afea8b740260c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87240
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-20 19:10:42 +00:00
Ben Clayton
1a10b73552 tools/src/cts/query: Add Tree 
A tree of query to data. Has utilities for reducing the tree based on a
custom merger function.

Bug: dawn:1342
Change-Id: If1c0503be05ee04bcf55dd5bdc9aa3caf6fb56ee
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87222
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-04-20 19:10:42 +00:00
dan sinclair
4c9b72b4fa Fixup readability/casting lint issues 
This CL fixes a few readability/casting issues and enables the lint
check.

Bug: dawn:1339
Change-Id: Ib0d127c3e01fad9b5ac074d8ca09f3a1956ad4fc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87020
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 19:02:29 +00:00
dan sinclair
3e0547df6c Ignore remaining explicit warnings. 
This CL ignores the remaining explicit warnings and enables the lint
flag.

Bug: dawn:1339
Change-Id: Idabc062c3d1a7ec563115dbfd600e80a908c856d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86873
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 18:24:15 +00:00
Dawn Autoroller
6a3a04dd07 Roll ANGLE from 55c21842b204 to b2a1f0d28a62 (8 revisions) 
55c21842b2..b2a1f0d28a

2022-04-20 jmadill@chromium.org Track total vs per-frame descriptor set counters.
2022-04-20 m.maiya@samsung.com Vulkan: Acquire a new buffer even when size is unchanged
2022-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 00e1ddd4230c to 158676f39f3b (8 revisions)
2022-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 103a69bd6c82 to ea5f37f39193 (3 revisions)
2022-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e1b5a693bbfe to a434f1de2483 (504 revisions)
2022-04-20 syoussefi@chromium.org Generate feature variable names from display names
2022-04-20 syoussefi@chromium.org Revert "Fix BlendStateExt::mMaxColorMask initialization"
2022-04-20 cclao@google.com Vulkan: Add orphaned list for non-empty BufferBlocks.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: If1639a5edc01db71c26ded05a1ebadb17be2578f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87400
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 2022-04-20 16:36:25 +00:00
dan sinclair
e22487f18c Ignore BindingLayoutEntryInitializationHelper for runtime/explicit. 
This CL ignores runtime/explicit on BindingLayoutEntryInitializationHelper.

Bug: dawn:1339
Change-Id: I3b4554387138ea77648be7a1e4f714f269996acc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86643
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 16:27:35 +00:00
Yunchao He
803f033392 D3D12: work around buffer size insufficient issue for copy 
D3D12 requires more buffer storage than it should. If the buffer used
for B2T/T2B copy is big enough according to WebGPU spec but it doesn't
meet D3D12's requirement, we need to workaround it via split the copy
into two copies, in order to make B2T/T2B copy being done correctly on
D3D12.

Bug: dawn:1289, dawn:1278

Change-Id: Id88c580dce00553845817677a2d356690ef4acfe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86860
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
 2022-04-20 16:18:05 +00:00
dan sinclair
b3483b68f7 Fix test expectation missing blank line. 
This broke when the inclusive language change was committed and the
newline was accidentally removed.

Change-Id: I447f34e07fd5f264b56e8ca205df558bd70946b6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87308
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-04-20 12:28:46 +00:00
dawn-autoroll
b442daef66 Roll vulkan-deps from 1380023f9816 to 158676f39f3b (1 revision) 
https://chromium.googlesource.com/vulkan-deps.git/+log/1380023f9816..158676f39f3b

Changed dependencies:
* vulkan-validation-layers: ce8691416f..5896a701e1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: Ie545d6808316d5414c00639a70bb14e3ee315807
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87384
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-04-20 10:32:45 +00:00
Dawn Autoroller
6b4ec8b2ab Roll SwiftShader from b5af7cabd5ea to ea5f37f39193 (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/b5af7cabd5ea..ea5f37f39193

2022-04-19 capn@google.com Support the new LLVM pass manager

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I2d83a01a7220a25c5e6dbf5026b237cc8c7e164e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87342
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-04-20 09:28:56 +00:00
Jiawei Shao
93a2bed032 Only allow creating 2D textures with RenderAttachment usage 
BUG=dawn:1364
TEST=dawn_unittests

Change-Id: I49cdeeac8b951c3715211fc3b3b71934a19a6e64
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86622
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
 2022-04-20 04:01:39 +00:00
Dawn Autoroller
ec571b5774 Roll ANGLE from dbe5b755485c to 55c21842b204 (14 revisions) 
dbe5b75548..55c21842b2

2022-04-19 jmadill@chromium.org Vulkan: Use flat array lookups for shader variables.
2022-04-19 senorblanco@chromium.org D3D: fix SSBOs used in vertex shaders.
2022-04-19 lexa.knyazev@gmail.com Fix BlendStateExt::mMaxColorMask initialization
2022-04-19 cclao@google.com Vulkan: Encapsulate ShareGroup::mContexts
2022-04-19 jmadill@chromium.org gold tests: Add command-line arg for gold instance.
2022-04-19 geofflang@google.com Mark contexts as shared when importing EGL images.
2022-04-19 jmadill@chromium.org Vulkan: Prep variable info map to remove hashing.
2022-04-19 cnorthrop@google.com Revert "Infra: Enable Skia Gold tests on Pixel 6"
2022-04-19 cnorthrop@google.com Tests: Add Monster Strike trace
2022-04-19 jmadill@chromium.org Use ProgramExecutable directly in GlslangWrapper.
2022-04-19 jmadill@chromium.org Add FastMap class.
2022-04-19 jmadill@chromium.org Skip a Vulkan test due to a threading flake.
2022-04-19 jmadill@chromium.org Revert "vulkan: Call glFinish in VulkanHelper destructor"
2022-04-19 b.schade@samsung.com Add check for GL_ANDROID_extension_pack_es31a support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I7baea8175544ddcc2b67a22982cc8a00045e8fe1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87341
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-04-20 02:58:45 +00:00
Shrek Shao
951d12e94c Add CTS DEPS as input for verify_gen_ts_dep_list action 
Change-Id: Id8b2528054a32192227261d81643fd68352e5857
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87304
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
 2022-04-20 02:34:55 +00:00
dan sinclair
09ce76b0d5 Fix runtime/int issues. 
This CL fixes up various runtime/int types to be more specific.

Bug: dawn:1339
Change-Id: I61c8ecc89abd0373173b95bfb594c75d05a5d505
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86865
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 02:05:24 +00:00
dan sinclair
36af06343c Fixup readability/namespace issues. 
This CL fixes a few readability/namespace issues and suppresses one
which is in conflict with the current formatting rules.

Bug: dawn:1339
Change-Id: Ifb688b05d50ebc3e698a77700178f87c93b14a46
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86867
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 01:54:25 +00:00
James Price
b6f4c59845 tint: Fix Matrix::FriendlyName() for inferred type 
The type field may be nullptr when a matrix constructor is used with
an inferred element type.

Change-Id: Ic11ba6a8efbed2a641c8a5ad3bbf0d074e4ca973
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87280
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: James Price <jrprice@google.com>
 2022-04-20 01:30:25 +00:00
dan sinclair
13e9699b1c Fix build/include_what_you_use 
This CL adds the needed headers to pass the include what you use lint
check.

Bug: dawn:1339
Change-Id: Ib8df68e51b2c3711169b400e84768d4804568580
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86941
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 00:58:34 +00:00
dan sinclair
4d6dfd5597 Convert LogMessage to explicit. 
This CL adds explicit and fixes up the various call sites for the
LogMessage class.

Bug: dawn:1339
Change-Id: Id244d0e31929d31346af48e116a40e7079a50372
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86872
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-20 00:36:54 +00:00
Ben Clayton
529747b041 tools/src/resultsdb: Request 'test_id' field 
Required as the test name tag field is limited to 256 bytes.

Bug: dawn:1342
Change-Id: I9f604181561acb6b7b9250599508474c0190333a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87221
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-04-20 00:29:05 +00:00
Ben Clayton
ba9404dac2 tools/src/utils: Add location.go 
Contains helpers for obtaining the source location of the caller

Bug: dawn:1342
Change-Id: I6eddf9140d10bc7889260392e04c3e2adec715d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87220
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
 2022-04-19 23:35:15 +00:00
dan sinclair
649687497f Convert SerialStorage::Iterator over to being explicit. 
This CL adds the attribute and fixes up the call sites to work with the
constructors being explicit.

Bug: dawn:1339
Change-Id: Ic584477c064411e42143dfc6179bbddb0d6a69c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86871
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-19 23:15:14 +00:00
dan sinclair
fb5a492787 Fix inclusive language presubmit 
The current presubmit has the filter inverted so it would only attempt
to match the filtered files. The file name also has to be converted to
`LocalPath` otherwise it's attempting to compare a python object to a
string and always fails to match.

Bug: dawn:1339
Change-Id: Ie7712dee60f6b9df2cb78c9feab11769f7ea1f02
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87080
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
 2022-04-19 22:25:45 +00:00
Shrek Shao
6a3373e419 Fix a webgpu-cts crbug ticket 
Bug: dawn:1325
Change-Id: I204fd3777458871ef7d7c398a2023388b33f0aa5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87301
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
 2022-04-19 22:22:20 +00:00
Yunchao He
8f28d21176 Add more tests to RequiredBufferSizeInCopyTests 
The new tests reveal that this incorrect calculation of buffer size
requirement on D3D12 exist only when:
  - the texture dimension is 3D, and
  - there are rowsPerImage paddings (imageLayout.rowsPerImage >
  copySize.height), and
  - it's copying multiple depth images (copySize.depthOrArrayLayers > 1).

The new tests can guide and narrow down the workaround for this issue.

Bug: dawn:1289
Change-Id: I4136d6e3aa3680a65739bfdd402dc0d46debfd8d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87162
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
 2022-04-19 21:57:45 +00:00
dawn-autoroll
799420d347 Roll vulkan-deps from 2a1479d73345 to 1380023f9816 (8 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/2a1479d73345..1380023f9816

Changed dependencies:
* spirv-cross: 6a67891418..d7cae5e7cd
* spirv-tools: cb96abbf7a..2b2b0282af
* vulkan-validation-layers: 8a6fe16b4a..ce8691416f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I17b5e5d08f7e8b9e631a3f940ea6e68f99527cad
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87321
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
 2022-04-19 21:42:04 +00:00
dan sinclair
b3741f5036 Add missing doc comment. 
This CL should fix the doxygen error on kokoro.

Change-Id: I820e6e6674edbc1af2b51ceb3cf87d724d7c0962
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87300
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
 2022-04-19 21:40:05 +00:00