e13160efb6
tint/utils: Add Hashmap and Hashset
...
Algorithmically faster than `std::unordered_[map|set]`, and use a small vector internally reducing heap allocations.
Change-Id: I9c0b00468272d9d7c72ab077d832d66d1368500c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98123
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-17 16:28:23 +00:00
81f0686523
tint/utils/vector: Allow use of incomplete types
...
Attempting to make a Vector of an incomplete pointer type would trigger an error as the `CanReinterpretSlice` trail magic is wanting to know the base types, which isn't known yet.
Split `CanReinterpretSlice` into class specializations, where the common case of no-cast doesn't look at the base types.
Change-Id: Id016b027b131f7988ccf3cae93622dacb7802a1d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98140
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-17 15:42:15 +00:00
6e716c77ac
Sync some WGSL grammar names to spec
...
This CL updates some of the names used in the WGSL parser to match
the grammar rules in the spec.
Bug: tint:1633
Change-Id: I489e1c6a945bdd6063d400cfdbd87aa81a97c5f0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99200
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-08-17 14:28:31 +00:00
f8a34d08dd
tint: Add CheckedSub functions
...
Bug: tint:1581
Change-Id: Iee836af4b5a1252335f680cba7ab4e04c2996728
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99420
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-17 12:46:39 +00:00
5ef011f2c3
Roll SwiftShader from c61fc9aec162 to 3fb7084b02d7 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/c61fc9aec162..3fb7084b02d7
2022-08-16 sugoi@google.com Update Marl to 2f129cf1b
2022-08-16 sugoi@google.com update-marl: run Gerrit hook on generated CLs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I6eec635c37ff72707dc66b61ab8bbdea38b9ed80
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99343
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-17 05:08:49 +00:00
1130a602ef
d3d12: Disallow creating external image after device destruction
...
ExternalImageDXGIImpl holds a weak reference to the device. If the
device is destroyed before the image is created, the image will have a
dangling reference to the device which can cause a use-after-free.
This CL fixes that by adding a ValidateIsAlive() check before creating
the image similar to creating other API objects.
Bug: chromium:1352802
Change-Id: I477f15680ffd27e1ad0166835c4debb80b4be761
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99384
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-17 03:52:59 +00:00
97a6c2a265
Roll ANGLE from 0f5770deabf2 to 213a1ee6e6db (10 revisions)
...
0f5770deab..213a1ee6e6syoussefi@chromium.org Vulkan: Enable VK_EXT_primitives_generated_query
2022-08-16 solti@google.com Adding angle_perftests test case names in logcat
2022-08-16 romanl@google.com Avoid logging None introduced in https://crrev.com/c/3831885
2022-08-16 romanl@google.com Improve Ctrl-c handling.
2022-08-16 syoussefi@chromium.org Vulkan: Use VK_EXT_primitive_topology_list_restart
2022-08-16 solti@google.com Update CHROMIUM_copy_texture.txt to match the code
2022-08-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a6c3e363b7a9 to c61fc9aec162 (1 revision)
2022-08-16 romanl@google.com Refactor to reduce main loop complexity.
2022-08-16 capn@google.com Unconditionally enable EGL_ANGLE_iosurface_client_buffer on macOS
2022-08-16 romanl@google.com Reland "Infra: Enable Skia Gold tests on Pixel 6"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: Ic3132dab47883168db6218d8605ccd7780864d38
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99342
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-17 03:20:49 +00:00
f83652f019
Remove suppressions from dawn:1471.
...
- Tests seem to be passing fine in manual testing. Fixes throughout key
generation and stream implementation may have unintentionally fixed
this issue.
Fixed: dawn:1471
Change-Id: I17268d66be6dfc47cd7f3b480b424909f18e7f1f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99422
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-16 22:44:09 +00:00
d9d6dfac9a
Enable the workaround about T2T copy on Intel Gen11 GPUs
...
This patch enables the workaround about using a temporary buffer in
the T2T copy on Intel Gen11 GPUs after running WebGPU CTS on these
platforms.
Bug: chromium:1161355
Change-Id: Id4a4f189b4a7a3954dc66062d27e9b226d1409f6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99320
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-16 18:05:03 +00:00
c8b0cfe7e3
Roll SwiftShader from a6c3e363b7a9 to c61fc9aec162 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/a6c3e363b7a9..c61fc9aec162
2022-08-16 syoussefi@google.com Implement VK_EXT_primitive_topology_list_restart
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I3f0fcb4070d5846386c44f176f1baeffebb153ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99341
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-16 16:04:52 +00:00
2de4deea1f
tint: Fix implicit conversion of vector-scalar of abstract types in binary operations
...
Example: const v2 = vec3(1) + 2.2;
Bug: chromium:1350147
Change-Id: Ie75d76bf00a6b2f6abd49293290f6e5065c31dfb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99301
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-16 16:00:02 +00:00
bade13a5d2
Roll ANGLE from 2089943b951d to 0f5770deabf2 (1 revision)
...
2089943b95..0f5770deabangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 16d8164e92a5 to 754ede9fc072 (380 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: Iabf1e768222384df81a12e282c78b5118cee1716
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99340
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-16 14:24:32 +00:00
dadb934e19
Roll vulkan-deps from fb0e26499a68 to 863822794aa7 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/fb0e26499a68..863822794aa7
Changed dependencies:
* spirv-tools: 3a8a961cff..9abacb34a550fe2fc2d0..e51d0d1c18https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I4b435403b7e172e8f0d5eb5b052f0591b18d0719
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99300
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-16 07:54:32 +00:00
c81cefe06e
Roll ANGLE from 042fda3cacda to 2089943b951d (4 revisions)
...
042fda3cac..2089943b95cnorthrop@google.com Tests: Add Lumino City trace
2022-08-15 penghuang@chromium.org Not use Android TLS slot for chromium
2022-08-15 romanl@google.com Use stdout instead of (default) stderr in logging.StreamHandler
2022-08-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 2438c1b18a5e to a6c3e363b7a9 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: I2a29d41e7a761eeac7d650e3ea4e833e23839767
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99260
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-16 00:45:31 +00:00
fa4a7291f2
tint: add [[nodiscard]] on utils::Result class
...
Helps when changing the return type of a function from `void` to
`Result<T>`. The compiler fails in places where the return value is
ignored, which is never what we want with Result.
Change-Id: Id3271ea9fb1128f8f493030f013b2b577235be8f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99160
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-15 19:31:51 +00:00
c935b497e6
Split some structs out of DawnTest.h into their own file.
...
This allows them to be fully defined before being referenced, which
fixes compile errors in C++20.
Bug: chromium:1284275
Change-Id: I3c0f874406247c04d53710431931f82c3deaff3c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99080
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Peter Kasting <pkasting@google.com>
Auto-Submit: Peter Kasting <pkasting@google.com>
2022-08-15 18:55:41 +00:00
3632062811
Roll vulkan-deps from 3ebe695e969a to fb0e26499a68 (4 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/3ebe695e969a..fb0e26499a68
Changed dependencies:
* vulkan-loader: a0ab2f162e..16d5d8f25449314e0667..50fe2fc2d0https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC alanbaker@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: alanbaker@google.com
Change-Id: Ic9af848c1a4bbe079b9495faafecb798e0679c4a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99142
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-15 18:44:41 +00:00
cc937971c9
tint: natvis: add utils::Slice, utils::Vector, and utils::VectorRef
...
Bug: tint:1331
Change-Id: I710c3f390234160d1c21a04f71bd26eb56ff585a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99140
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-15 18:29:21 +00:00
cdb5397283
Roll ANGLE from 4c941149774f to 042fda3cacda (1 revision)
...
4c94114977..042fda3cacangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f904dc881cb8 to 16d8164e92a5 (630 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I7b5602179427bbe0858ad3a92f97341f0f98931f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99120
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-15 11:50:46 +00:00
735e4b4fa1
Emit deprecation for fallthrough.
...
The `fallthrough` statement is being removed from WGSL. This CL adds
a deprecation warning into the current implementation to prepare folks
for the upcoming removal.
Bug: tint:1644
Change-Id: I599984b6a30b39312c4b794a9ecd70f0f626c759
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98841
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-15 11:41:07 +00:00
52cc4f5d1c
Add a target for the GLFW surface helper.
...
This CL moves the GLFWUtils.cpp into a dawn/glfw/utils.cpp and
GLFWUtils.h into include/webgpu/webgpu_glfw.h. A build target
(`webgpu_glfw` alias to `dawn_glfw`) is added in order to allow
using that target in downstream projects without having to re-implement.
Change-Id: I93e85d5af3f486b3c754f2f854aafbda51901d6d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98700
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-08-14 15:59:25 +00:00
fe835738c5
Roll vulkan-deps from e6cb539dad97 to 3ebe695e969a (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/e6cb539dad97..3ebe695e969a
Changed dependencies:
* vulkan-validation-layers: 3f5c2c3799..49314e0667https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: enga@google.com
Change-Id: I4f6bceec2f0bb579fad32c897b37a791ff7995b7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99002
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-13 08:36:24 +00:00
c7bfab6b11
Roll ANGLE from 67e0c6fcc974 to 4c941149774f (5 revisions)
...
67e0c6fcc9..4c94114977ffz@google.com External Texture Support In MEC
2022-08-12 abdolrashidi@google.com Skip kotor trace on Swiftshader due to flakiness
2022-08-12 penghuang@chromium.org Use angle::FlatUnorderedSet for ImageSibling::mSourcesOf
2022-08-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from eaf78cbfdaed to 5a93cd60f33b (4 revisions)
2022-08-12 penghuang@chromium.org Use FixedVector for Framebuffer::mDirtyColorAttachmentBindings
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I4d4cb6a9aa341d27febca70df324485ce382ca6b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98962
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-13 06:17:34 +00:00
24559c4672
doxygen: Skip libfuzzer header
...
libfuzzer contains preprocessor magic that makes doxygen choke.
Define `TESTING_LIBFUZZER_LIBFUZZER_EXPORTS_H_` so that doxygen skips over this header. We don't want to generate documentation for this non-tint code anyway.
Fixed: tint:1647
Change-Id: I084a6c3db0ffe492a62a1f9dcb0c30b68cebb9e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99040
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-12 22:46:53 +00:00
4681f5bddd
Moves sorting into `format` and out of `parse`.
...
- Reverts test updates in
https://dawn-review.googlesource.com/c/dawn/+/98761 that were
introduced because of the sorting in `parse`.
Change-Id: Ia27386e9aa2f16b9a4ba26e77207e5a4d6f4df97
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99020
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-12 22:05:13 +00:00
a3553af2c4
Roll SwiftShader from 2438c1b18a5e to a6c3e363b7a9 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/2438c1b18a5e..a6c3e363b7a9
2022-08-12 capn@google.com Regres: Roll dEQP to main revision eaf78cb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I24eae7d6e097b63be19b63ec950aec49b3e9826b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98961
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-12 21:41:03 +00:00
f7ee534b2c
Beautify visitable structs with more helpers
...
Bug: dawn:1480
Change-Id: I01450e1916766daba016f71c0ed825e6b6664541
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98840
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-12 20:39:03 +00:00
c166087d4c
Roll vulkan-deps from 03dd80c1d579 to e6cb539dad97 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/03dd80c1d579..e6cb539dad97
Changed dependencies:
* glslang: f771c1293d..10423ec65920f4a87be1..3f5c2c3799https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I1ff3b38b6a10ce27a72e2f96ec42297d26e21501
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99000
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-12 19:27:03 +00:00
727f27d4d3
Roll ANGLE from 2ebd5100902e to 67e0c6fcc974 (4 revisions)
...
2ebd510090..67e0c6fcc9syoussefi@chromium.org PRESUBMIT: Remove unnecessary escape of forward slash
2022-08-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 708ca9579181 to 2438c1b18a5e (2 revisions)
2022-08-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e4653aba963d to f904dc881cb8 (487 revisions)
2022-08-12 penghuang@chromium.org Use angle::FlatUnorderedMap in Display.cpp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I7b7bee076d2cc76cfd394d2f0ef1bd800850b483
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98960
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-12 17:04:53 +00:00
15719a22f3
Roll vulkan-deps from 476824373c19 to 03dd80c1d579 (9 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/476824373c19..03dd80c1d579
Changed dependencies:
* glslang: adf7bf0113..f771c1293d0a43a84e02..3a8a961cfff12e9b3a66..20f4a87be1https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ide3827f07f76e7cff3d5767d87e6d36fa0a826b2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98940
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-12 05:50:32 +00:00
2c36bc628c
Roll ANGLE from 26bb1d6e80cb to 2ebd5100902e (12 revisions)
...
26bb1d6e80..2ebd510090eddiehatfield@google.com Add gl::Context as a parameter to Shader::resolveCompile
2022-08-12 penghuang@chromium.org Use angle::FlatUnorderedSet for ImageState::targets
2022-08-12 kpiddington@apple.com Translator: Fix crashes with monomorphizing loops
2022-08-11 cclao@google.com Vulkan: Never stage update for EGLImage
2022-08-11 rafael.cintron@microsoft.com Reflect TextureD3D label updates with storage object
2022-08-11 chris@rive.app Require all PLS formats to consume exactly 4 bytes of storage
2022-08-11 cclao@google.com Vulkan: Destroy fb1 should not affect fb2 with same attachments
2022-08-11 chris@rive.app Make PLS coherent on Vulkan
2022-08-11 kpiddington@apple.com Separate Struct declarations earlier
2022-08-11 syoussefi@chromium.org Presubmit: Verify ANGLE_SH_VERSION update
2022-08-11 penghuang@chromium.org Fix EGL_ANGLE_program_cache_control for eglCreateContext
2022-08-11 geofflang@google.com TestSuiteTest: Generate more unique result file names.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I9c86966c5f7cf4e15d366cc3ce4cea85482e4f29
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98920
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-12 03:30:22 +00:00
66c6f8581d
Roll SwiftShader from 708ca9579181 to 2438c1b18a5e (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/708ca9579181..2438c1b18a5e
2022-08-11 capn@google.com Ignore feature structs of partially promoted extensions
2022-08-11 capn@google.com Don't expose VK_EXT_external_memory_host on macOS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I8d0628db06b658eee166568f384baf51e216de8b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98900
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-12 00:04:02 +00:00
4acf608cf2
Include 'libfuzzer_exports.h' in fuzzers that are missing it
...
This is part of a workaround in the Chromium build infrastructure for
the fact that on Mac, the linker tends to strip LLVMFuzzer*
implementation because of how they are loaded/used.
All of the rest of the machinary is already setup and working, just
need to actually include the header. Dawn and other fuzzers use this
same fix.
BUG=chromium:1319605
Change-Id: Ifced8e0b29a48cdf64cd82002c90eb3c765b01c0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98880
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-08-11 20:41:31 +00:00
36ddc12e3a
Roll vulkan-deps from d53c356ad7d9 to 476824373c19 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/d53c356ad7d9..476824373c19
Changed dependencies:
* vulkan-validation-layers: 529a4320d3..f12e9b3a66https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Iff444e17755d6c49ceda8d2cf3cb16d5d58378c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98861
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-11 16:57:21 +00:00
ced4c0d2cd
Add test list to deps
...
Adds the generated CTS test list to the existing gn/webgpu-cts group
so that Chromium tests properly include the generated file.
Also updates some existing BUILD.gn file paths to be consistent with
Chromium styling: relative paths without the leading ./ for files
under the current directory and directories before and separate from
individual files.
Bug: dawn:1479
Change-Id: Icce70e7fcee874b6b33c21230c8a4429a1f7ab6c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98801
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-11 15:16:38 +00:00
0653501212
Switch to message protocol
...
Switches the WebGPU CTS test runner JavaScript code to use the defined
message protocol instead of the ad-hoc solution we were using before.
Bug: chromium:1340602
Change-Id: Ieaf26b5b2409f69d7859d3db4ce7757780de6712
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98684
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
2022-08-11 14:39:51 +00:00
6af4c8b97d
Roll ANGLE from 3d0faa02e237 to 26bb1d6e80cb (3 revisions)
...
3d0faa02e2..26bb1d6e80angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c728ed48ce2f to d53c356ad7d9 (3 revisions)
2022-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from aafa10869568 to 708ca9579181 (4 revisions)
2022-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d830698e47ae to e4653aba963d (476 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Iac864f353c5c278b33b879ab282f1a3cc2ec05f2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98820
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-11 14:38:01 +00:00
bf0707d138
Roll SwiftShader from 16826bfa6f73 to 708ca9579181 (3 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/16826bfa6f73..708ca9579181
2022-08-11 capn@google.com Eliminate unscale constants
2022-08-11 nicolas.capens@gmail.com Make maskAny() SIMD width agnostic.
2022-08-11 capn@google.com Support constructing a SIMD constant from a lambda expression
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ic0ec1aaf226c0f9f092ec00648f863b12c4e0860
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98782
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-11 11:10:21 +00:00
0d3a7bbd7e
Fixes go test failures and issues from dawn/98241.
...
Change-Id: Idf4f47eba595dcf3f2c44b5f73179b2773a68aef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98761
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-11 07:50:21 +00:00
3abad2c125
When emitting a MSL struct initializer emit the struct name.
...
This CL changes the MSL emission for struct initializers to emit the
struct name first.
`const a = {.f=float3(1)}` becomes `const a = Normals{.f=float3(1)}`.
This fixes an issues where the initialization happens inside an array
which the downstream compiler rejected without the explicit struct
naming.
Bug: tint:1641
Change-Id: I948b9ca94f4b89eac6d5bbbaa615b3d71d50c737
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98760
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-08-11 02:28:01 +00:00
7126ed9111
Add eager Transition support for external textures
...
This eagerly transitions external textures to be ready for export
on every submit. With this support, we can save the current submit
of export.
Bug: chromium:1258986
Change-Id: I92c2019ff486afc24adc190a1f7b2f85f416cd52
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97642
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
2022-08-11 01:36:21 +00:00
490294e6fe
Roll ANGLE from ee09383861f0 to 3d0faa02e237 (9 revisions)
...
ee09383861..3d0faa02e2romanl@google.com Remove workaround affecting --list-tests --gtest_filter=X.
2022-08-10 syoussefi@chromium.org Vulkan: Query support for VK_KHR_imageless_framebuffer
2022-08-10 syoussefi@chromium.org Vulkan: Use VK_EXT_primitives_generated_query
2022-08-10 romanl@google.com Fix ANGLE_HAS_HISTOGRAMS following crrev.com/c/3817602
2022-08-10 chris@rive.app Rename ShFragmentSynchronizationType::None -> NoSynchronization
2022-08-10 syoussefi@chromium.org Vulkan: Workaround ARM bug with stencil write mask
2022-08-10 romanl@google.com Add config angle_maybe_has_histograms to angle_perftests_common.
2022-08-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fe14e7954b25 to c728ed48ce2f (8 revisions)
2022-08-10 geofflang@google.com Mark FormatPrintTest as potentially uninstantiated.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I2a97de99ea2e4e153de7dc31e30c932e01994476
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98781
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-11 00:58:01 +00:00
369f368ac4
Roll vulkan-deps from c728ed48ce2f to d53c356ad7d9 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/c728ed48ce2f..d53c356ad7d9
Changed dependencies:
* spirv-tools: 0ebcdc4d19..0a43a84e026ace8025bb..529a4320d3https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I98134eae169da859946927de1f4e93873c5bcccc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98800
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-10 23:31:31 +00:00
a13e30de10
Roll SwiftShader from aafa10869568 to 16826bfa6f73 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/aafa10869568..16826bfa6f73
2022-08-10 capn@google.com Fix printing SIMD::Pointer offsets
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ib94f8dc70f1b5517be8e3b11413f84727eefc2f9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-10 21:53:01 +00:00
a58d8c9fac
tint: fix builtin calls and binary ops with abstract args of different type
...
If a call to atan2 with args of type AFloat and AInt is made, Resolver
would correctly select the atan2(AFloat, AFloat) overload, but if the
input args were of type (AFloat, AInt), it would attempt to constant
evaluate without first converting the AInt arg to AFloat. The same would
occur for a binary operation, say AFloat + AInt. Before constant
evaluating, the Resolver now converts AInt to AFloat if necessary.
Bug: chromium:1350147
Change-Id: I85390c5d7af7e706115278ece34b2b18b8574f9f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98543
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-10 20:01:17 +00:00
90d5eb6128
tint: Add RemovePhonies transform to spir-v backend
...
This will be needed by an upcoming CL that fixes call statements to
builtins that return a constant value. Without this transform, the
constant value reaches the backend, where we don't currently deal with
abstract numbers. Note that the other backends (HLSL, MSL, GLSL) already
use this transform.
Bug: chromium:1350147
Change-Id: Icc1f1416a07db228f8e3f39851a9ac079c48319f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98740
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-10 19:32:23 +00:00
b91d7e1b31
Spit `expect_variable_ident_decl` into helper and calling methods.
...
This Cl spits the `expect_variable_ident_decl` apart to only accept
the `variable_ident_decl` grammar element. A
`expect_ident_or_variable_ident_decl` is added for the ident optional
version and a helper used by those two methods.
This makes it a lot clearer at the caller side how the calls relate
to the grammar.
Bug: tint:1633
Change-Id: I50aa4852926ff217129fe728e434255ed008da61
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98661
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
2022-08-10 18:54:43 +00:00
7058a17bda
tint: refactor ConstEval API to accept vector of constants rather than of expressions
...
This is needed for a follow-up change to apply implicit conversions for
AFloat to AInt.
Bug: chromium:1350147
Change-Id: Id903322d01b7aa420452c3e0fc1fa4e1c480c794
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98683
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-10 18:06:43 +00:00
a8e9a6ef2b
tint: Fix Resolver erroneously materializing matrices of abstract numeric type
...
ShouldMaterializeArgument must check that the deepest element is not
abstract numeric to support matrices.
This CL also enables the "no materialize" tests for binary ops, as
constant evaluation of binary addition was recently landed, and that's
what the test uses. The fix in this CL is also necessary for this test
to pass the matrix addition case (it would fail because it erroneously
materialized).
Bug: tint:1581
Change-Id: Id55341c05604c1ac560127826fc415eb38792503
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98682
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-10 14:32:19 +00:00
f350578c99
Roll ANGLE from 8050079c116c to ee09383861f0 (3 revisions)
...
8050079c11..ee09383861angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6306836d087b to d830698e47ae (506 revisions)
2022-08-10 syoussefi@chromium.org Vulkan: Don't break render pass on read-only buffer updates
2022-08-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 678ffefb1b3b to aafa10869568 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ic46c5fb3a322d87c188f8809610af8fe763c6780
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98688
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-10 11:52:53 +00:00
Ben Clayton
dan sinclair
Antonio Maiorano
Dawn Autoroller
Sunny Sachanandani
Loko Kung
Jiawei Shao
Peter Kasting
Austin Eng
Ryan Harrison
Brian Sheedy
jchen10