Change-Id: I65bd3ac1b21bd67cdd854e36f38769a824f442db
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68523
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>
This is not included in the default for 'filter' as it is far from ready.
Also: Don't generate SKIPs in the excluded directories.
Change-Id: I02cb40c1bf8adebc77e9e5102988dd41e4b1f7a1
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68522
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
In HLSL code, if a switch statement has only a default case, FXC will
effectively ignore the code in that case. In this change, we detect this
and work around it by emitting the code in the default block without the
switch.
Bug: tint:1188
Change-Id: I69b405cdb4c669fb093eb49aa138923419dcf8f8
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68440
Kokoro: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@chromium.org>
The semantic nodes cannot be fully immutable, as they contain cyclic
references. Remove Resolver::CreateSemanticNodes(), and instead
construct and mutate the semantic nodes in the single traversal pass.
Give up on trying to maintain the 'authored' type names (aliased names).
These are a nightmare to maintain, and provided limited use.
Significantly simplfies the Resolver, and allows us to generate more
semantic to semantic references, reducing sem -> ast -> sem hops.
Note: This change introduces constant value propagation across constant
variables. This is unlocked by the earlier construction of the
sem::Variable.
Change-Id: I592092fdc47fe24d30e512952511c9ab7c16d7a1
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68406
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Explicitly name references as either Direct or Transitive.
Rename workgroup_size() to WorkgroupSize().
Remove the return_statements. These were not used anywhere.
Change-Id: I7191665db9c3211d086dd90939abec7003cd7be7
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68405
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
And put it into the utils namespace.
Change-Id: Ib4c6fadc63954196d572148d0e96ffec6e3bbb38
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68404
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
There's no need for the ScopeStack to include 'global' information. This
is easily obtainable from the element type.
Replace the get-by-reference, with a simpler return value.
Change-Id: Ic6f4c0f656a2019417d68ffb3fe85ba8343ad15e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68403
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Update or remove tests that try to do this.
Fixed: tint:491
Change-Id: I1f351a4abf68ae9bc6b100885fb1bcea08b31211
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68242
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
WGSL does not support pointer-to-vector-component, so the SPIR-V
reader needs to sink these pointers into their use.
Bug: tint:491
Change-Id: Ib5ae87d2f6bbac13280314ba11369d7ced505b56
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68241
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
These were using `[EXPECT|ASSERT]_THAT` when they could be using `[EXPECT|ASSERT]_EQ`
Change-Id: Id967571ed121b5805f15b16d263c03c716296e1a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68401
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
In all three modes, this cancels the current operations as soon as
possible. For tests that hang, this ensures we can Ctrl+C the process
and get the stdout from those tests.
Bug: dawn:1163
Change-Id: Ib3e45b533adaf510e1f9454a59ef1e821fc3eccd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68300
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
This flag was previously removed.
Change-Id: I8b6ed8dd8966fcf7b587a65e78dcc06c2b2a9cd2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68240
Auto-Submit: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Same as passing in "--flag=dawn-backend=<name>".
Also, if VK_ICD_FILENAMES env var is set, force backend=vulkan.
Bug: dawn:1163
Change-Id: If2def47e1af2a1eba7fbf897c8ed1ebf92ae4a15
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68183
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
WebGPU community has decided how to handle color space conversion.
This also add more supported dst color format for
copyExternalImageToTexture.
This CL update the supported dst texture formats to align with
WebGPU spec. This is also the preparation for color space conversion.
Bug: dawn:1140
Change-Id: Ibf4386d5cec4acb086e111229dd8bba36a5f6bcd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67620
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
- Updates error message formatting to ensure they end with a newline to
prevent errors from running together.
- Updated all encoder/device context messages to normalize their format
and include more information.
- Update Abseil formatter to make objects indicate if they are an error
object in the formatted string. (ie: [Invalid BindGroup])
- Added fallback code in case a context message doesn't format
correctly to aid in debugging.
Bug: dawn:1154
Change-Id: Id27b11305cf8efcca343597f90489dde5552c775
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68200
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This change also makes sure that all three modes (serial, isolated
parallel, and server) all output stdout of tests only if verbose mode is
enabled.
Bug: dawn:1163
Change-Id: I9e9efcfa4b73571adac15179d2792fb745255fb8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68182
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
4aedb71f4b..fce240c005
$ git log 4aedb71f4..fce240c00 --date=short --no-merges --format='%ad %ae %s'
2021-10-29 timvp AOSP: Use '-Os' rather than '-Oz'
2021-11-02 senorblanco Implement ANGLE_FALLTHROUGH macro.
2021-10-28 gert.wollny Capture/Replay: Capture name in GetProgramResourceIndex
2021-10-21 gert.wollny Capture/Replay: Add ES3_1_Vulkan_SwiftShader expectations
2021-11-02 jmadill infra: Expose ASAN configs in try.
2021-11-02 gert.wollny Capture/Replay: Mark test to be flaky on Windows
2021-11-02 angle-autoroll Roll SwiftShader from 9d8950e082d8 to 542593f0e311 (3 revisions)
2021-10-29 abdolrashidi Complete validation of glGetAttribLocation()
2021-10-27 yuxinhu Add detachShader capture calls in MEC
2021-10-22 steven d3d11: fix typo in pixel shader function signatures
2021-10-29 angle-autoroll Roll VK-GL-CTS from 49afd2823061 to 06492d671a2d (6 revisions)
2021-10-12 jmadill infra: Add ANGLE-side configuration for ASAN tests.
2021-10-29 gman Template gl::Rectangle so it can be used for float
2021-11-01 angle-autoroll Roll vulkan-deps from a03d00bd2a78 to d388b3abde67 (16 revisions)
2021-10-29 syoussefi Suppress failing test
2021-10-30 timvp Revert "Vulkan: Don't expose MSRTT on SwiftShader"
2021-10-27 kpiddington Merge Webkit up to Oct 27 2021
2021-10-28 timvp Android: Add back third_party/ to AOSP
2021-10-19 jmadill Vulkan: Implement robust shader outputs.
2021-10-25 timvp Vulkan: Only add samplable formats to outCompressedTextureFormats
2021-10-28 gman Fix Blitting in Metal backend.
2021-10-28 jmadill translator: Always report gl_FragData array size.
2021-10-22 lubosz.sarnecki DisplayVkAndroid: Always expose EGL_RECORDABLE_ANDROID.
2021-10-28 syoussefi Vulkan: Don't expose MSRTT on SwiftShader
2021-10-28 penghuang vulkan: implement EGLDevice for vulkan backend
2021-10-28 syoussefi Vulkan: Remove MSRTT assertion in the presence of OOM
2021-10-14 lubosz.sarnecki capture_gles_3_2: Skip capturing debug calls
2021-10-29 angle-autoroll Roll Chromium from 367ea8143d4d to b8a060d71358 (521 revisions)
2021-10-26 cclao Vulkan: Avoid unnecessary wait if mapBufferRange indicates read only
2021-10-28 syoussefi Vulkan: SPIR-V Gen: Fix float+matrix
2021-10-28 timvp Disable flaky multithreaded tests
2021-10-14 jmadill Vulkan: Remove "current queue serial".
2021-10-06 b.schade Translator: Fixed textureGatherOffsets validation
2021-10-18 jmadill Refactor program pipeline handling.
2021-10-27 jmadill GN: Remove unneeded version header visibility rule.
2021-10-28 hans Drop -Wweak-template-vtables
2021-10-28 angle-autoroll Roll vulkan-deps from e706a029a256 to a03d00bd2a78 (5 revisions)
2021-10-28 angle-autoroll Roll SwiftShader from d143249a93bc to 9d8950e082d8 (3 revisions)
2021-10-28 angle-autoroll Roll Chromium from 6e4379b531a3 to 367ea8143d4d (450 revisions)
2021-10-27 timvp win-trace: Skip failing tests
2021-10-27 kpiddington Metal: Use 'fast' normalize to match DEQP expectations
2021-10-25 kpiddington Metal: Use ES3 validation for GL_R/RG8_EXT formats
2021-10-25 penghuang VANGLE: change the default vulkan device choose logic
2021-10-27 angle-autoroll Roll VK-GL-CTS from e2aeccde416b to 49afd2823061 (34 revisions)
2021-10-27 jmadill Vulkan: Fix accessing stale FB cached variable.
2021-10-27 syoussefi Switch to python3 in DEPS
2021-10-27 angle-autoroll Roll SwiftShader from 21810915c4f1 to d143249a93bc (1 revision)
2021-10-27 angle-autoroll Roll vulkan-deps from 06cd4429bf9e to e706a029a256 (10 revisions)
2021-10-26 thakis Run clang update script under python3 in angle
2021-10-26 ajgo disable cfguards for all deqp tests
(...)
2021-08-23 angle-autoroll Roll vulkan-deps from 1dec6c3c106b to 1262ad6fdd3f (7 revisions)
2021-08-05 syoussefi Translator: Be more explicit about precisions
2021-08-23 angle-autoroll Roll Chromium from 873a11ee2df8 to 2136fe7a73f0 (293 revisions)
2021-08-21 lexa.knyazev Add ASTC & PVRTC to GLenumToString
2021-08-18 jmadill Capture/Replay: Init shader outputs during self-tests.
2021-08-20 jmadill translator: Fix InitializeVariables with gl_ClipDistance.
2021-08-20 jmadill infra: Update Milo perf short names.
2021-08-20 jmadill infra: Update angle_mb_config.pyl with new perf names.
2021-08-20 angle-autoroll Roll Chromium from 40a15381a86b to 873a11ee2df8 (930 revisions)
2021-08-20 jmadill infra: Make perf builders GPU-config-specific.
2021-08-16 jmadill Add EGL extension to create window with a swap interval set.
2021-08-18 jmadill Test Runner: Determine slow tests from test expectations.
2021-08-18 jmadill Ensure RGB10A2 format properly uses 4 pixel bytes.
2021-08-18 geofflang GL: Update VertexArrayGL to use ANGLE_GL_TRY.
2021-08-18 jmadill Capture/Replay: Don't access OOB in TexImage2D.
2021-08-14 gert.wollny Capture/Replay: Add the layer to the texture data label string
2021-08-20 angle-autoroll Roll vulkan-deps from 4a1a688a34d6 to 1dec6c3c106b (3 revisions)
2021-08-19 gman Add delimeter to attribute search
2021-08-19 jonross Turn off ProgramBinaryES3Test direct-to-Metal tests
2021-08-18 jmadill Capture/Replay: Improvements to testing script.
2021-08-19 jmadill Capture/Replay: Fix extra frame captured with trigger.
2021-08-19 angle-autoroll Roll SwiftShader from 803ceb58c92c to 9eb5acaba94c (4 revisions)
2021-08-16 jmadill Capture/Replay: Update serialization logic.
2021-08-19 angle-autoroll Roll vulkan-deps from 370f9682fb33 to 4a1a688a34d6 (6 revisions)
2021-08-18 kbr Turn on the first few direct-to-Metal tests by default.
2021-08-18 gman Use the correct attribute locations in Metal
2021-08-18 lexa.knyazev GL: Add emulateImmutableCompressedTexture3D workaround
2021-08-18 jmadill Fix Texture2DTest.TextureSize.
2021-08-16 jmadill Capture/Replay: MEC consistency improvements.
2021-08-16 jmadill Capture/Replay: Changes to MEC first frame capture.
2021-08-04 ynovikov Reland "Properly report xcb_connect failures in DisplayVkXcb"
2021-08-16 gert.wollny Capture/Replay: Pop only after using values it in endGroup
2021-08-18 angle-autoroll Roll Chromium from df8e98bc8f6e to 40a15381a86b (437 revisions)
2021-08-18 angle-autoroll Roll vulkan-deps from 59563d9384fb to 370f9682fb33 (10 revisions)
2021-08-17 jmadill Capture/Replay: Clean up ResourceTracker access.
2021-08-18 jmadill Vulkan: Suppress layered FB validation error.
2021-08-18 jmadill Trace Tests: Skip sakura school sim on Win/Intel.
2021-08-16 jmadill libANGLE: Minor cleanups.
2021-04-19 b.schade Prevent separable programs from relying on attached shaders
2021-08-17 jmadill GN: Disable unreachable code warnings in GLES 1 tests.
2021-08-16 gman Add depth fix to convert from GL to Metal
2021-08-17 jmadill infra: Increase sharding in CI angle_perftests.
2021-08-17 jmadill Skip a flaky test on SwANGLE.
2021-08-17 angle-autoroll Roll Chromium from aeae79104c34 to df8e98bc8f6e (460 revisions)
2021-08-17 jmadill dEQP: Remove Pixel 2/XL test expectations.
2021-08-17 angle-autoroll Roll SwiftShader from 526b987888fb to 803ceb58c92c (2 revisions)
2021-08-17 angle-autoroll Roll vulkan-deps from 510c98092bc0 to 59563d9384fb (18 revisions)
2021-08-17 jmadill Manually roll android bundle tool.
2021-08-16 jmadill Perf Runner: Properly merge histograms.
2021-07-20 natsu Vulkan: Flush read RT if color attachment is the read buffer
Created with:
roll-dep third_party/angle
Change-Id: I6aa3d115f760a91ed9f3446347d6a1f81594c97a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68181
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
This change adds a end2end test for readonly depth/stencil
attachment and implements it on D3D12.
This change focuses on depth. If it is OK, I will add test(s) for
stencil.
The key points are:
- Set DEPTH_READ transition barrier to replace DEPTH_WRITE barrier
if it is readonly depth/stencil attachment.
- Set appropriate D3D12_DEPTH_STENCIL_DESC (which is already correct)
and D3D12_DEPTH_STENCIL_VIEW_DESC (which needs some particular
flags). Otherwise, the underlying driver (validation layer) may
think we still need DEPTH_WRITE transition barrier.
Bug: dawn:485
Change-Id: I64d30426ed8042a98b3fef084bb90b125320a6f8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67742
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Instead of using BufferLocation as another layer of indirection,
the indirectBuffer can be set directly on the indirect command.
This makes the indirect validation a bit simpler, but introduces
additional lifetime dependencies in that the indirect draw validation
MUST be encoded while the DrawIndexedIndirectCmds it references
are still valid.
Bug: dawn:809
Change-Id: I1ef084622d8737ad5ec1b0247bf9062712e35008
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67241
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Improves various error messages that have received feeback indicating
that they were too confusing or poorly worded.
Bug: dawn:1152
Bug: dawn:1157
Change-Id: If740300f31278ab04d4493887c03918a09cf0f86
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68100
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
These flags are forwarded to the cts cmdline/server to configure dawn.node.
I also documented this in the README, along with examples.
Bug: dawn:1163
Change-Id: I6e213f1bd64700564c2e54dcd4edcf219ef2e829
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/68060
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This will help with review load and finding an owner once mandatory
owner review is enabled.
Change-Id: I1a90b83fed68f062c1406552aec218bf9c2092ce
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67821
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
This patch adds trace events on the creation of shader module,
render pipeline and compute pipeline so that we can measure how
expensive these tasks are in chrome://tracing
BUG=dawn:1167
Change-Id: Iffc37adea49d7e04b9f757bc8b3679769085a428
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67880
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
If the texture attachment doesn't have a stencil aspect, we can
set stencilReadOnly flag in RenderPassDepthStencilAttachment as
we want. And it is totally ignored and it doesn't impact whether
the depth/stencil attachment is readonly or not.
That's true for depthReadOnly flag upon a stecil-only format like
stencil8, but we haven't support stencil8 yet.
Bug: dawn:485
Change-Id: If0a21250ce7cc7a1ad9cc17a05ecf64d05342cd0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67962
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
The changes should pass through the destroy changes such that when the device is destroyed, the respective destroy functionality currently existing in the backends should be called.
For buffers, destroy no longer causes validation errors since even error buffers may need to be destroyed in the case of mappedAtCreation.
Bug: dawn:628, dawn:1002
Change-Id: I42a475af5d67cc60f86d95ac53c2b377a9fd2e82
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65863
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Dawn Autoroller
Ben Clayton
James Price
Antonio Maiorano
Austin Eng
Shrek Shao
Stephen White
Yan
Brandon Jones
Yunchao He
Corentin Wallez
Jiawei Shao
Loko Kung