Commit Graph

12316 Commits

Author SHA1 Message Date
Jiawei Shao 7c2fa23a7e Implement the optional feature "bgra8unorm-storage" on D3D12
This patch adds the support of the optional feature "bgra8unorm-storage"
on D3D12 when the platform allows using DXGI_FORMAT_B8G8R8A8_UNORM as
UAVs.

According to D3D12 documents, enabling the flag
D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS when creating textures requires
"either the texture format must support unordered access capabilities at
the current feature level. Or, when the format is a typeless format, a
format within the same typeless group must support unordered access
capabilities at the current feature level".

Bug: dawn:1641
Test: dawn_end2end_tests
Change-Id: If16271b5da52423e73ad4f7ba258af83dbf66dd2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119345
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-02-14 00:29:52 +00:00
Jiawei Shao 01456d97ea Implement the optional feature "bgra8unorm-storage" on Vulkan
This patch implements the optional feature "bgra8unorm-storage" on
Vulkan. As SPIR-V doesn't support 'bgra8' as a valid image format,
we have to create an image view with RGBA8Unorm format on the
BGRA8Unorm texture when we want to use it as a storage texture.

Bug: dawn:1641
Test: dawn_end2end_tests
Change-Id: I4aeea96ae872fe4e6367c535afb6ab896b952453
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118021
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-02-14 00:27:34 +00:00
dawn-autoroll 7c0774fc2c Roll vulkan-deps from 428c60617e42 to 2405a8767ae1 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/428c60617e42..2405a8767ae1

Changed dependencies:
* vulkan-loader: ebb932a402..e2a3fc1b98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I9883fe19de9aa86cec6783d2ecfea225fc4aee50
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-14 00:13:57 +00:00
Kai Ninomiya e30e4a2983 Update expectations with clang-coverage tag
Bug: chromium:1413845
Change-Id: Id2d34f1c7830239f55fb03e1341db8b3e215fc57
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119580
Commit-Queue: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
2023-02-13 23:24:51 +00:00
Dawn Autoroller a9def90b6b Roll SwiftShader from 938d3a1fac4d to a36600f98b9b (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/938d3a1fac4d..a36600f98b9b

2023-02-13 pkasting@chromium.org Compile in whatever C++ version is default.
2023-02-13 pkasting@chromium.org Fix build for C++20.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC bajones@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bajones@google.com
Change-Id: I916ae60ab72039f210a91faed6170fda20cb0a0e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119721
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-13 22:07:24 +00:00
Ben Clayton a5b9e96b39 tint/reader/spirv: Work around pointers to null store types.
Bug: tint:1838
Change-Id: I84564a1b9888634808af2a1c7bb1e77c80947216
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119700
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
2023-02-13 21:22:21 +00:00
Austin Eng 151913d29b VideoViewsTests: add test which uses a sampler per plane
This test sees flaky failures.
 - Check the entire checkerboard texture contents to get more
information.
 - Add a test which uses seperate sampling states to see if DX12
driver has difficulty sampling multi-planar formats using a
single sampler.
 - Also, double check support for the NV12 format in case
something in the driver flakily exposes support.

From https://dawn-review.googlesource.com/c/dawn/+/47660

Bug: dawn:733
Change-Id: I766907ff648f1dc35387902a70c3fb65debcaecd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119343
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Austin Eng <enga@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
2023-02-13 18:35:04 +00:00
Austin Eng 44032e5084 Unblock multi-mip stencil textures on Metal
These textures still have some outstanding issues on both Intel and AMD,
where the wrong subresource can be read from.
Zero-initialization workarounds have been enabled to ensure that even
when the wrong subresource is read, uninitialized data is not read.

Bug: dawn:704, dawn:791, dawn:838
Change-Id: Ib118eff0c5ed5e7812fa70e88ece5317c1af13b0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116849
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2023-02-13 18:04:00 +00:00
Austin Eng 20881f39e7 Add basic Adapter blocklist
Adds a basic adapter blocklist and adds two cases to it.

By default, the blocklist is disabled until Chromium can enable it
explicitly - perhaps based on --enable-unsafe-webgpu or some other
flag. It will be switched to default to true in the future.

about://gpu would disable the blocklist so all the adapters are
visible there, but WebGPU would enable it. Trusted users of Dawn
that are aware of potential bugs may also disable it.
One downside is that about://gpu won't surface directly that an
adapter is on the system, but blocklisted for WebGPU. Something
like that can be added in the future, if necessary.

In the future, this should probably be merged with Chromium's
software_rendering_list.json, but that list doesn't support
multi-adapter systems well (for blocklisting just one adapter),
and it doesn't understand all the information we need for the
current blocklist.

Bug: dawn:1254, dawn:1196, tint:1753
Change-Id: I992bcd10dd5d3f5b23319fc4ec699b06bb1117da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119061
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-02-13 17:10:44 +00:00
Peng Huang 708a0777e1 Fix gclient sync problem when dawn is built with chromium
Change-Id: I6c2276ccf1a5addfd61009b8a7a68f5938c9126f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119560
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-02-13 11:38:38 +00:00
Dawn Autoroller 23f0932918 Roll ANGLE from 62d35a602258 to e60b0e4eddd5 (1 revision)
62d35a6022..e60b0e4edd

2023-02-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5221896b4233 to 155bf9f7bac6 (660 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: Idcf6982dee06563feaabe2b32d998ecaab72b32a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119640
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-13 11:36:00 +00:00
dawn-autoroll a8fc67faae Roll vulkan-deps from 917146595ebe to 428c60617e42 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/917146595ebe..428c60617e42

Changed dependencies:
* vulkan-validation-layers: 6e62e504d2..ebc1fbec61

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: If8a56d3e91ea357187d1af4d9aed68617a883264
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119660
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-02-13 10:31:42 +00:00
Kai Ninomiya a75b0c0f13 Set OWNERS to * on .txt files needed for CTS rolls
Bug: None
No-Try: True
Change-Id: I6f6f337c463cf2f5f7a1bfb9de51b09ae19ebc91
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119581
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-02-13 10:17:04 +00:00
Dawn Autoroller d77b903bdd Roll ANGLE from 90ddd7c7602d to 62d35a602258 (1 revision)
90ddd7c760..62d35a6022

2023-02-11 kkinnunen@apple.com Metal Fix norm16 subimage uploads w/ signed types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: I41331bba6926271a101453587cb90407a6d29b99
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119620
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-12 03:27:06 +00:00
dawn-autoroll 9eeebfcffc Roll vulkan-deps from e780219ed8ba to 917146595ebe (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/e780219ed8ba..917146595ebe

Changed dependencies:
* spirv-tools: 5b48c549b0..7221381361

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: I3832c3b7df6ccd9fbfd7b49b7df25aabbd0ede6a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119583
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-12 02:01:56 +00:00
Dawn Autoroller 113f2ec82d Roll ANGLE from 2ca14a9f61b8 to 90ddd7c7602d (1 revision)
2ca14a9f61..90ddd7c760

2023-02-10 romanl@google.com Tests: Add Mini Block Craft trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: Id79139af8145a5a28ede27df733e356466610414
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119582
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-11 14:10:51 +00:00
Li Hao 9ee3c7afcc Fix timestamp period for timestamp-query-inside-passes on Metal
Still a missing condition to enable timestamp period calculation at
device initialization on Metal.

Refactor GPUTimestampCalibrationTests.cpp to check timestamp query
correctness on both D3D12 and Metal backends.

Bug: dawn:1193
Change-Id: I69feeaea0df309e15c008647d76b11899dcdc727
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119320
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2023-02-11 09:30:38 +00:00
Jiawei Shao f5cee3fadf Enable the optional feature bgra8unorm-storage on Metal
This patch adds the support of the optional feature "bgra8unorm-storage"
and enable it on  Metal.

Bug: dawn:1641
Test: dawn_end2end_tests
Change-Id: Id58cefd8735f46b8d1807376ebcfada10df2890e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/111380
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-02-11 02:53:53 +00:00
dawn-autoroll 36c17a9ff0 Roll vulkan-deps from 00e3edd6b635 to e780219ed8ba (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/00e3edd6b635..e780219ed8ba

Changed dependencies:
* vulkan-validation-layers: 8f15d57b35..6e62e504d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: I3fc96d66f03f6e6487ccb8985f715cfef2652dc3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119540
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-11 02:12:20 +00:00
Dawn Autoroller cd25ed8144 Roll ANGLE from e6e7976c5dec to 2ca14a9f61b8 (4 revisions)
e6e7976c5d..2ca14a9f61

2023-02-10 geofflang@chromium.org EGL: No-op dma_buf import modifiers on some Mali devices.
2023-02-10 romanl@google.com Tests: Add Durak Online trace
2023-02-10 syoussefi@chromium.org Vulkan: Linked pipelines always need the layout
2023-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 40badb6018c5 to 00e3edd6b635 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: I32d49c6e84d13db7ef2090b90340491931a64e9e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119520
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-11 00:13:18 +00:00
Austin Eng 2c8bea1f9e Add a toggle to keep Metal depth stencil textures initialized
To avoid uninitialized reads of depth stencil data, where the Metal
driver incorrectly binds/loads the wrong depth stencil subresource,
always keep all depth stencil subresources initialized. This means
that textures are initialized on creation, and StoreOp::Discard is
never used - Store is used instead.

Texture initialized state is still set as-if the Discard occured, so
Dawn will try to zero-initialize the subresource if it is read from.
In many cases, this will work correctly, and the application will
read back 0, as expected. In some cases, Metal will bind the wrong
subresource, and the previous contents will be read. This is wrong,
but at least it is not uninitialized data.

Bug: dawn:838
Change-Id: I3cc87073d52de60283e3b683bbee7809db803018
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119344
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-02-11 00:00:12 +00:00
Loko Kung 0bf516b14b Remove clearColor, clearDepth, and clearStencil from dawn.json.
Change-Id: Id529dcbaee0dceeca4e95e293936fe4741247099
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118024
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2023-02-10 23:07:41 +00:00
Ben Clayton 1131d31761 tint/ast: Remove ast::StorageTexture
Instead use ast::TypeName.

Also improve the validation and diagnostics around providing template
arguments to types that do not accept them.

Bug: tint:1810
Change-Id: I4241d50ce0425ab721157686889e918993482876
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119284
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2023-02-10 19:24:24 +00:00
Ben Clayton c66b5e6922 tint/resolver: Fix null dereference
When performing binary / unary ops with non-value expressions.

Bug: chromium:1414658
Change-Id: I7b92f63890da1d9e20e7a1f692fe1fcd28a6f79d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119481
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2023-02-10 15:54:54 +00:00
Corentin Wallez e268e5b854 BackendVk: Remove VVL suppressions for a fixed VVL issue.
Fixed: dawn:1627
Change-Id: I7949c0604b1aa5f96f22c9191413485f6226e270
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119480
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2023-02-10 15:54:04 +00:00
Antonio Maiorano ec20758675 tint: polyfill remainder to handle negative operands
Bug: tint:1802
Change-Id: Ie9baa045feda08523e5ca4f5ce94b6db7d4477e5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119100
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2023-02-10 15:01:02 +00:00
Peng Huang 78583a14e6 Support cross build dawn for Windows on Linux
Change-Id: I50474bacee3c0c7ebea8ffc05f457de550570382
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119380
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
2023-02-10 13:53:31 +00:00
dawn-autoroll f600d36f7c Roll vulkan-deps from d80722393c31 to 00e3edd6b635 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/d80722393c31..00e3edd6b635

Changed dependencies:
* vulkan-validation-layers: 3321eb4487..8f15d57b35

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: I438fd4a5bf4a883d68544bf515e6fb53c504ac04
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119420
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-10 12:57:42 +00:00
Dawn Autoroller e899a0df98 Roll ANGLE from b2cfe726d458 to e6e7976c5dec (5 revisions)
b2cfe726d4..e6e7976c5d

2023-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 111e2c20b468 to 5221896b4233 (520 revisions)
2023-02-09 syoussefi@chromium.org Vulkan: Unsupress fixed VUs
2023-02-09 i.nazarov@samsung.com Vulkan: Fix mutable render buffer with protected content.
2023-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 22b1fa2b9cc1 to 111e2c20b468 (1179 revisions)
2023-02-09 i.nazarov@samsung.com Vulkan: Fix CommandQueue Wait Semaphores asyncCommandQueue race.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: Ie1da744c013c497e90e7fa80ddebd1db1de87d59
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119400
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-02-10 10:47:21 +00:00
Ben Clayton a5fec206c9 tint/ast: Remove ast::DepthTexture and ast::DepthMultisampledTexture
Instead use ast::TypeName.

Bug: tint:1810
Change-Id: Id9fe641d193967cb27cea97e9c25b75c5fe2f1a2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119122
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2023-02-10 02:34:21 +00:00
Zhaoming Jiang 63b777b552 Dawn: Refactor device toggles
This CL refactor the logic adapter creating device toggles set when
creating device and the way device holding its toggles. This CL also
introduce the concept "toggle stage", currently "device stage" only but
in future will add "instance stage" and "adapter stage" for instance and
adapter toggles. No changes on Dawn API.
More details:
1. Introduce `TogglesState` objects that represent the complete toggles
   state of a device (and will used for instance and adapter in future).
2. When creating a device, adapter set up a TogglesState object for it
   in `AdapterBase::CreateDeviceInternal` and
   `Adapter::SetupBackendDeviceToggles`, no other place would change
   the device's toggles state. This change simplify the logic.
3. Introduce the `ToggleStage` enum for every toggle and `TogglesState`
   object. Currently we only have `Device` toggle stage, but in future
   will have `Instance` and `Adapter` for instance and adapter toggles.

Bug: dawn:1495
Change-Id: Ifafac6a6a075b5b9a733159574ae5b6d4f3ebde9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118030
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
2023-02-10 01:43:55 +00:00
Ben Clayton 4906b03963 tint/ast: Remove ast::ExternalTexture
Instead use ast::TypeName.

Bug: tint:1810
Change-Id: Ia1ae61b2bffd386f8958c8164e2223df5f8ac91c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119121
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2023-02-09 23:59:07 +00:00
Ben Clayton ed3389faee tint/ast: Remove ast::Sampler
Instead use ast::TypeName.

Bug: tint:1810
Change-Id: Ia2641d661cab70d110c975d5f0d0e76628816cb0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119120
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Kokoro: Ben Clayton <bclayton@chromium.org>
2023-02-09 23:56:42 +00:00
dawn-autoroll c9aa57d039 Roll vulkan-deps from 40badb6018c5 to d80722393c31 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/40badb6018c5..d80722393c31

Changed dependencies:
* vulkan-validation-layers: be666f39c4..3321eb4487

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: I9390d7b0805e59d07daf8319a55c8ee5df8b1d7c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119302
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-02-09 23:42:12 +00:00
Ben Clayton 6e0a51521f tint/ast: Remove scalar types from ast::*
Instead use ast::TypeName for all of these.

Bug: tint:1810
Change-Id: Ie51a69bf40648a9da73c0a1de2cd96a93d4eac76
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117892
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2023-02-09 23:33:24 +00:00
Ben Clayton eb30a0ddee tint/resolver: Fix validation of type constructor without assignment
Tint used to validate that type initializers and conversions were not
used as statements. The WGSL specification has been recently updated to
allow this, but Tint requires more work to correctly handle these as
statements.

For now, restore the validation.

Bug: tint:1836
Bug: chromium:1414489
Change-Id: I9f6aabece26c30b0a0d789ae0dfa10d6f43ee4dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119360
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2023-02-09 23:19:42 +00:00
Bruce Dawson 0755fdbc8f Use $windows_sdk_version instead of constant
Dawn was using a hard-coded constant for the Windows SDK version number
but that makes upgrading the Windows SDK to build Chromium impossible.
This change uses the newly created $windows_sdk_version to solve this
problem.

This new variable was added in crrev.com/c/4234366

Bug: tint:1719
Change-Id: I6a9f74f542d3517c046d74178a41e1e4d5887e7f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119340
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2023-02-09 22:44:31 +00:00
Kai Ninomiya 1ace49c886 Rolling 7 dependencies
Roll build/ 6dc6eb47f..8cbb95464 (92 commits)

6dc6eb47fb..8cbb95464b

$ git log 6dc6eb47f..8cbb95464 --date=short --no-merges --format='%ad %ae %s'
2023-02-09 brucedawson Remove UCRT references
2023-02-09 brucedawson Remove old large_pdb code
2023-02-09 twellington Revert "Android: Update play core library"
2023-02-09 brucedawson Expose the current Windows SDK value
2023-02-09 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230209.1.1 to 11.20230209.2.1
2023-02-09 wnwen Android: Update play core library
2023-02-09 adetaylor [rust] Windows build fixes
2023-02-09 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230208.3.1 to 11.20230209.1.1
2023-02-09 sushraja Fix build/vs_toolchain.py when using SDK installed through VS2022
2023-02-09 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230208.2.1 to 11.20230208.3.1
2023-02-08 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230208.1.1 to 11.20230208.2.1
2023-02-08 chonggu [Fuchsia] Reenable circuit-switched overnet for ffx
2023-02-08 chonggu [Fuchsia] Remove unnecessaary code-coverage flag
2023-02-08 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230207.2.1 to 11.20230208.1.1
2023-02-08 adetaylor [rust] Re-enable custom toolchains
2023-02-08 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230207.1.1 to 11.20230207.2.1
2023-02-07 miguelfrde [fuchsia] Update ffx log --no-symbols to use --raw
2023-02-07 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230207.0.1 to 11.20230207.1.1
2023-02-07 danakj Pass ldflags to the Rust linker on Windows
2023-02-07 wnwen Android: Use //third_party/kotlin_stdlib
2023-02-07 sokcevic [codesearch] Fix java xref extraction
2023-02-07 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230202.3.1 to 11.20230207.0.1
2023-02-07 brucedawson Enable large pdbs by default
2023-02-06 zijiehe [Fuchsia] Include both arm64 and x64 toolchains in fuchsia_sizes
2023-02-06 hypan Remove emma_coverage_stats.py and emma_coverage_stats_tests.py
2023-02-06 agrieve Android: Do not enforce that all merged manifests have unique packages
2023-02-06 hypan Archive the logcat log for apk installation on android.
2023-02-06 hypan Add option "--emulator-debug-tags" to android test runners.
2023-02-06 huangs [Build] Update version.txt gen for high-end 64/32 ARM builds.
2023-02-06 danakj Support `gn analyze` in Rust crates which only specify the crate_root
2023-02-04 hypan Make sure system user is used for android gtest & instrumentation tests.
2023-02-04 brucedawson Update parse_and_expand_globlist for Windows
2023-02-03 grt [fuchsia] Remove context_provider.cmx
2023-02-03 hans Revert "Generate rudimentary Rust mojom bindings"
2023-02-03 hans [build] Suppress -Wdeprecated-this-capture warnings
2023-02-03 agrieve Android: Add versionCode to manifest expectation files
2023-02-03 collinbaker Generate rudimentary Rust mojom bindings
2023-02-03 vollick [ios] Generalize update_ios_bundle_data.py and add PRESUBMIT checks
2023-02-02 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230202.2.1 to 11.20230202.3.1
2023-02-02 agrieve Android: Fix androidx autoroller by adding requires_android=true
2023-02-02 agrieve Android: Rename lib.java intermediates for prebuilts
2023-02-02 benmason Add automotive version code
2023-02-02 sergeyu [Fuchsia] Implement FlatlandSurfaceCanvas
2023-02-02 agrieve Reland "Android: Set use appropriate android.jar for androidx_privacysandbox_ads_ads_adservices_java"
2023-02-02 jruthe [c++][fuchsia] Enable -gsimple-template-names for Fuchsia debug builds
2023-02-02 hypan Support logging emulator logs with pylib.base.output_manager.
2023-02-02 gbeaty Revert "Android: Set use appropriate android.jar for androidx_privacysandbox_ads_ads_adservices_java"
2023-02-02 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230202.0.1 to 11.20230202.2.1
2023-02-02 titouan Revert "Use PGO instead of AFDO for Lacros."
2023-02-02 agrieve Android: Stop merging chrome and base modules in expectation files
2023-02-02 agrieve Android: Set use appropriate android.jar for androidx_privacysandbox_ads_ads_adservices_java
2023-02-02 hidehiko Use PGO instead of AFDO for Lacros.
2023-02-02 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230201.2.1 to 11.20230202.0.1
2023-02-01 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230201.0.1 to 11.20230201.2.1
2023-02-01 smaier JNI: make JNI Multiplexing work (behind flag)
2023-02-01 dtapuska Add support for use_blink gn variable to conditionally compile blink.
2023-02-01 wnwen Android: Add kotlinc args
2023-02-01 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230131.2.1 to 11.20230201.0.1
2023-02-01 agrieve Android: Allow mergeable_android_manifests on apk and module targets
2023-02-01 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230131.1.1 to 11.20230131.2.1
2023-02-01 collinbaker Add Rust libstd GN bindings generated by gnrt
2023-01-31 wnwen Android: Support Kotlin files in size info files
2023-01-31 danakj Tie the rustc binary version into all rustc invocations
2023-01-31 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230131.0.1 to 11.20230131.1.1
2023-01-31 zhaoyangli Enable sending variant to result sink from test runners
2023-01-31 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230130.3.1 to 11.20230131.0.1
2023-01-31 justincohen Reland "Disable outlining with no-outline."
2023-01-31 richardwa Remote action wrapper should only import mojom code when necessary
2023-01-31 linxinan Initialize "configs" if use_large_pdb arg is true
2023-01-31 linxinan Enable large pdb for chrome_dll on arm64
2023-01-30 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230129.3.1 to 11.20230130.3.1
2023-01-30 adetaylor [rust] Add chrome://crash/rust
2023-01-30 danakj Remove rustc_can_link
2023-01-30 ddorwin [fuchsia] Remove unused TEST_REALM_NAME from test_runner
2023-01-30 ayzhao Do not define _LIBCPP_AVAILABILITY_CUSTOM_VERBOSE_ABORT_PROVIDED
2023-01-30 wnwen Android: Auto detect version in generate_gradle.py
2023-01-30 pkasting Switch Fuchsia to C++20 by default.
2023-01-30 johnidel Allow building against Tiramisu Preview SDK
2023-01-30 pkasting Switch CrOS device builds to C++20.
2023-01-30 luci-bisection Revert "Disable outlining with no-outline."
2023-01-30 justincohen Disable outlining with no-outline.
2023-01-30 haoyu.zhang [CrOS] Enable profile inference (Profi) for ChromeOS
2023-01-30 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230129.2.1 to 11.20230129.3.1
2023-01-29 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230129.1.1 to 11.20230129.2.1
2023-01-29 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230128.2.1 to 11.20230129.1.1
2023-01-29 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230128.1.1 to 11.20230128.2.1
2023-01-28 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230128.0.1 to 11.20230128.1.1
2023-01-28 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230127.3.1 to 11.20230128.0.1
2023-01-28 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230127.2.1 to 11.20230127.3.1
2023-01-27 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230127.1.1 to 11.20230127.2.1
2023-01-27 wnwen Android: Explicitly set JAVA_HOME for kotlinc
2023-01-27 smaier Reland "JNI: Give each DFM its own registration file"

Roll buildtools/ 3c7e3f1b8..70e9f44cb (11 commits)

3c7e3f1b8b..70e9f44cbc

$ git log 3c7e3f1b8..70e9f44cb --date=short --no-merges --format='%ad %ae %s'
2023-02-09 chromium-autoroll Roll libc++ from 6569774a3313 to 035440c70772 (1 revision)
2023-02-08 chromium-autoroll Roll libc++ from 31cf778cc264 to 6569774a3313 (11 revisions)
2023-02-07 chromium-autoroll Roll libc++ from 549781a48cef to 31cf778cc264 (2 revisions)
2023-02-06 chromium-autoroll Roll libc++ from c8da880757e3 to 549781a48cef (2 revisions)
2023-02-04 chromium-autoroll Roll libc++ from 7a7a3a7a4cea to c8da880757e3 (4 revisions)
2023-02-03 chromium-autoroll Roll libc++ from bd44075f8521 to 7a7a3a7a4cea (2 revisions)
2023-02-02 chromium-autoroll Roll libc++ from 59bae40d835a to bd44075f8521 (9 revisions)
2023-01-31 chromium-autoroll Roll libc++ from b93c72898263 to 59bae40d835a (9 revisions)
2023-01-30 chromium-autoroll Roll libc++ from 1bdd3e2d8088 to b93c72898263 (2 revisions)
2023-01-30 ayzhao Do not define _LIBCPP_AVAILABILITY_CUSTOM_VERBOSE_ABORT_PROVIDED
2023-01-30 hans Roll libc++ 1127c78cf..1bdd3e2d8 and libcxxabi d520d582aa71..b74d7716111d

Roll buildtools/third_party/libc++/trunk/ bfaf65c48..035440c70 (47 commits)

bfaf65c48f..035440c707

$ git log bfaf65c48..035440c70 --date=short --no-merges --format='%ad %ae %s'
2023-02-06 ldionne.2 [libc++] Implement LWG3657 std::hash<filesystem::path>
2023-02-06 ldionne.2 [libc++] Implement P1328R1 constexpr std::type_info::operator==
2023-02-07 ldionne.2 [libc++][NFC] Use _LIBCPP_HIDE_FROM_ABI everywhere in pair
2023-02-07 ldionne.2 [libc++] Remove #error about _LIBCPP_DEBUG
2023-02-06 ldionne.2 [libc++] Use __builtin_FILE and __builtin_LINE in _LIBCPP_ASSERT
2023-02-07 ldionne.2 [libc++][NFC] Reformat __assert with clang-format
2023-02-06 koraq [libc++][format] Fixes constexpr validation.
2023-02-06 ldionne.2 [libc++][NFC] _VSTD -> std in ryu
2023-02-06 ldionne.2 [libc++] Add missing _LIBCPP_HIDE_FROM_ABI
2023-02-06 ldionne.2 [libc++] Fix path to versioned clang-format in the CI job
2023-02-06 ldionne.2 [libc++] Export CXX and CC env vars in format and documentation CI jobs
2023-02-06 ldionne.2 [libc++][NFC] Remove FP from_chars from the <charconv> synopsis since we don't implement it yet
2023-02-06 v.g.vassilev Don't re-export top-level modules
2023-01-31 koraq [libc++][CI] Uses LLVM 17 in Docker.
2023-02-02 nikolasklauser [libc++][NFC] Rename _LIBCPP_EXPLICIT_AFTER_CXX11 to _LIBCPP_EXPLICIT_SINCE_CXX14
2023-02-02 nikolasklauser [libc++][NFC] Rename _LIBCPP_NO_RTTI to _LIBCPP_HAS_NO_RTTI
2023-02-03 ldionne.2 [libc++] Remove leftover LIBCXX_ENABLE_CLANG_TIDY in run-buildbot
2023-02-02 ldionne.2 [libc++] Add a CI configuration to test Modules with LSV enabled
2023-02-02 varconst [libc++][format] Fix a missing include in tests.
2023-02-02 varconsteq [libc++] Make some tests in `math_nodiscard_extensions` Clang-only.
2023-01-25 tom [libc++] Remove use of internal glibc macros to determine if c8rtomb() and mbrtoc8() are present.
2023-02-01 nikolasklauser [libc++] Avoid ODR violations in __exception_guard
2023-01-31 nikolasklauser [libc++] Look for Clang 17 when compiling clang-tidy checks
2023-01-20 nikolasklauser [libc++] Forward ranges::sort to instantiations in the dylib
2023-01-20 nikolasklauser [libc++] Split ranges.transform.binary.pass.cpp up
2023-01-20 nikolasklauser [libc++] Remove explicit instantiations of __insertion_sort_incomplete and __sort5 from the dylib
2023-01-10 nikolasklauser [libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names
2023-02-01 nikolasklauser Revert "[libc++] Fix ODR violation with __exception_guard in mixed exceptions builds"
2023-02-01 alexfh [libc++] Fix ODR violation with __exception_guard in mixed exceptions builds
2023-01-31 varconst [libc++][ranges] Fix incorrect integer typedef in `elements_view` test.
2023-01-30 ldionne.2 [libc++] Use bounded iterators in std::string_view when the debug mode is enabled
2023-01-30 koraq [NFC][libc++] Addresses LWG3781.
2023-01-30 koraq [libc++] Addresses LWG3755.
2023-01-29 koraq [libc++] Marks LWG2970 as complete.
2023-01-21 koraq [libc++] Partly addresses LWG3798.
2023-01-21 koraq [libc++] Addresses LWG3764.
2023-01-29 koraq [NFC][libc++][format] Uses retarget buffer.
2023-01-27 koraq [libc++] Fixes the Clang modular build.
2021-09-23 yedeng.yd [libc++] Remove <experimental/coroutine>
2023-01-26 ldionne.2 [libc++] Add missing include promote.h in <cmath>
2023-01-11 nikolasklauser [libc++] Add [[clang::lifetimebound]] to min/max algorithms
2022-11-28 ldionne.2 [libc++] Don't assume that string_view::const_iterator is a raw pointer
2023-01-30 hans Revert "[ASan][libcxx] Annotating std::vector with all allocators"
2023-01-30 varconsteq [libc++][ranges] Temporarily mark `ranges::join_view` as experimental.
2023-01-30 varconst [libc++] Fix some missed `return 0` statements in test `main` functions.
2023-01-21 koraq [libc++] Addresses LWG3754
2023-01-27 koraq [libc++] Disables a test in clang-17.

Roll testing/ a9787cefa..d5ea1bf4b (155 commits)

a9787cefae..d5ea1bf4b6

$ git log a9787cefa..d5ea1bf4b --date=short --no-merges --format='%ad %ae %s'
2023-02-09 jonross Remove PercentDroppedFrames v1
2023-02-09 hypan Green device_unittests, gl_tests_validating on android 12l, 13
2023-02-09 kylechar Filter RGBA_F16 test in pie emulator
2023-02-09 kainino Revert "Enable WebGPU CTS on mac-code-coverage"
2023-02-09 gujen [LR] More Lightweight Reactions cleanup
2023-02-09 noahrose Add updater bots for Linux
2023-02-09 mastiz Add fieldtrial testing config for ScopedCriticalActionReuseEnabled
2023-02-09 wfh Extend timeout for zlib_unittests to 400s
2023-02-09 hypan Fix the trichrome tests on x64 without skip_secondary_abi_for_cq
2023-02-09 shuyng [RDSG] Update fieldtrial_testing_config
2023-02-08 hypan Green perfetto_unittests, crashpad_tests, base_unittests on android 12l,13
2023-02-08 koulvipul Code cleanup for the Save Card UI experiment.
2023-02-08 hypan Add filter for media_unittests on android 12l and 13 builders.
2023-02-08 ckitagawa [TabSelectionEditorV2] Enable bookmarks in fieldtrial config
2023-02-08 ftirelo [Managed prefs] Add highlight disclaimer expt to test config
2023-02-08 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-02-08 katie Disable more Select to Speak tests flaking in Lacros browsertests
2023-02-08 chonggu [Fuchsia] Remove unnecessaary code-coverage flag
2023-02-08 bpastene Move most/all fuchsia arm64 tests to the temporary LIFO swarming pool
2023-02-08 agrieve Delete chrome_modern_public_bundle target
2023-02-08 alessiob Fieldtrial testing config for `WebRTC-Audio-GainController2`
2023-02-08 eladalon Launch NewGetDisplayMediaPickerOrder
2023-02-08 zalmashni AboutThisSite: Add field trial for ImprovedBottomSheet experiment
2023-02-08 bozydar [reclient] Remove Linux CFI (reclient shadow)
2023-02-08 mlbipin Add school account to chromium field trial testing config
2023-02-08 kainino Enable WebGPU CTS on win10-code-coverage
2023-02-08 kainino Enable WebGPU CTS on mac-code-coverage
2023-02-08 agrieve Remove references to now removed internal target "chrome_modern_bundle"
2023-02-08 brucedawson Fix \ != / presubmit failures on Windows
2023-02-08 jeffyoon Remove iOS tests from skipped GN targets in manage.py
2023-02-08 jiesheng Fix mac wpt runner result json
2023-02-08 jakubm hiberman: Add CrOSLateBootSuspendToHibernate
2023-02-08 nickdiego ozone: return null in CreateKeyboardHook default impl
2023-02-08 tinazwang [P13n] Add field trial to IOSFeedBottomSyncPromo exp
2023-02-08 jiesheng Add ios build dependency to WPT ios bot.
2023-02-07 shuyng [RDSD] Launch subdomain settings on ToT
2023-02-07 yueshe target T2 machines for tests running on SIM_IPAD_PRO_3RD_GEN_16_2 on ios-simulator-noncq
2023-02-07 kuanhuang Move win-asan to use default win10 mixin and add more shards.
2023-02-07 mfoltz [Media Router] Fix target for end-to-end tests.
2023-02-07 wangxianzhu Add ScrollOverlapOptimization flag to WebView
2023-02-07 chonggu [Fuchsia] Remove cfv2 fyi builders
2023-02-07 andysjlim Create fieldtrial for client side phishing desktop model 30.0
2023-02-07 wenyufu [EngagementSignals][CCTBrand] Enable features by default
2023-02-07 edchin [ios] Add fieldtrial config for Feed Image Caching
2023-02-07 djmitche Remove support for triple-keyed NAKs.
2023-02-07 victorvianna Add fieldtrial testing config for IOSShowPasswordStorageInSaveInfobar
2023-02-07 tsergeant Link Capturing: Remove field trial config
2023-02-07 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-02-07 chonggu [Fuchsia] Migrate coverage bot to v2 scripts
2023-02-07 alvinjia increase timeout for chromeos-eve-chrome
(...)
2023-02-01 ckitagawa Delete DiscardOccludedBitmaps Flag
2023-02-01 fleimgruber Enable AutofillComplementCountryEarly by default.
2023-02-01 vasilii Change std::size_t to size_t in fuzzer_support.mm.
2023-02-01 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-02-01 eduardoyap Increase shards of lacros-x86-perf from 6 to 10.
2023-01-31 sky field-trial: updates params for ProcessHtmlDataImmediately
2023-01-31 travislane Add DriveFsChromeNetworking to fieldtrial config
2023-01-31 danakj Exclude gn analyze when rolling the Rust toolchain
2023-01-31 svenzheng Disable some browser tests on lacros asan
2023-01-31 srinivashegde Check if sourcemaps are valid
2023-01-31 rkgibson Fix fieldtrial entry for IOSNewOverflowMenuIPH study
2023-01-31 joemerramos [iOS] Changing fieldtrial study name
2023-01-31 benreich [js-code-coverage] Remove unnecessary steps and use correct lcov command
2023-01-31 josiahk language_packs: Add fieldtrial testing config for LanguagePacksTts
2023-01-31 thegreenfrog [ios] Remove ContentSuggestionsUIModuleRefresh enabled from tests
2023-01-31 ynovikov Enable Metal debug layers on ANGLE bots
2023-01-31 jam Update name of preconnect experiment in field trial testing config.
2023-01-31 curranmax Add fieldtrial_testing_config entry for DesktopPrefetchUseContentRefactor.
2023-01-31 sunxiaodi Create high end Android builder config and map shards for Pixel6
2023-01-31 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-31 jyammine [fyfre]Add pixel tests to profile picker main view
2023-01-31 robertlin Prerender: Update field trial config for OmniboxPrerender
2023-01-31 yawano Update config of GalleryAppPdfEditNotification
2023-01-30 manukh [omnibox][doc] Add fieldtrial_testing_config entry for MaxLowQuality.
2023-01-30 freedjm Add fieldtrial_testing_config entry for DiscoFeedEndpoint.
2023-01-30 danakj Remove rustc_can_link
2023-01-30 jam Fix slowdown in simple-url.html and url-parser.html perf tests.
2023-01-30 dgn [fyfre] Clean up synthetic study setup in welcome code
2023-01-30 yaoxia [Topics] Enable BrowsingTopicsXHR in fieldtrial_testing_config.json
2023-01-30 mmenke Migrate all Value::Append() calls in /testing/perf
2023-01-30 dizhangg Add UMA experiment config for feature KeyboardFocusableScrollers
2023-01-30 elkurin TooltipLacros: Remove tooltip tests from exceptions for Lacros
2023-01-30 thomasanderson Reland "Reland "Upgrade WebKit Linux MSAN to Focal""
2023-01-30 rmhasan Finch: Run commands for disabling or enabling airplane mode on devices in the Android test suite
2023-01-30 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-30 hiroh fieldtrial_testing_config.json: Add WebRtcEncoderAsyncEncode
2023-01-30 arabm Enable Incognito Download Warning in TOT
2023-01-29 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-28 rockot cc: Experimental age-based decode cache limits
2023-01-28 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-28 avi Remove base::Value::Type::DICTIONARY
2023-01-28 rockot cc: Experimental size cap for image decode cache
2023-01-27 peilinwang [Cleaup] Remove IsVoiceSearchEnabledCache experiment code
2023-01-27 bryantchandler Reland "[fuchsia] Cut out runtime data bloat from Chrome tests."
2023-01-27 nihardamar add mac13 x86 + arm bot
2023-01-27 kyleshima Add ChromeOS Finch smoke test builder configs
2023-01-27 olivierli Add ios to fieldtrial config for UseSimplifiedMessagePumpKqueueLoop
2023-01-27 stkhapugin Add Omnibox Most Visited Tiles On Srp flag on iOS
2023-01-27 rostedt Field trial testing config for SchedUtilHints
2023-01-27 sprang Add testing config for WebRTC-SendBufferSizeBytes

Roll third_party/catapult/ 35952dc54..37e879a7d (52 commits)

https://chromium.googlesource.com/catapult.git/+log/35952dc547f2..37e879a7d13c

$ git log 35952dc54..37e879a7d --date=short --no-merges --format='%ad %ae %s'
2023-02-08 paulirish Traceviewer: keep process header sticky-visible
2023-01-31 renewitt Fixing filename for Oboe license file in README.chromium.
2023-02-07 agrieve Make "android-chromium-bundle" point to monochrome rather than chrome_modern
2023-02-06 hypan Fix the unhashable error in provision_devices
2023-02-07 bsheedy Add stack summaries
2023-02-07 sunxiaodi [chromeperf] Move Pinpoint version forward
2023-02-01 cbruni [chrome_inspector] Increase CollectChromeTracingData timeout
2023-02-06 nikolaos [chromeperf] Replace lorempixel with loremflickr
2023-02-06 hypan Add the arg emulator_debug_tags to browser_options
2023-02-06 hypan Implement GetCurrentUser for Android versions < Nougat.
2023-02-03 sunxiaodi [Chrome Health] average Speedometer2 metrics with multiple values
2023-02-04 funing [Pinpoint UI] Allow user to use chromium commit position to choose base/exp build
2023-02-03 bsheedy Revert "Change non-root profile dir"
2023-02-02 hypan Devil: Add two user-related methods to device_utils.
2023-02-03 hypan Support the Issuetracker bug format "b:NNNN" in the commit message.
2023-02-03 rmhasan Devil: Refactor the GetApplicationVersion method
2023-02-03 sunxiaodi [chromeperf] Move versions forward
2023-02-03 cbruni [chrome_inspetor] Add more details to TracingTimeoutException
2023-02-03 sunxiaodi [Pinpoint] Ensure batch ID is always empty when restarting job
2023-02-02 sunxiaodi Mapping Pixel 6 isolates to Pinpoint UI
2023-02-02 johnchen Add expectations tags for Pixel 6 and 6 Pro
2023-02-02 wenbinzhang [chromeperf] misc clean up
2023-02-01 bsheedy Change non-root profile dir
2023-02-01 cbruni [chrome-inspector] Add more details TracingTimeoutException
2023-02-02 funing Update TokenRequiredFlask
2023-02-01 funing Replace six.assertCountEqual with self.assertCountEqual
2023-02-02 funing Update some of the flask suffixed functions
2023-02-01 sunxiaodi Add Android high end builder to pinpoint isolate map for Pixel6
2023-02-01 funing Removing isRunningFlask
2023-02-01 rmhasan Devil: Add method to get the webview provider to DeviceUtils
2023-02-01 funing More removal of six.py
2023-02-01 eduardoyap Add unit tests for email_template.
2023-01-31 wenbinzhang [chromeperf] fix cloud build failure
2023-01-31 funing Remove sys.version_info related py2 code
2023-02-01 ashwinpv Fix UT that's failing in cloud build
2023-01-31 rohpavone Revert "[remote-linux] changes"
2023-01-31 ashwinpv [chromeperf]: Post ADC service account migration cleanup
2023-01-31 eduardoyap Ensure group report link is a properly formatted string.
2023-01-31 ashwinpv Update prod versions for default,pinpoint and api services
2023-01-31 ashwinpv Revert "Set adc=False for issue_tracker clients"
2023-01-31 funing Remove deploy(py2) and rename deploy-py3
2023-01-30 wenbinzhang [chromeperf] fix job tests under pinpoint
2023-01-30 funing Remove some skipped tests, also mark crbug for some to be updated
2023-01-30 ashwinpv Set adc=False for issue_tracker clients
2023-01-30 funing Remove py2 build conf
2023-01-27 pasko flag_changer: Fix documentation to mention existing method
2023-01-28 funing Remove six.py2 in dashboard
2023-01-26 funing [Pinpoint UI] More instructions on extra args, especially for --enalbe-features
2023-01-27 bpastene devil: Drop presubmit coverage of py2 unittests
2023-01-27 wenbinzhang [chromeperf] More pylint cleanup under catapult
2023-01-27 sunxiaodi fix testPost_LongSupplementalAnnotation
2023-01-26 wenbinzhang [chromeperf] remove usages of flask_flag

Roll third_party/googletest/ b72202078..b73f27fd1 (16 commits)

b72202078d..b73f27fd16

$ git log b72202078..b73f27fd1 --date=short --no-merges --format='%ad %ae %s'
2023-02-08 tomhughes Fix _MSC_VER check
2023-02-07 tomhughes Remove GTEST_USES_PCRE references
2023-02-07 mvels Fix GTEST_HAS_ABSL define check for [-Werror=undef] compilations
2023-02-06 absl-team Add support for the alternative base64 encoding in RFC 4648 section 5 to `WhenBase64Unescaped`.
2023-02-02 tomhughes Fix compiler flags in Linux presubmit
2023-02-02 tomhughes Fix -Wsign-conversion warnings
2023-02-02 tomhughes Remove unneccessary "#if _MSC_VER"
2023-02-02 absl-team Add a trailing decimal point to FormatTimeInMillisAsSeconds() output when input is an exact N seconds.
2023-02-01 tomhughes Fix include order
2023-02-01 tomhughes Remove GMOCK_RENAME_MAIN
2023-02-01 tomhughes Build gmock Python tests when building with cmake
2023-02-01 tomhughes Fix gmock_output_test when using MSVC
2023-01-31 tomhughes Fix sign conversion warning from clang:
2023-01-30 tomhughes Use GTEST_DISABLE_MSC_WARNINGS macros to disable warnings
2023-01-30 tomhughes Use explicit short to fix MSVC compiler warning
2023-01-04 SunBlack Fix typos found by codespell

Roll tools/clang/ c272f2cdc..fff7f04d3 (7 commits)

c272f2cdc1..fff7f04d30

$ git log c272f2cdc..fff7f04d3 --date=short --no-merges --format='%ad %ae %s'
2023-02-09 danakj Pull OpenSSL pre-built libraries from 3pp for the Rust toolchain
2023-02-09 bartekn Use vpython3 in extract_edits.py
2023-02-08 vollick Use vpython3 in run_tool.py and apply_edits.py
2023-02-07 paulsemel devtools: lookup for record definitions to avoid handling declaration
2023-02-06 danakj Find the stage0 hash from build_rust.py
2023-01-31 hans Clang build.py: Add third_party/ninja/ to PATH on Windows
2023-01-30 hans [Clang] Switch from llvm::Optional to std::optional

Created with:
  roll-dep build buildtools buildtools/third_party/libc++/trunk buildtools/third_party/libc++abi/trunk testing third_party/catapult third_party/googletest tools/clang

Change-Id: Iedcb7e81fc3f370f1aa5593a0deb9a20c5130c40
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119341
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2023-02-09 22:42:49 +00:00
dawn-autoroll d01988ab11 Manual roll vulkan-deps from 500224a602d5 to 40badb6018c5 (19 revisions)
Manual roll requested by ynovikov@google.com

https://chromium.googlesource.com/vulkan-deps.git/+log/500224a602d5..40badb6018c5

Changed dependencies:
* glslang: 4386679bcd..6d41bb9c55
* spirv-tools: c965624e34..5b48c549b0
* vulkan-headers: 93cb25c6a4..e8b8e06d09
* vulkan-validation-layers: 59aa803960..be666f39c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC rharrison@google.com,webgpu-developers@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com,ynovikov@google.com
Change-Id: I622464c4dc7e843d2f00d7ed86e2cc010092b4b6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119301
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-09 21:30:02 +00:00
Dawn Autoroller 1981a8e176 Roll ANGLE from b6cc575478e2 to b2cfe726d458 (16 revisions)
b6cc575478..b2cfe726d4

2023-02-09 cclao@google.com Vulkan: Make queueSubmit without holding CommandQueue::mMutex
2023-02-09 cclao@google.com Vulkan: Move post submit code into a separate function
2023-02-09 dtapuska@chromium.org [ios] Fix build failure on iOS.
2023-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 223515618c53 to 40badb6018c5 (22 revisions)
2023-02-09 lexa.knyazev@gmail.com GL: Expose EXT_texture_border_clamp
2023-02-09 yuxinhu@google.com Revert "Re-land fixing of commit ID for Android builds."
2023-02-08 i.nazarov@samsung.com Vulkan: Changed "asyncCommandQueue" Pending Present info logic.
2023-02-08 i.nazarov@samsung.com Vulkan: Add OneOffCommandPool for unprotected/protected commands
2023-02-08 i.nazarov@samsung.com Vulkan: Refactoring to use ProtectionType enum instead of bool
2023-02-08 cnorthrop@google.com Tests: Add Samsung support in our test harness
2023-02-08 syoussefi@chromium.org Vulkan: Fix fragment shading rate entry point init
2023-02-08 romanl@google.com Tests: Add Add Words Crush: Word Puzzle Game trace
2023-02-08 ynovikov@chromium.org Fix InstancingTestES3.LargeDivisor suppression
2023-02-08 geofflang@chromium.org Metal: Support LibraryCache below c++20.
2023-02-08 lexa.knyazev@gmail.com Add channel info to compressed formats in angle::Format
2023-02-08 lehoangquyen@chromium.org Metal: fix UBO argument buffers didn't work with managed storage.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC angle-team+autoroll@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: rharrison@google.com
Change-Id: Ibe61a3152de0533d4732b7f63f3f09f92bc8905c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119271
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2023-02-09 21:12:04 +00:00
Ryan Harrison 3884471c8a Increase CTS checkout timeout when rolling CTS
The default behaviour is a 1 minute timeout, which depending on
network load and other factors, may not be enough time to clone the
CTS repo when running the tool.

Increasing the timeout for this step to 10 minutes, since the tool is
expected to take a significant amount of time to run, so a bit of
extra time on setup isn't noticable.

Change-Id: If51ed154a8b2373bb9b246f29467fb17c7d7e345
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119300
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
2023-02-09 19:43:51 +00:00
Ben Clayton 031e2f5585 tint/resolver: Resolve builtin enumerators
'address space', 'access' and 'texel_format'

Bug: tint:1810
Change-Id: If471912fcef57f7579d76c8c4edd663d1c0311ef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119125
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2023-02-09 15:35:27 +00:00
Ben Clayton 0ddddb00cb tint/resolver: Start handling sem::Expression
Change Resolver::Expression() and Resolver::Identifier() to return a
sem::Expression instead of a sem::ValueExpression.

This is required as IdentifierExpressions may resolve to non-values.

Handle expressions that resolve to types, when they are expected to
resolve to a value.

Bug: tint:1810
Change-Id: I1cb069e3e736fc85af7bc395b388abe153b1f65a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118500
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2023-02-09 15:35:27 +00:00
Ben Clayton 4e4cada291 tint/transform: Simplify Renamer transform
Take advantage of the fact that all AST nodes now use an
`ast::Identifier` instead of directly using Symbols.

This will be important for ensuring that un-keyworded identifiers will
be preserved.

Bug: tint:1810
Change-Id: If5c3e9f00b4c1c14a6f11bd617bd8b895250fb7e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119285
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2023-02-09 15:35:27 +00:00
Ben Clayton f973d514a1 tint: Add ast::CheckIdentifier() test helper
A bunch of template magic to recursively test that an identifier (and
template arguments) matches the given values. Will be heavily used for
AST and parser tests.

Bug: tint:1810
Change-Id: I8d83090352c345f0ce1ac7840e163eea96eac8a2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119124
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2023-02-09 11:59:47 +00:00
Ben Clayton b75252b7aa tint/ast: Change TypeDecl::name to an ast::Identifier.
The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.

Change-Id: I8b3e05d05886c6caa16513a5cfb45d30f7a8d720
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119283
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
2023-02-09 10:34:14 +00:00
Ben Clayton 651d9e2558 tint/ast: Change Variable::symbol to Variable::name
Variable::name is an ast::Identifier.

The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.

Change-Id: I71fe3e8df3d22b12d4a3430c41f236ddf5bc0b9e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119282
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2023-02-09 10:34:14 +00:00
Ben Clayton 199440e37c tint/ast: Change StructMember::symbol to StructMember::name
StructMember::name is an ast::Identifier.

The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.

Change-Id: I1156653a48b02997ec0a9077b174401f65a13457
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119281
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2023-02-09 10:34:14 +00:00
Ben Clayton ce31d187ef tint/ast: Change Function::symbol to Function::name
Function::name is an ast::Identifier.

The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.

Change-Id: I723a9a104668758db2cb32051efa1f6d3c105913
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119280
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2023-02-09 10:34:14 +00:00
Ben Clayton 057a733758 tint: Allow IdentifierExpressions to be templated
Required for nested template arguments, like `array<vec2<i32>, 2>`

Bug: tint:1810
Change-Id: Ibf24ec8918ef7698232cb2ea0cb786144d6f0604
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119123
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
2023-02-08 23:29:28 +00:00