This will ignore tools/cmake-win32.zip and tools/cmake-win32/
Change-Id: I9018aff8acd991b2c9e7d1e9b4100c17096676ce
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86043
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Integrates Tint repo into Dawn
KIs:
- Building docs for Tint is turned off, because it fails due to lack
of annotations in Dawn source files.
- Dawn CQ needs to be updated to run Tint specific tests
- Significant post-merge cleanup needed
R=bclayton,cwallez
BUG=dawn:1339
Change-Id: I6c9714a0030934edd6c51f3cac4684dcd59d1ea3
Contains generic Map and Set types.
Golang 1.18 added new support for generics, but has not yet added a standard library that provides generic containers. In future versions of Golang, there will almost certainly be similar implementations of these types.
Until then, use these to simplify some code.
100% test coverage.
Bug: dawn:1342
Change-Id: I2a5c7bfb26f15c2099037d3fa0f0576df641d9f6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85220
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
- Format specific targets to have the hash in the target rule instead
of a variable.
- Only have the base part of the URL in a variable
- Use vulkan-deps instead of individual DEPS (spirv-tools,
spirv-headers & glslang)
BUG=tint:1481
Change-Id: I871a656e26050698da2c77f4f39fec94a9c4f8a4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/84723
Reviewed-by: David Neto <dneto@google.com>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Adds a script to take a CTS queries, expand them to individual test case
names, and append them to the end of expectations.txt as valid
expectations.
Bug: chromium:1306640
Change-Id: I55067c8c49aeb4360d488841da12c06d88346b8a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/84740
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
These build files are not yet used, but intended to be included by a
build file in Chromium. The test expectations file will move here too,
allowing Dawn/Tint changes to adjust test expectations in the same CL.
Bug: chromium:1306640
Change-Id: Id0be5c155ec7c79252e724cd64e54d1ea9f3dbda
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/83761
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
External dependency added when you `gclient sync`.
Change-Id: I65303a35f8ac33e3864267b742f619eeacb5a454
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/77941
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
This rolls 7 build dependencies: build, buildtools, libc++, libc++abi,
clang, testing and googletest. Roll commit messages are below. It also
adds catapult as a dependency because it is required by //testing.
All hook scripts now run with python3 and GN is made to use python3 as
well since Chromium is now migrated to Python3 and some scripts check
for that.
Also add a new gclient_args.gni variable that Chromium //testing started
to read that isn't defined by default.
Roll build/ 0ff4b3d4e..555c8b467 (1214 commits)
0ff4b3d4ee..555c8b467c
$ git log 0ff4b3d4e..555c8b467 --date=short --no-merges --format='%ad %ae %s'
2022-01-03 chromium-autoroll Roll Fuchsia SDK from 7.20220102.1.1 to 7.20220102.3.1
2022-01-02 chromium-autoroll Roll Fuchsia SDK from 7.20220101.3.1 to 7.20220102.1.1
2022-01-02 chromium-autoroll Roll Fuchsia SDK from 7.20220101.2.1 to 7.20220101.3.1
2022-01-01 chromium-autoroll Roll Fuchsia SDK from 7.20220101.1.1 to 7.20220101.2.1
2022-01-01 chromium-autoroll Roll Fuchsia SDK from 7.20211231.3.1 to 7.20220101.1.1
2022-01-01 chromium-autoroll Roll Fuchsia SDK from 7.20211231.2.1 to 7.20211231.3.1
2021-12-31 chromium-autoroll Roll Fuchsia SDK from 7.20211231.0.1 to 7.20211231.2.1
2021-12-31 chromium-autoroll Roll Fuchsia SDK from 7.20211230.2.3 to 7.20211231.0.1
2021-12-31 chromium-autoroll Roll Fuchsia SDK from 7.20211230.1.1 to 7.20211230.2.3
2021-12-30 chromium-autoroll Roll Fuchsia SDK from 7.20211230.0.1 to 7.20211230.1.1
2021-12-30 chromium-autoroll Roll Fuchsia SDK from 7.20211229.2.3 to 7.20211230.0.1
2021-12-30 chonggu [Fuchsia] Add runtimes needed for ASAN builds
2021-12-30 chonggu [Fuchsia] Remove llvm-symbolizer from Fuchsia builds
2021-12-29 chromium-autoroll Roll Fuchsia SDK from 7.20211229.1.1 to 7.20211229.2.3
2021-12-29 thomasanderson [TSAN] Suppress system fontconfig data races
2021-12-29 chromium-autoroll Roll Fuchsia SDK from 7.20211228.3.1 to 7.20211229.1.1
2021-12-29 chromium-autoroll Roll Fuchsia SDK from 7.20211228.2.3 to 7.20211228.3.1
2021-12-28 chromium-autoroll Roll Fuchsia SDK from 7.20211228.1.1 to 7.20211228.2.3
2021-12-28 chromium-autoroll Roll Fuchsia SDK from 7.20211227.3.1 to 7.20211228.1.1
2021-12-28 chromium-autoroll Roll Fuchsia SDK from 7.20211227.2.1 to 7.20211227.3.1
2021-12-27 chromium-autoroll Roll Fuchsia SDK from 7.20211227.0.1 to 7.20211227.2.1
2021-12-27 chromium-autoroll Roll Fuchsia SDK from 7.20211225.3.1 to 7.20211227.0.1
2021-12-27 chromium-autoroll Roll Fuchsia SDK from 7.20211225.0.1 to 7.20211225.3.1
2021-12-25 chromium-autoroll Roll Fuchsia SDK from 7.20211224.3.1 to 7.20211225.0.1
2021-12-25 chromium-autoroll Roll Fuchsia SDK from 7.20211224.1.1 to 7.20211224.3.1
2021-12-24 chromium-autoroll Roll Fuchsia SDK from 7.20211224.0.1 to 7.20211224.1.1
2021-12-24 chromium-autoroll Roll Fuchsia SDK from 7.20211223.2.2 to 7.20211224.0.1
2021-12-23 chromium-autoroll Roll Fuchsia SDK from 7.20211223.1.1 to 7.20211223.2.2
2021-12-23 chromium-autoroll Roll Fuchsia SDK from 7.20211222.3.1 to 7.20211223.1.1
2021-12-23 chromium-autoroll Roll Fuchsia SDK from 7.20211222.2.1 to 7.20211222.3.1
2021-12-23 adetaylor [rust] Pass environment variables to build scripts.
2021-12-22 adetaylor [rust] Fix non-Linux builds
2021-12-22 chromium-autoroll Roll Fuchsia SDK from 7.20211222.1.1 to 7.20211222.2.1
2021-12-22 chromium-autoroll Roll Fuchsia SDK from 7.20211221.3.1 to 7.20211222.1.1
2021-12-22 chromium-autoroll Roll Fuchsia SDK from 7.20211221.1.1 to 7.20211221.3.1
2021-12-21 ynovikov Disallow command option abbreviations in logdog_wrapper
2021-12-21 chromium-autoroll Roll Fuchsia SDK from 7.20211221.0.1 to 7.20211221.1.1
2021-12-21 brucedawson build: Relanding Rudimentary support for Visual Studio 2022.
2021-12-21 agrieve Android: Disable use_glib in secondary toolchains (attempt #2)
2021-12-21 adetaylor [rust] Add ultra-simple executable.
2021-12-21 wnwen Android: Speed up incremental install sharding
2021-12-21 chromium-autoroll Roll Fuchsia SDK from 7.20211220.2.1 to 7.20211221.0.1
2021-12-20 chromium-autoroll Roll Fuchsia SDK from 7.20211220.1.1 to 7.20211220.2.1
2021-12-20 adetaylor [rust] Work around lld discarding sections
2021-12-20 lukasza [rust] Add `rust_unit_tests_group(...)` gni template.
2021-12-20 lgrey Reland^4: "Mac: enable ThinLTO (without unit splitting)"
2021-12-20 chromium-autoroll Roll Fuchsia SDK from 7.20211219.3.1 to 7.20211220.1.1
2021-12-20 chromium-autoroll Roll Fuchsia SDK from 7.20211219.2.1 to 7.20211219.3.1
2021-12-19 chromium-autoroll Roll Fuchsia SDK from 7.20211219.1.1 to 7.20211219.2.1
2021-12-19 chromium-autoroll Roll Fuchsia SDK from 7.20211218.3.1 to 7.20211219.1.1
(...)
2021-06-29 wnwen Android: Migrate build/android tests to python3
2021-06-29 pkotwicz [Build] Switch list_java_targets.py to use python3 instead of vpython3
2021-06-29 chromium-autoroll Roll Fuchsia SDK from 5.20210628.3.2 to 5.20210629.1.1
2021-06-29 chromium-autoroll Roll Fuchsia SDK from 5.20210628.2.1 to 5.20210628.3.2
2021-06-29 elkurin Remove glib and ATK from Lacros build.
2021-06-28 chromium-autoroll Roll Fuchsia SDK from 5.20210628.1.1 to 5.20210628.2.1
2021-06-28 agrieve Reland #3 "Android: Enable use_debug_fission for official builds""
2021-06-28 bpastene Optionally stream local script tests results to RDB.
2021-06-28 hans [include analysis] Make the analysis script work on Windows
2021-06-28 chromium-autoroll Roll Fuchsia SDK from 5.20210627.3.1 to 5.20210628.1.1
2021-06-28 sdefresne [ios] Improve selection of secondary toolchain for "fat" build
2021-06-28 chromium-autoroll Roll Fuchsia SDK from 5.20210627.2.1 to 5.20210627.3.1
2021-06-27 chromium-autoroll Roll Fuchsia SDK from 5.20210627.1.1 to 5.20210627.2.1
2021-06-27 chromium-autoroll Roll Fuchsia SDK from 5.20210626.3.1 to 5.20210627.1.1
2021-06-27 chromium-autoroll Roll Fuchsia SDK from 5.20210626.2.1 to 5.20210626.3.1
2021-06-26 chromium-autoroll Roll Fuchsia SDK from 5.20210626.1.1 to 5.20210626.2.1
2021-06-26 chromium-autoroll Roll Fuchsia SDK from 5.20210625.3.1 to 5.20210626.1.1
2021-06-26 pkasting Fix warnings for -Wc++11-narrowing.
2021-06-26 chromium-autoroll Roll Fuchsia SDK from 5.20210625.2.1 to 5.20210625.3.1
2021-06-26 brucedawson Reland "Put source and object file names at the front"
2021-06-25 linxinan Add build rule to generate skylab runner script
2021-06-25 robliao Add a Dependency to LASTCHANGE in process_version and Fix an Argument Name
2021-06-25 xiaohuic Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)"
2021-06-25 chromium-autoroll Roll Fuchsia SDK from 5.20210625.1.1 to 5.20210625.2.1
2021-06-25 justincohen Reland "ios: Remove IsSpuriousMessage logic."
2021-06-25 chromium-autoroll Roll Fuchsia SDK from 5.20210624.3.1 to 5.20210625.1.1
2021-06-25 mcrouse Revert "Put source and object file names at the front"
2021-06-25 thomasanderson Statically link libffi on Linux
2021-06-25 brucedawson Put source and object file names at the front
2021-06-25 chromium-autoroll Roll Fuchsia SDK from 5.20210624.2.1 to 5.20210624.3.1
2021-06-25 bsheedy Dryrun Android Gold retries
2021-06-24 bpastene build: Relocate android/pylib's result_sink.py to //build/util.
2021-06-24 fdegans [code-health] Migrate //build/skia_gold_common/PRESUBMIT.py to python3
2021-06-24 fdegans [code-health] Migrate //build/chromeos/PRESUBMIT.py to python3
2021-06-24 fdegans [code-health] Migrate //build/lacros/PRESUBMIT.py to python3
2021-06-24 chromium-autoroll Roll Fuchsia SDK from 5.20210624.1.1 to 5.20210624.2.1
2021-06-24 thomasanderson Revert "ios: Remove IsSpuriousMessage logic."
2021-06-24 justincohen ios: Remove IsSpuriousMessage logic.
2021-06-24 pasko generate_gradle: Allow android_sdk_version to be int
2021-06-24 chromium-autoroll Roll Fuchsia SDK from 5.20210623.4.1 to 5.20210624.1.1
2021-06-24 chromium-autoroll Roll Fuchsia SDK from 5.20210623.2.1 to 5.20210623.4.1
2021-06-23 chromium-autoroll Roll Fuchsia SDK from 5.20210623.0.1 to 5.20210623.2.1
2021-06-23 agrieve Android: Fix compile_resources.py for upcoming material design roll
2021-06-23 hans Disable -Wmax-tokens in release component builds
2021-06-23 chromium-autoroll Roll Fuchsia SDK from 5.20210622.3.1 to 5.20210623.0.1
2021-06-23 chromium-autoroll Roll Fuchsia SDK from 5.20210622.2.1 to 5.20210622.3.1
2021-06-23 fdegans [code-health] Migrate //build/util/lib/common/PRESUBMIT.py to python3
2021-06-22 fdegans [code-health] Migrate //build/util/PRESUBMIT.py to python3
2021-06-22 svenzheng lacros test_runner.py switch to test_ash_chrome
2021-06-22 chromium-autoroll Roll Fuchsia SDK from 5.20210622.0.1 to 5.20210622.2.1
Roll buildtools/ 9c143ace7..f78b4b9f3 (30 commits)
9c143ace75..f78b4b9f33
$ git log 9c143ace7..f78b4b9f3 --date=short --no-merges --format='%ad %ae %s'
2021-12-30 jojwang Add TODO for chroot rewrapper config.
2021-12-15 cavalcantii [pac] Disable libunwind cross-architecture unwinding
2021-11-17 jojwang Update build toolchains to support rewrapper from chroot.
2021-11-09 sdefresne [ios] Remove support for building with Xcode clang
2021-10-28 Richard.Townsend Reland switch to using compiler-rt/libunwind on Android
2021-10-25 bsheedy Revert "Switch to using compiler-rt/libunwind on Android"
2021-10-21 cavalcantii Switch to using compiler-rt/libunwind on Android
2021-10-18 glider Remove myself and Sergey Matveev from the owners of libc++[abi]
2021-09-27 wutao Reland "Roll libcxxabi from c883cb129d0e to 50e90b8650bb and update build config"
2021-09-23 saza Revert "Roll libcxxabi from c883cb129d0e to 50e90b8650bb and update build config"
2021-09-23 hans Roll libcxxabi from c883cb129d0e to 50e90b8650bb and update build config
2021-09-02 yyanagisawa Add todo to rewrapper_linux.cfg.
2021-09-01 ukai Drop use_rbe_links gn args
2021-09-01 ukai remove rewrapper_*.cfg from buildtools/reclint_cfgs
2021-09-01 ukai Use `cipd ensure` instead of `cipd install -f`
2021-08-31 ukai fix permission deneid when os.remove
2021-08-31 ukai Use -force to cipd install
2021-08-31 ukai Fix win-cross-experiments config
2021-08-30 ukai Reland "use reclient cfgs cipd"
2021-08-25 ukai fetch_reclient_cfgs: ignore nacl if the directory doesn't exist
2021-08-19 yyanagisawa Revert "use reclient cfgs cipd"
2021-08-16 ukai use reclient cfgs cipd
2021-08-13 ukai container-image should have docker:// prefix
2021-08-13 ukai add fetch_reclient_cfgs.py script
2021-08-13 ukai update win-cross-experiments reclient cfgs
2021-07-16 ukai update re-client/chromium-win-nacl-cross to follow nacl roll
2021-07-07 akhuang Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)"
2021-06-30 xiaohuic Revert "Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)""
2021-06-25 xiaohuic Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)"
2021-06-24 fdegans [code-health] Migrate //buildtools/checkdeps to python3
Roll buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)
8fa8794677..79a2e924d9
$ git log 8fa879467..79a2e924d --date=short --no-merges --format='%ad %ae %s'
2021-05-25 ldionne.2 [libc++] Try to fix the oss-fuzz failure
2021-05-25 arthur.j.odwyer [libc++] [test] Make iter_difference_t.pass.cpp into a .compile.pass.cpp. NFCI.
2021-05-25 arthur.j.odwyer [libc++] [test] Format some C++20 iterator_traits tests. NFCI.
2021-05-19 arthur.j.odwyer [libc++] Assume that __wrap_iter always wraps a fancy pointer.
2021-05-24 koraq [libc++][doc] Update format paper status.
2021-05-23 joerg [libc++] use more early returns for consistency
2021-05-21 z.zoelec2 [libcxx][gardening] Re-order includes across libcxx.
2021-04-23 z.zoelec2 [libcxx][ranges] Add ranges::data CPO.
2021-05-08 ldionne.2 [libc++] Translate the test suite sanitizer support to the DSL
2021-05-13 z.zoelec2 [libcxx][ranges] Implement `ranges::borrowed_range`.
2021-05-20 ldionne.2 [libc++] Fix documentation build failure
2021-05-08 ldionne.2 [libc++] Remove workaround for PR28391 (ODR violations with ASAN)
2021-02-26 ldionne.2 [libc++] Switch a few CI jobs to the minimal Lit configuration
2021-05-13 cjdb [libcxx][ranges] adds concept `sized_range` and cleans up `ranges::size`
2021-05-04 cjdb [libcxx][iterator][nfc] acquires lock for working on [range.iter.ops]
2021-03-15 akhuang Apply [[standalone_debug]] to some types in the STL.
2021-05-12 arthur.j.odwyer [libc++] Alphabetize header inclusions and include-what-you-use <__debug>. NFCI.
2021-05-12 arthur.j.odwyer [libc++] Some fixes to the <bit> utilities.
2021-04-18 kbessonova [libcxx][test] Attempt to make debug mode tests more bulletproof
2021-05-15 kbessonova [libcxx] NFC. Add missed articles to _LIPCPP_ASSERT messages in <list>
2021-04-27 z.zoelec2 [libcxx][ranges] Add `contiguous_iterator`.
2021-05-13 koraq [libc++] Improve make_string test support.
2021-03-11 martin [libcxx] [test] Change the generic_string_alloc test to test conversions to all char types
2021-05-13 z.zoelec2 [libcxx][docs] Add two locks: transform_view and take_view.
2021-05-13 z.zoelec2 [libcxx][docs] Update the One Ranges PRoposal Status with open revisions.
2021-05-11 z.zoelec2 [libcxx][ranges] Fix `ranges::empty` when begin, end, and empty members are provided.
2021-05-12 kbessonova [libcxx] NFC. Fix misprint unodered -> unordered
2021-05-02 cjdb [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain
2021-05-03 martin [libcxx] [test] Fix fs.op.last_write_time for Windows
2021-05-12 koraq [libc++][nfc] remove duplicated __to_unsigned.
2021-05-09 kbessonova [libcxx] NFC. Correct wordings of _LIBCPP_ASSERT debug messages
2021-05-10 kbessonova [libcxx][test] Split more debug mode tests
2021-05-11 vvereschaka [libc++] Run `substitutes-in-compile-flags.sh.cpp` test on Windows.
2021-02-26 martin [libcxx] [test] Fix filesystem permission tests for windows
2021-05-11 z.zoelec2 [libcxx][tests] Fix incomplte.verify tests by disabling them on clang-10.
2021-05-10 arthur.j.odwyer [libc++] Remove more unnecessary _VSTD:: from type names. NFCI.
2021-05-10 arthur.j.odwyer [libc++] s/_VSTD::is_unsigned/is_unsigned/ in <random>. NFCI.
2021-05-10 arthur.j.odwyer [libc++] s/_VSTD::chrono/chrono/g. NFCI.
2021-05-10 arthur.j.odwyer [libc++] s/std::size_t/size_t/g. NFCI.
2021-05-10 arthur.j.odwyer [libc++] s/_VSTD::declval/declval/g. NFCI.
2021-05-10 kbessonova [libcxx][test] Make string.modifiers/clear_and_shrink_db1.pass.cpp a regular mode test
2021-05-02 cjdb [libcxx] deprecates/removes `std::raw_storage_iterator`
2021-05-01 cjdb [libcxx] makes comparison operators for `std::*_ordering` types hidden friends
2021-04-12 cjdb [libcxx] removes operator!= and globally guards against no spaceship operator
2021-04-23 z.zoelec2 [libcxx][ranges] Add ranges::empty CPO.
2021-04-12 cjdb [libcxx] removes `weak_equality` and `strong_equality` from <compare>
2021-05-09 koraq [libc++][NFC] Remove _VSTD:: when not needed.
2021-05-10 jasonliu.development [libc++][AIX] Define _LIBCPP_ELAST
2021-05-09 koraq [libc++][doc] Update the Format library status.
2021-05-08 ldionne.2 [libc++] NFC: Refactor Lit annotations
(...)
2021-02-24 martin [libcxx] [test] Quote the path to the python interpreter
2021-02-24 ldionne.2 [libc++] NFC: Fix a few tests in tuple that would succeed trivially
2021-02-24 ldionne.2 [libc++] NFC: Fix a few tests in pair that would succeed trivially
2020-10-22 martin [libcxx] [test] Don't pass INCLUDE to clang via -isystem
2021-02-24 marek.kurdej [libc++] [docs] [C++2b] Update status page with papers adopted in February 2021 virtual meeting.
2020-11-02 martin [libcxx] [test] Define _CRT_STDIO_ISO_WIDE_SPECIFIERS while building tests
2021-02-22 koraq [NFC][libc++] Fix _LIBCPP_HAS_BITSCAN64 usage.
2018-07-31 ldionne [libc++] Fix tuple assignment from types derived from a tuple-like
2021-02-20 martin [libcxx] [test] Call create_directory_symlink when linking directories
2020-11-06 martin [libcxx] Make path::format a non-class enum
2021-02-20 koraq [libc++] Fix the build for AppleClang.
2021-02-19 martin [libcxx] [test] Remove two unnecesary files/variables in a test
2021-01-09 martin [libcxx] Rename a method in PathParser for clarity. NFC.
2021-02-20 koraq [libc++] Fixes _LIBCPP_HAS_NO_CONCEPTS
2021-02-19 z.zoelec2 [libc++][nfc] Only test if pair is_assignable after C++03.
2020-11-05 martin [libcxx] Enable filesystem by default for mingw targets
2021-02-19 z.zoelec2 [libc++][nfc] SFINAE on pair/tuple assignment operators: LWG 2729.
2020-11-09 martin [libcxx] Make generic_*string return paths with forward slashes on windows
2021-02-19 z.zoelec2 [libcxx] Fix LWG 2875: shared_ptr::shared_ptr(Y*, D, […]) constructors should be constrained.
2020-11-05 martin [libcxx] Have lexically_normal return the path with preferred separators
2021-02-19 marek.kurdej [libc++] Turn off clang-format for auto-generated version header. NFC.
2021-02-18 z.zoelec2 [libc++] shared_ptr deleter requirements (LWG 2802).
2021-02-18 z.zoelec2 Mark 2534 as Complete.
2021-02-17 cjdb.ns [libcxx] adds concept `std::uniform_random_bit_generator`
2021-02-17 joerg libcxx: use early returns
2021-02-18 thakis libcxx: fix a documentation typo
2021-02-18 zibi [SystemZ][ZOS] Guard using declaration for ::fchmodat
2020-11-04 martin [libcxx] Implement append and operator/ properly for windows
2020-11-01 martin [libcxx] Implement is_absolute properly for windows
2021-02-17 ldionne.2 [libc++] Allow retries in a few more flaky tests
2020-11-03 martin [libcxx] Implement parsing of root_name for paths on windows
2021-02-16 zibi [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries
2021-02-16 colin [libc++] Build thread_win32.cpp only if LIBCXX_HAS_PTHREAD_API is not set
2021-02-15 arthur.j.odwyer [libc++] Change `std::numeric_limits` to just `numeric_limits` in <chrono>.
2021-02-15 ldionne.2 [libc++] Mark __cpp_lib_constexpr_memory as being implemented
2021-02-15 dimitry Define new/delete in libc++ when using libcxxrt
2021-02-12 zibi [SystemZ][ZOS] Fix __libcpp_thrad_isnull()
2021-02-12 zibi [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative
2021-02-11 koraq [libc++][format] Enable format_error on older compilers.
2021-02-11 koraq [libc++][format] Improve Add basic_format_parse_context.
2021-02-02 koraq [libc++][format] Add basic_format_parse_context.
2021-02-10 tokarip [libc++] Use builtins in more math.h functions.
2021-02-08 cjdb [libcxx] adds concepts `std::invocable` and `std::regular_invocable`
2021-02-04 cjdb [libcxx] adds concept std::derived_from
2021-01-21 cjdb [libcxx] adds [concepts.arithmetic]
2021-02-10 ldionne.2 [libc++] Remove c++98 Lit features in the test suite
2021-02-08 cjdb [libcxx] adds concept `std::copy_constructible`
2021-02-08 cjdb [libcxx] adds concept `std::move_constructible`
2021-02-10 colin [libc++] Fix copy-paste mistake in __threading_support
2021-02-04 cjdb [libcxx] adds concept `std::convertible_to`
Roll buildtools/third_party/libc++abi/trunk/ f4328ad7c..2715a6c0d (77 commits)
f4328ad7c0..2715a6c0de
$ git log f4328ad7c..2715a6c0d --date=short --no-merges --format='%ad %ae %s'
2021-12-08 martin [libcxx] Use LIBCXX_EXECUTOR in new test configs
2021-12-13 ldionne.2 [libc++abi][NFC] Fix comment
2021-12-10 ties.stuij [ARM][libcxxabi] Add PACBTI-M support to libcxxabi
2021-12-09 xingxue [libc++abi][AIX] Add 2 LIT tests for the AIX unwinder
2021-09-22 ldionne.2 [libc++][release] Do not force building the runtimes with -fPIC
2021-12-01 ldionne.2 [runtimes] Move WARNING to FATAL_ERROR for folks using FOO_BUILD_32_BITS
2021-11-23 ldionne.2 [runtimes] Remove support for GCC-style 32 bit multilib builds
2021-11-26 daniel.kiss [libunwind][ARM] Handle end of stack during unwind
2021-11-08 arthur.j.odwyer [libc++] [test] Eliminate libcpp-no-noexcept-function-type and libcpp-no-structured-bindings.
2021-11-17 ldionne.2 [runtimes][NFC] Remove filenames at the top of the license notice
2021-11-17 ldionne.2 [libc++abi] Don't re-define _LIBCPP_HAS_NO_THREADS in single-threaded mode
2021-11-09 daltenty [libcxx][CI][AIX] Switch to LLVM_ENABLE_RUNTIMES
2021-11-04 daniel.kiss Reland "[libcxxabi][ARM] Make CXX_end_cleanup compatible with Armv6-M"
2021-11-05 vvereschaka Revert "[libcxxabi][ARM] Make CXX_end_cleanup compatible with Armv6-M"
2021-08-11 Daniel.McIntosh [libcxxabi] Fix NO_THREADS version of test_exception_storage.pass.cpp
2021-11-04 daniel.kiss [libcxxabi][ARM] Make CXX_end_cleanup compatible with Armv6-M
2021-10-28 ldionne.2 [libc++] Temporarily mark tests as UNSUPPORTED to get the CI green
2021-10-27 daniel.kiss Reland "[ARM] __cxa_end_cleanup should be called instead of _UnwindResume."
2021-10-28 daniel.kiss Revert "Reland "[ARM] __cxa_end_cleanup should be called instead of _UnwindResume.""
2021-10-27 daniel.kiss Reland "[ARM] __cxa_end_cleanup should be called instead of _UnwindResume."
2020-09-28 phosek [CMake] Cache the compiler-rt library search results
2021-10-27 daniel.kiss Revert "[ARM] __cxa_end_cleanup should be called instead of _UnwindResume."
2021-10-27 daniel.kiss [ARM] __cxa_end_cleanup should be called instead of _UnwindResume.
2021-10-26 contact [Demangle] Add prepend functionality to OutputString
2021-10-21 dblaikie Fix for OutputStream->OutputBuffer rename
2021-10-21 vitalybuka [libcxxabi] Fix build after D111947
2021-10-21 contact [Demangle] Rename OutputStream to OutputString
2021-10-21 phosek Revert "[CMake] Cache the compiler-rt library search results"
2021-10-12 ldionne.2 [runtimes] Properly handle the sysroot/triple/gcc-toolchain
2021-10-20 ldionne.2 [libc++abi] Guard include of <unistd.h> behind __has_include
2020-09-28 phosek [CMake] Cache the compiler-rt library search results
2021-10-13 daltenty [libc++][AIX] Add scripts and config for building with the libcxx CI infrastructure
2021-10-12 ldionne.2 [libc++abi][ci] Add a from-scratch config for libc++abi on Apple/system
2021-10-12 ldionne.2 [libc++abi] Change LIBCXXABI_NO_TIMER to LIBCXXABI_USE_TIMER
2021-09-28 ldionne.2 [runtimes] Add tests for vendor-specific properties
2021-09-29 ldionne.2 [runtimes] Allow FOO_TEST_CONFIG to be a relative path
2021-09-30 ldionne.2 [libc++abi] Mark __cxa_new_handler with _LIBCPP_SAFE_STATIC
2021-10-01 tomasz.miasko [Demangle][Rust] Parse non-ASCII identifiers
2021-09-30 ldionne.2 [libc++abi][NFCI] Consistently group new_handler, unexpected_handler and terminate_handler
2021-09-30 haowei Revert "[libc++][libc++abi] Add tests for vendor-specific properties"
2021-09-28 ldionne.2 [libc++][libc++abi] Add tests for vendor-specific properties
2021-09-23 pengfei.wang [demangle] Support for ISO/IEC TS 18661 binary floating point type
2021-09-20 ldionne.2 [libc++abi] Remove unnecessary atomic_support.h header from libc++abi
2021-09-16 nehaljw.kkd1 [libcxx][libcxxabi] CMAKE_REQUIRED_FLAGS is a string, not a list
2021-09-11 zhouzhouyi [libcxxabi] NFC: fix incorrect indentation of braces
2021-08-11 martin [runtimes] Allow overriding where CMake installs RUNTIME type libraries (DLLs)
2021-09-02 ldionne.2 [libc++abi] Remove workarounds for missing -Wno-exceptions on older GCCs
2021-09-02 daniel.kiss [Unwind] Harmonise exception class for EHABI spec.
2021-08-31 ldionne.2 [libc++] Remove some workarounds for unsupported GCC and Clang versions
2021-08-30 xiaoxiang [libc++abi] Avoid the warning: "__EXCEPTIONS" is not defined, evaluates to 0 [-Werror=undef]
2021-08-24 marukawa [libc++abi] Apply simplify scan_eh_tab to SjLj
2021-08-20 ldionne.2 [libc++] Remove test-suite annotations for unsupported Clang versions
2021-08-20 ldionne.2 [libc++] Remove more test-suite workarounds for unsupported GCC versions
2021-08-04 Daniel.McIntosh [NFC][libcxxabi] Run clang-format on libcxxabi/src/cxa_guard_impl.h
2021-08-17 borisov.mikhail [libc++abi] Fix possible infinite loop in itanium demangler
2021-08-17 borisov.mikhail [libc++abi][NFC] Move PODSmallVector definition to the top of ItaniumDemangle.h
2021-08-09 ldionne.2 [libc++] Remove Lit annotations for unsupported GCC versions from the test suite
2021-08-11 daniel.kiss [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI.
2021-06-15 ldionne.2 [runtimes] Always build libc++, libc++abi and libunwind with -fPIC
2021-07-26 ldionne.2 [libc++abi/unwind] NFC: Normalize how we set target properties
2021-06-07 stuart.brady [demangler] Fix demangling of 'half'
2021-07-14 ldionne.2 [runtimes] Simplify how we set the target triple
2021-07-15 ldionne.2 [libc++] Add a job running GCC with C++11
2021-07-15 ldionne.2 [runtimes] Don't try passing --target flags to GCC
2021-07-15 ldionne.2 [libc++/abi] Fix broken Lit feature no-noexcept-function-type
2021-07-14 ldionne.2 [runtimes] Serialize all Lit params instead of passing them to add_lit_testsuite
2021-07-14 ldionne.2 [runtimes] Bring back TARGET_TRIPLE
2021-07-14 ldionne.2 [runtimes] Inherit the TARGET_TRIPLE that may be set by LLVM
2021-07-14 ldionne.2 [runtimes] NFCI: Drop intermediate CMake variable TARGET_TRIPLE
2021-07-12 ldionne.2 [libc++] Add a CI job for macOS on arm64 hardware 🥳
2021-04-28 John.Ericson Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all
2021-07-07 ldionne.2 [libc++] NFC: Fix incorrect comments in CMake
2021-07-05 ldionne.2 [runtimes] Move enable_32bit to the DSL
2021-06-18 ldionne.2 [runtimes] Simplify how we specify XFAIL & friends based on the triple
2021-06-01 ldionne.2 [libc++] Serialize Lit parameters to make them available to from-scratch configs
2021-06-28 ldionne.2 [libc++] NFCI: Remove unused Lit parameter sanitizer_library
2021-06-23 xingxue [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel
Roll tools/clang/ 03ff857f1..8b7330592 (158 commits)
03ff857f12..8b7330592c
$ git log 03ff857f1..8b7330592 --date=short --no-merges --format='%ad %ae %s'
2021-12-23 apolito fix python3 incompatibility with strings vs bytes
2021-12-18 thakis Roll clang llvmorg-14-init-12246-g7787a8f1-2 : llvmorg-14-init-12719-gc4b45eeb-1
2021-12-17 thakis clang: Statically link against hermetic libxml2 on non-Windows too
2021-12-16 danakj Package the clang libs and headers for building clang tools
2021-12-16 thakis Roll clang llvmorg-14-init-11564-g37fbf238-4 : llvmorg-14-init-12246-g7787a8f1-1
2021-12-13 thestig Fix deprecation warning in analyze_includes.py.
2021-12-10 andre.kempe Revert "Enable PAC and BTI for compiler-rt."
2021-12-08 thakis clang build script: Bump libxml2 from 2.9.11 to 2.9.12, pull from https
2021-12-08 thakis win: Statically link libxml2 into lld-link, stop running links under `ninja -t msvc`
2021-12-07 thakis Roll clang llvmorg-14-init-11416-gc22b1106-2 : llvmorg-14-init-11564-g37fbf238-1
2021-12-07 thakis Fix presubmit failing on every edit to tools/clang/scripts/build.py
2021-12-07 yukiy BRP: Convert ContentMainRunnerImpl::delegate_ to raw_ptr
2021-12-06 hans Include reclient toolchain inputs files in the clang package
2021-12-05 thakis Roll clang llvmorg-14-init-11339-g0a14674f-2 : llvmorg-14-init-11416-gc22b1106-1
2021-12-04 hans Roll clang llvmorg-14-init-11072-gb1bc627e-1 : llvmorg-14-init-11339-g0a14674f-2
2021-12-02 ynovikov Test Clang rolls on SwANGLE bots
2021-12-02 hans Roll clang llvmorg-14-init-8564-g34b903d8-9 : llvmorg-14-init-11072-gb1bc627e-1
2021-11-30 lukasza Presubmit checks that reject `raw_ptr<T>` in Renderer-only code.
2021-11-29 andre.kempe Enable PAC and BTI for compiler-rt.
2021-11-26 keishi Exclude ContentMainRunnerImpl::delegate_ from rewrite
2021-11-26 Richard.Townsend Reland "Build Clang android runtimes without relying on libgcc"
2021-11-26 keishi Exclude ReachedAddressesBitset::reached_ from rewrite
2021-11-25 keishi Fix rewriter exclusion for DoTexSubImageArguments::pixels
2021-11-24 bartekn [BRP] Update blocklist for paths to separate repositories
2021-11-24 keishi Exclude ServiceProcessState::state_ from rewrite
2021-11-23 keishi Fix clang plugin style errors for MiraclePtr Big Rewrite
2021-11-22 keishi Add rewriter exclusions for not-rewritten platform specific code
2021-11-22 keishi Add rewriter exclusions caused by Objective-C
2021-11-19 lukasza Don't append `.get()` to arguments of Unretained functions.
2021-11-19 hans Revert "Add llvm-dwp to //third_party/llvm-build"
2021-11-18 dewittj Revert "Build Clang android runtimes without relying on libgcc"
2021-11-18 hans Build Clang android runtimes without relying on libgcc
2021-11-16 bartekn Fix RewriteRawPtrFields.cpp test failures
2021-11-13 pbos Rename "base/macros.h" => "base/ignore_result.h"
2021-11-08 bikineev Revert "heap: Fix plugin bug for cppgc builds"
2021-11-05 thakis Roll clang llvmorg-14-init-8033-gabb2a91b-2 : llvmorg-14-init-8564-g34b903d8-2
2021-11-04 collinbaker Use per-target runtime dirs on Linux
2021-11-03 baghdadi zos: remove unneeded map in GetPlatformUrlPrefix
2021-11-03 agrieve Remove obsolete script download_objdump.py
2021-11-03 brucedawson Revert "Roll clang llvmorg-14-init-8033-gabb2a91b-1 : llvmorg-14-init-8281-gaa1d32f5-1"
2021-11-01 baghdadi zos:[build][tools/clang] add support for z/OS
2021-10-31 thakis Roll clang llvmorg-14-init-8033-gabb2a91b-1 : llvmorg-14-init-8281-gaa1d32f5-1
2021-10-31 thakis Remove linux_angle_deqp_rel_ng from clang roll try set
2021-10-31 keishi Fix run_tool.py after r935738
2021-10-29 hans Switch the Clang build.py shebang to Python 3
2021-10-29 thakis Roll clang llvmorg-14-init-7378-gaee49255-1 : llvmorg-14-init-8033-gabb2a91b-1
2021-10-28 thakis Move tools/clang/scripts/upload_revision.py to py3
2021-10-28 hans Clang update.py: Suggest python3 when curl'ing the script
2021-10-28 sinansahin Revert "Bump Android API level to 21 for all architectures"
2021-10-28 hans Reland "Make the Clang update.py script require Python 3"
(...)
2021-07-29 aeubanks Run PGO trybots on clang rolls
2021-07-29 hans Clang build script: Fix python3 problem after crrev.com/c/906112
2021-07-29 pkasting Revert "[BRP] Rename CheckedPtr<T> to raw_ptr<T>"
2021-07-28 bartekn [BRP] Rename CheckedPtr<T> to raw_ptr<T>
2021-07-28 hans Revert "Roll clang llvmorg-13-init-15561-gf98ed74f-1 : llvmorg-13-init-16514-gb1777b04-1"
2021-07-28 hans Clang: the tip-of-tree version is now 14.0.0
2021-07-27 keishi Reland "Treat raw_ptr specially in FindBadConstructsConsumer"
2021-07-27 keishi Enable dcheck_always_on in rewrite_raw_ptr_fields script
2021-07-27 keishi Add rewrite_raw_ptr_fields exclude fields where .get() is not added
2021-07-26 thakis Roll clang llvmorg-13-init-15561-gf98ed74f-1 : llvmorg-13-init-16514-gb1777b04-1
2021-07-24 thakis Roll clang llvmorg-13-init-15163-g98033fdc-1 : llvmorg-13-init-15561-gf98ed74f-1
2021-07-21 hans Revert "Treat raw_ptr specially in FindBadConstructsConsumer"
2021-07-21 keishi Treat raw_ptr specially in FindBadConstructsConsumer
2021-07-15 hans Link to the include analysis archive
2021-07-14 hans Revert "[Include analysis] Use multiple processes to compute dominance"
2021-07-13 lukasza Only generate exclusions for `reinterpret_cast` of *trivial* types.
2021-07-13 hans [Include analysis] Use multiple processes to compute dominance
2021-07-13 thakis Roll clang llvmorg-13-init-14732-g8a7b5ebf-2 : llvmorg-13-init-15163-g98033fdc-1
2021-07-13 thakis clang script: Add android-asan to roll trybots.
2021-07-12 thakis mac: Stop uploading a separate lld_mac package and remove last bits referring to it
2021-07-12 thakis Revert "Roll clang llvmorg-13-init-14732-g8a7b5ebf-2 : llvmorg-13-init-15040-gc10947b5-1"
2021-07-12 thakis Roll clang llvmorg-13-init-14732-g8a7b5ebf-2 : llvmorg-13-init-15040-gc10947b5-1
2021-07-09 thakis clang package script: Use more than one core to compress cab files
2021-07-09 steveroe Build .so for Chrome-Fuchsia ASan tests instead of .a.
2021-07-08 akhuang Modify goma_link.py to pass lto flags in the native link step.
2021-07-08 thakis clang package script: measure win_upload_clang zip time
2021-07-08 hans Roll clang llvmorg-13-init-14634-gf814cd74-1 : llvmorg-13-init-14732-g8a7b5ebf-1
2021-07-06 hans Roll clang llvmorg-13-init-14563-gbcaf57ca-1 : llvmorg-13-init-14634-gf814cd74-1
2021-07-06 bartekn [BRP] Rearrange sections in the path exclusion file for better grouping
2021-07-06 omerkatz heap: Clang plugin warns against tracing Persistents
2021-07-05 thakis Roll clang llvmorg-13-init-14086-ge1b8fde1-1 : llvmorg-13-init-14563-gbcaf57ca-1
2021-07-02 omerkatz heap: Revise IsStackAllocated check in clang plugin
2021-07-02 omerkatz Reland "heap: Update clang gc plugin definition of class requires tracing"
2021-07-02 omerkatz heap: Adjust plugin stubs
2021-06-29 thakis Roll clang llvmorg-13-init-14006-gd5402a2f-1 : llvmorg-13-init-14086-ge1b8fde1-1
2021-06-29 hans [include analysis] Link to chromium.googlesource.com instead of crrev.com
2021-06-29 thakis Revert "heap: Update clang gc plugin definition of class requires tracing"
2021-06-29 thakis Roll clang llvmorg-13-init-13689-g93938943-1 : llvmorg-13-init-14006-gd5402a2f-1
2021-06-28 omerkatz heap: Update clang gc plugin definition of class requires tracing
2021-06-28 hans [include analysis] Make the analysis script work on Windows
2021-06-28 findit-for-me Revert "Roll clang llvmorg-13-init-13689-g93938943-1 : llvmorg-13-init-13925-g0f24ffcd-1"
2021-06-28 thakis Roll clang llvmorg-13-init-13689-g93938943-1 : llvmorg-13-init-13925-g0f24ffcd-1
2021-06-25 omerkatz Reland "heap: Fix clang plugin handling of cppgc library types"
2021-06-24 zequanwu Roll clang llvmorg-13-init-13305-g1605fce6-4 : llvmorg-13-init-13689-g93938943-1
2021-06-23 thakis Revert "heap: Fix clang plugin handling of cppgc library types"
2021-06-22 sdefresne [macOS/Linux] Ship wasm-ld symlink to lld (with lld)
2021-06-22 omerkatz heap: Fix clang plugin handling of cppgc library types
2021-06-22 thakis mac: Remove things unneeded now that lld is in the default package
2021-06-22 thakis mac: Add lld (and llvm-ar) to default clang package
2021-06-21 thakis mac, ios: Change install name of asan and ubsan dylibs
Roll testing/ 3e2640a32..d485ae97b (4140 commits; 2 trivial rolls)
3e2640a325..d485ae97b7
$ git log 3e2640a32..d485ae97b --date=short --no-merges --format='%ad %ae %s'
2022-01-03 qsr [fuchsia] Re-disable MSE_ClearKey/EncryptedMediaTest.*
2021-12-29 wuwang Add local http server as the site to render
2021-12-28 andypaicu Cleanup autogranted DSE permissions
2021-12-23 anise Enable document scanning with maldoca by default.
2021-12-23 wylieb [Read Later] Update fieldtrial_testing_config with new variations
2021-12-22 ramyagopalan Updating to vpython for ChromeOS.
2021-12-22 ramyagopalan Fixing ValueError.
2021-12-22 ramyagopalan Moving removal of config file.
2021-12-22 xinghuilu Remove code for EnhancedProtectionPromoCard on Android.
2021-12-22 ramyagopalan Updating test_traffic_annotation_auditor to check for ChromeOS.
2021-12-21 wenbinzhang [benchmarking] Reduce shard size of nexus 5x webview
2021-12-20 lukasza [rust] Add `rust_unit_tests_group(...)` gni template.
2021-12-20 cowmoo personalization: turn on wallpaper SWA feature
2021-12-20 gujen [LR] Add fieldtrial config & fix tests
2021-12-20 majewski [Files SWA]: Finch Field Trial Testing Config.
2021-12-16 thakis Stop running variations_smoke_tests on bots for now
2021-12-16 lgrey Mac: temporarily stop stripping tests in official builds
2021-12-16 blundell Remove ClankStartupOptimizations from fieldtrial_testing_config
2021-12-16 grt [fuchsia] Add support for building and running CFv2 tests.
2021-12-16 jianli Revert "Remove SyncConsentOptional and OsSyncFeatureEnabled"
2021-12-16 sshrimp Update quickrun shards
2021-12-16 weizhong upload report.json to result db as invocation level artifact
2021-12-16 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2021-12-15 sky Adds AvoidUnnecessaryBeforeUnloadCheck to field trial testing config
2021-12-15 jongahn Add experiment for mojo sturctured metrics.
2021-12-15 jmadill gpu infra: Remove ANGLE tests from Linux Debug/TSAN.
2021-12-15 bsheedy Switch GPU Mac exp to 12.0
2021-12-15 bryantchandler [fuchsia] Remove unittests that use crash keys
2021-12-15 eseckler variations: Remove test config for PowerScheduler experiments.
2021-12-15 alexilin Revert "[Autofill Assistant] Enable animations + Remove filter"
2021-12-15 bsazonov Remove SyncConsentOptional and OsSyncFeatureEnabled
2021-12-15 alexilin Revert "[LR] Add fieldtrial config entry"
2021-12-15 sandromaggi [Autofill Assistant] Enable animations + Remove filter
2021-12-15 sshrimp Add sharding option for quickrun
2021-12-15 wenbinzhang [benchmarking] update pixel 4 os dimension to have more details
2021-12-15 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2021-12-15 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2021-12-15 carlosil Add CertificateTransparencyAndroid to field trial testing config
2021-12-15 bsheedy Fix unexpected passes typo
2021-12-15 michaeldo Remove IOS Tab Grid Bulk Actions flag
2021-12-14 lazzzis [Messages] Add fieldtrial entry for PWA install message
2021-12-14 hypan Disable failed test in perfetto_unittests on android-12-x64-fyi-rel
2021-12-14 ynovikov Re-disable Metal WebGL on 'Mac FYI ASAN (Intel)'
2021-12-14 kuanhuang setup builder win11-rel-swarming in dev
2021-12-14 weizhong Fix failures when upload artifacts for wpt tests
2021-12-14 haileywang [Snooze IPH] update fieldtrial to match finch
2021-12-14 enga WebGPU CTS: remove --disable-gpu-sandbox
2021-12-14 hidehiko Remove NonSFI mode part 8.
2021-12-14 gujen [LR] Add fieldtrial config entry
2021-12-14 thakis Build mac installer on mac-chrome trybot
(...)
2020-11-06 twellington 🤠 Disable AutofillUpstreamTest.testSaveCardInfoBarWithEmptyMonthAndYear
2020-11-06 ewannpv Revert "[iOS] Adds EnableCloseAllTabsConfirmation config"
2020-11-06 ewannpv [iOS] Adds EnableCloseAllTabsConfirmation config
2020-11-06 asamidoi Add warn-only and enforce mode to the CheckOfflineCapability feature
2020-11-06 livvielin [ios] Enable kIOSLookalikeUrlNavigationSuggestionsUI by default
2020-11-06 isherman List Weilun as a fieldtrial_testing_config.json OWNER
2020-11-05 xiaochengh Prepare CSSKeyframesMemoryReduction for finch experiment
2020-11-05 schwering [Autofill] Removed obsolete features AutofillEnforceMinRequiredFields*.
2020-11-05 pbos Remove UseTextForUpdateButton from testing config
2020-11-05 lpz Disable (via flag) baselines translation and annotation handling in wptMetadataBuilder for desktop wpt bots.
2020-11-05 erikchen Update field-trial testing config for heap profiling.
2020-11-05 vasilii Fully launch the compromised password bubble on ToT and delete the flag.
2020-11-05 clemensb [libfuzzer][v8][inspector] Restrict alphabet to ascii
2020-11-05 msisov ozone/x11: fix views_unittests
2020-11-05 benreich [js-code-coverage] Merge JavaScript v8 coverage outputs
2020-11-05 chrome-weblayer-builder weblayer: Add skew tests for new versions released in beta
2020-11-05 ddoman [resultdb] disable SinkAPI-integration on blink_web_tests
2020-11-04 sprang Removes WebRTC-VideoRateControl trial from test config
2020-11-04 chanli Enable resultdb on test suites with single test
2020-11-04 liaoyuke [lacros] Stop isolating prebuilt ash-chrome
2020-11-04 gatong Infra: Removing experimental builders
2020-11-04 bpastene Remove cros_browser_sanity_test from all CrOS bots.
2020-11-04 ewannpv [iOS] Launch EnablePersistentDownloads feature
2020-11-04 dschinazi Add HostResolverDispatch to fieldtrial_testing_config
2020-11-04 agrieve Revert "Reland #2: Android: Use locally-build devil deps only when build_with_chromium=true"
2020-11-04 kmoon Make PDF partial loading disabled the default
2020-11-04 gayane Revert "Add share features to testing config"
2020-11-04 jdonnelly [omnibox] Add on-focus feature to the desktop field trial testing config
2020-11-03 bjoyce Add chrome_junit_test shard experimental test suit.
2020-11-03 ender Add Trending Queries to testing config.
2020-11-03 yilkal Reland "Reland "Adds parental handoff login screen in oobe.""
2020-11-03 jmadill Add ANGLE gold trace tests to GPU.FYI.
2020-11-03 jmadill Re-enable angle_white_box_tests on TSAN.
2020-11-03 ianstruiksma Win10 - Remove temp 1909/1803 bots
2020-11-03 jmadill Remove ANGLE tests from NV Shield TV.
2020-11-03 rmhasan weblayer, skew tests: Add src/ changes to add testers for Android Marshmallow
2020-11-03 agrieve Reland #2: Android: Use locally-build devil deps only when build_with_chromium=true
2020-11-03 jmadill Add flaky retries for Win7/AMD ANGLE tests.
2020-11-03 rmhasan weblayer, skew tests: Make rmhasan@ sole reviewer for CL's uploaded by create-weblayer-skew-tests
2020-11-03 jmadill Remove angle_unittests swarming exception.
2020-11-03 clemensb [libfuzzer][v8][inspector] Add inspector_fuzzer
2020-11-03 nohle [DeviceSync v2] Enable v2 DeviceSync flag by default
2020-11-03 ianstruiksma Have win10-omaha-tester use win10 version mixin
2020-11-03 drott Rebaselines for running layout tests on Windows 10 1909
2020-11-02 tmathmeyer Add d3d11 stable fieldtrial testing configs
2020-11-02 drubery Add windows to platforms for ClientSideDetectionModel
2020-11-02 kylechar Disable webgl_conformance_fast_call_tests
2020-11-02 chrome-weblayer-builder weblayer: Add skew tests for new versions released in beta
2020-11-02 bpastene Move net_unittests on the internal CrOS VM bot to the main test pool.
2020-11-02 mbonadei Add filter file to content_browsertests data_deps.
Roll third_party/googletest/ 282877317..6b74da475 (287 commits)
2828773179..6b74da4757
$ git log 282877317..6b74da475 --date=short --no-merges --format='%ad %ae %s'
2021-12-27 absl-team Include the param names in the generated description of the MATCHER_P matchers.
2021-12-22 absl-team Clarify "package" means "Bazel package", and promote `testonly=True` rather than `testing` sub-directory.
2021-12-22 dmauro Makes the Python imports consistently use full paths from the repository root, unifying the behavior between Bazel and CMake
2021-12-21 dmauro Makes TestForDeathTest.CRTDebugDeath only run when _DEBUG is defined
2021-12-15 dinor Release tests for UnitTestOptions::MatchesFilter
2021-12-07 absl-team Add NOLINT to address modernize-use-trailing-return-type in TEST_F uses
2021-12-04 ayush854032 Allow to specify a random seed independently of whether shuffling is requested
2021-12-03 absl-team Support std::reference_wapper as a smart pointer type in gmock
2021-12-02 absl-team Fix typo in GoogleMock Cookbook.
2021-11-29 absl-team Work around Android KitKat tzset bug
2021-11-25 ludger.paehler Fix typo in the queue test.
2021-11-16 denis.samoylov Suppress unused-value warning
2021-11-16 93249401+assafpr fixed branch from master to main in readme.md
2021-11-16 93249401+assafpr Update README.md
2021-11-16 krystian.kuzniarek fix a typo
2021-11-15 cramertj Clarify "Times() after X" error message
2021-11-15 dmauro Update URLs in Bazel Quickstart
2021-11-12 absl-team Fix typo in gmock-matchers_test.cc: CanDescribeNegationOfExpectingOneElment => CanDescribeNegationOfExpectingOneElement
2021-11-10 absl-team Googletest export
2021-11-09 dmauro Googletest export
2021-11-10 memmenlauer googletest/src/gtest-port.cc: Added GetLastError() on Windows for CreateThread()
2021-11-09 absl-team Googletest export
2021-11-08 absl-team Googletest export
2021-11-08 absl-team Googletest export
2021-11-04 absl-team Googletest export
2021-11-05 raul.tambre Replace use of deprecated std::iterator
2021-11-03 absl-team Googletest export
2021-10-28 dmauro Googletest export
2021-10-27 dmauro Googletest export
2021-10-26 absl-team Googletest export
2021-10-26 absl-team Googletest export
2021-10-25 dmauro Googletest export
2021-10-25 dmauro Googletest export
2021-10-30 dartme18 Re #3637 Show Disabled Tests in testing output
2021-10-20 h.zeller Start a simple github actions CI
2021-10-11 absl-team Googletest export
2021-10-11 absl-team Googletest export
2021-10-11 absl-team Googletest export
2021-10-08 yesudeep Fix linker errors on FreeBSD.
2021-09-30 absl-team Googletest export
2021-09-28 absl-team Googletest export
2021-09-24 cclauss Fix remaining typos discovered by codespell
2021-09-20 absl-team Googletest export
2021-09-20 absl-team Internal change
2021-09-17 julian.amann Remove bazelbuild/rules_cc dependency
2021-09-16 cclauss Fix typos discovered by codespell
2021-09-16 cclauss Fix typos discovered by codespell
2021-09-16 cclauss Fix typo discovered by codespell
2021-09-15 absl-team Googletest export
2021-09-15 dmauro Googletest export
(...)
2021-01-11 corentinmusard Simplify cmake install file
2021-01-06 davidben Restore GTEST_ATTRIBUTE_PRINTF_ on ColoredPrintf
2021-01-03 krystian.kuzniarek remove explicit function overloads of CmpHelper?? for BiggestInt arguments
2020-12-30 mattias.ellert Port to GNU/Hurd
2020-12-29 julien.jemine Using auto instead of container::const_iterator
2020-12-25 mattias.ellert Fix gtest-help-test failure on GNU/kFreeBSD
2020-12-24 georgthegreat Use proper feature test macro to test if library supports char8_t
2020-12-21 absl-team Googletest export
2020-12-15 dmauro Googletest export
2020-12-11 absl-team Googletest export
2020-12-10 absl-team Googletest export
2020-12-10 dmauro Googletest export
2020-12-08 absl-team Googletest export
2020-12-07 absl-team Googletest export
2020-12-07 absl-team Googletest export
2020-12-07 absl-team Googletest export
2020-12-05 paul.malcolm Fix typo in CLI help message
2020-12-05 gautham.bangalore Fix typo
2020-12-04 zed.three CMake: Add namespaced ALIAS library
2020-12-03 absl-team Googletest export
2020-12-02 absl-team Googletest export
2020-12-02 absl-team Googletest export
2020-12-01 absl-team Googletest export
2020-11-30 dmauro Googletest export
2020-11-24 absl-team Googletest export
2020-11-23 absl-team Googletest export
2020-11-19 absl-team Googletest export
2020-11-13 vlee Initialize TestInfo member is_in_another_shard_ in constructor.
2020-11-12 absl-team Googletest export
2020-11-12 absl-team Googletest export
2020-11-12 absl-team Googletest export
2020-11-11 dmauro Googletest export
2020-11-11 dmauro Googletest export
2020-11-11 dmauro Googletest export
2020-11-11 absl-team Googletest export
2020-11-11 marius.brehler Refactor finding python
2020-11-06 absl-team Googletest export
2020-11-06 absl-team Googletest export
2020-10-29 knut Only save original working directory if death tests are enabled
2020-11-08 hyuk.myeong fix typos
2020-11-06 absl-team Googletest export
2020-11-05 ofats Googletest export
2020-10-30 chuck.atkins Bump CMake minimum to 2.8.12
2020-10-27 elliott.brossard Add instructions for sanitizer integration
2020-09-16 hyuk.myeong Remove spaces between Google Test and Google Mock
2020-09-15 hyuk.myeong Add follow-up patch for more natural reading
2020-09-15 hyuk.myeong Apply the reviewed comment
2020-09-15 hyuk.myeong Remove a space
2020-09-15 hyuk.myeong Improve the tutorial that may be confusing
2020-02-17 krystian.kuzniarek remove a duplicated include
Bug: dawn:824
Change-Id: Ic7c5c5f808ed510282dc47231d843f1fae355e17
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/75061
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Accidental commit of my test file for checking tint behavior.
Add to the .gitignore file so I don't accidentally check this in again.
Change-Id: Ie67f04cc307fa180d3a65d867a1777d008be8e17
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70981
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Generate and validate all entry points individually.
This is required since GLSL has separate shader files, and
can only have a single "main" entry point.
Bug: tint:1217
Change-Id: Ie5cb510aaef3b7c8a7573f5fa9446815284afecb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/61920
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
These are behind the new `dawn_node` flag, which can be enabled by using the new `scripts/standalone-with-node.gclient` file.
Bug: dawn:1123
Change-Id: Ia7ca715808e46b17f91338f56ffc6794d0104fd7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64900
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
If this prefix is omitted, then any subdirectory that matches the pattern will also be ignored.
Change-Id: I09b2629156416c26f885d765f88e69be236b7d3e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64745
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This reverts commit 020d69905e.
Reason for revert: Causing Dawn Skia roll build fails
https://task-scheduler.skia.org/job/AZXXBm9h9ozj3kKiRJM5
Original change's description:
> Added Abseil as a third-party dependency
>
> Using the version in the Chromium repo in order to make use of the .gn
> files it contains.
>
> Doing so also appears to require us to switch where we pull googletest
> from so that the directory structure matches what the Abseil build
> config expects. Fortunately this doesn't seem to cause issues in our
> tests.
>
> Bug: dawn:563
> Change-Id: I55831ad33f282b3d8b03b67826fd2776e5602d89
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/63780
> Reviewed-by: Austin Eng <enga@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Auto-Submit: Brandon Jones <bajones@chromium.org>
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: dawn:563
Change-Id: I0fc4e5fc73ab9b0887591135ec01adde990edd6f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64361
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Using the version in the Chromium repo in order to make use of the .gn
files it contains.
Doing so also appears to require us to switch where we pull googletest
from so that the directory structure matches what the Abseil build
config expects. Fortunately this doesn't seem to cause issues in our
tests.
Bug: dawn:563
Change-Id: I55831ad33f282b3d8b03b67826fd2776e5602d89
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/63780
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Brandon Jones <bajones@chromium.org>
This change adds a new tint fuzzer that uses SPIRV-Tools to fuzz SPIR-V binaries.
The fuzzer works on a corpus of SPIR-V shaders. For each shader from the corpus it uses
one of `spirv-fuzz`, `spirv-reduce` or `spirv-opt` to mutate and then runs the shader through
the Tint compiler in two steps:
- Converts the mutated shader to WGSL.
- Converts WGSL to some target language specified in the CLI arguments.
The list of all supported CLI arguments and their description is in the cli.h file.
Change-Id: I95c0741b78ccc600dd9a73c371d520bdf7814352
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41945
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Vasyl Teliman <vasniktel@gmail.com>
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: Alastair Donaldson <allydonaldson@googlemail.com>
Useful when making multiple out of source builds from the same source.
Also made it ignore only build folders from the root, in case there's
any "build*" subfolder in the tree.
Change-Id: I0140bb3aed73d2e88a6f1165f2b4c80fb99a8cf8
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51141
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
main packages usually go under a `cmd` directory.
Hoist utility packages to the root `src` directroy so they can be shared.
Change-Id: I0c221f6cd39980f5c202c030cd5134d775533efa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50901
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
With all tests converted to WGSL we only use shaderc to assemble SPIRV
assembly to binary. shaderc requires glslang but we don't use it at all.
By using SPIRV-Tools directly to assemble SPIR-V, we can remove both the
shaderc and glslang dependencies.
Bug: dawn:572
Bug: chromium:1150045
Change-Id: I1588428dfb9478e7b724478bec662d002ee920e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45765
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Contains a few helper tasks that make developing with VSCode easier
Change-Id: I4bc8c86638804255e6a23f95f4bb6d02dfeef7cd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45601
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Contains a bunch of helper tasks for building the project and pushing changes to gerrit
Change-Id: I1f2b118e0fd811c5b67f26803d94569609697284
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44785
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Emitted in the CWD when you run executables with the coverage enabled.
I find myself running the unittests from the project root a lot, and this file is annoying to skip when staging code.
Change-Id: I25557c941b2723aa300fcde827d281b054cbf2fd
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42843
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
This allows us to roll all Vulkan- and SPIRV-related dependencies
simultaneously (which are often inter-dependent).
This change also implicitly rolls the dependencies to the revs in ANGLE.
Change-Id: I50a1e5b2ef706ffbfbc22f5783321820bb50ae96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36500
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
The new `tint-generate-coverage` CMake target can be used with the clang toolchain to generate a `lcov.info` file at the root of the project, along with a `coverage.summary` human readable plain text file.
The `lcov.info` file can then be used by various tools to display code coverage information in your IDE / code editor.
Useful for ensuring decent test coverage.
Change-Id: I3d846f6da3af25d3d600d8e028f27b89e35b545f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/31121
Commit-Queue: Ben Clayton <bclayton@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This CL adds a script to run tint over the shaders in a given folder and
attempt to generate the WGSL, HLSL, MSL and SPIRV-ASM shaders. The
GPUWeb CTS is added to third_party and the validation folder set as the
default folder to execute.
Change-Id: I63a0af056416e2f99ed8e3f92f9e2ca31c2b3e49
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/25561
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Tint is behind a build flag, since Tint is not yet available in
chromium's third_party.
BUG=dawn:403
Change-Id: If5fa36b36216ef6965341b886c3bd70d27daf23a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/21300
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
This CL fixes up some issues which give compile errors when building
with Visual Studio.
Change-Id: Ib76644d869dd2adccd579621d18804d84b65a74c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/20940
Reviewed-by: David Neto <dneto@google.com>
This CL adds the beginning of break and continue support. The
conditional versions are not supported, just the non-conditional.
Bug: tint:5
Change-Id: I84418cffd3e29dc011c4313bf9aa3da4833c009f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/20500
Reviewed-by: David Neto <dneto@google.com>
On macOS we can't rely on having the Vulkan loader installed in the
system. So we add the Vulkan loader as an optional dependency of Dawn
and use it on macOS when building Dawn in standalone with Vulkan
support.
Usage of building our own loader might broaden if the loader gains
features that are useful on other OSes. For example the ability to pass
in the "root ICD" entrypoint to the loader so we can have both
Swiftshader and the system driver at the same time.
Bug: dawn:388
Change-Id: I7ade4961cce0463c66846ad17aebf95224f1afcc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19723
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This Cl updates the .gitignore with the .gclient and .gclient_entries
files.
Bug: tint:12
Change-Id: I645016ca83396c0616f2ad3f69d2ce510be59b53
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/16580
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
This adds swiftshader as a dependency of Dawn, and when it is present
dawn_use_swiftshader=true will force usage of it. (due to a Vulkan
loader limitation we can't have both regular drivers and swiftshader in
the same VkInstance).
BUG=dawn:283
Change-Id: Ib94f4dcca652eb380e994f007cdcfb145b1a5102
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13440
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Trace data can be used to build additional metrics which measure
validation costs, GPU time, etc. It will also be helpful to store in
the test output for later analysis.
This CL also adds jsoncpp as a DEP so we can dump trace file json
output.
Bug: dawn:208
Change-Id: Ia6c05ca90aecae308ee6a4fd11e5f43bb03b1dc9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12080
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Gclient now creates a .cipd directory so we ignore it. third_party/stb
was removed so we stop ignoring it.
BUG=
Change-Id: Iad1b9309f32f900cd19f199ba51acafd2b936358
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/10360
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Unify code generation for Client->Server and Server->Client commands.
Methods in dawn.json are converted into command records and additional
commands are specified in dawn_wire.json. This can then be used to
completely generate the command handlers and command struct definitions.
Bug: dawn:88
Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0
Reviewed-on: https://dawn-review.googlesource.com/c/3800
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This also removes support for Travis and AppVeyor, as well as git
submodules for dependencies.
It also adjusts .gitignore to include dependencies (submodules are
implicitly ignored but are removed in this commit).
Finally, removes some CMake-specific code from the code generator.
BUG=
Change-Id: I4ebc04e530a574b412ef0ca81e4672db01f0ed92
Reviewed-on: https://dawn-review.googlesource.com/c/2040
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>