dan sinclair
529c3fd385
Add clone into constant/
...
This Cl adds the ability to clone a constant into a context provided.
This allows the IR to clone the constants out of the Program and into
the IR.
Bug: tint:1718
Change-Id: I78170cdc66b5824a1ab81000976a747b5bffee79
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116363
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Reviewed-by: Ben Clayton <bclayton@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
2023-01-06 02:57:36 +00:00
dan sinclair
b53b8cf5be
Rename constant::Constant to constant::Value.
...
This CL renames constant::Constant to constant::Value as it reads a bit
nicer.
Bug: tint:1718
Change-Id: I3489a271ebe229dabf98e7668bdaef4fec375534
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114361
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
2022-12-15 16:25:31 +00:00
dan sinclair
5addefb148
Rename Constant::As to Constant::ValueAs.
...
This CL updates Constant::As to be Constant::ValueAs. Now that Constant
inherits from CastableBase, there is already an As method on
CastableBase. This makes the override inside Constant confusing and
potentially incorrect.
Bug: tint:1718
Change-Id: I4f73971801e95225a99a5a993124c04194d0d7d6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114360
Reviewed-by: Ben Clayton <bclayton@google.com >
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Kokoro: Dan Sinclair <dsinclair@chromium.org >
2022-12-14 20:46:32 +00:00
dan sinclair
93c0ef2b33
Reduce default vec size in composite.
...
This CL decreases the default vector size in Composite from 8 to 4.
There will, probably, be a lot more vectors then arrays and structs so
this should reduce the used memory slightly.
Change-Id: I0a47780736192b43189cd211d34744a4f8028b97
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114200
Kokoro: Kokoro <noreply+kokoro@google.com >
Reviewed-by: Ben Clayton <bclayton@google.com >
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
2022-12-14 19:29:10 +00:00
dan sinclair
8626c9ee87
Move constants into constant namespace.
...
This CL moves the constants into the constant namespace.
Bug: tint:1718
Change-Id: Id8f98ca6c16085136c06d98bbd8b755b36cb2409
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114161
Kokoro: Kokoro <noreply+kokoro@google.com >
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Reviewed-by: Ben Clayton <bclayton@google.com >
2022-12-14 19:22:19 +00:00
dan sinclair
0890380d10
Split concrete constant classes into own files.
...
This Cl splits the concrete constant implementations out of the
const_eval.cc file and into individual files. The classes are left in
the resolver namespace and will have a namespace update in a followup
CL.
Bug: tint:1718
Change-Id: I54539b6aa06f09aff39a1b1331d89f67a3594791
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114160
Reviewed-by: Ben Clayton <bclayton@google.com >
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Kokoro: Kokoro <noreply+kokoro@google.com >
2022-12-14 18:13:37 +00:00
dan sinclair
60eac72504
Move constants into a Castable hierarchy.
...
This CL moves constant to inherit from Castable.
Bug: tint:1718
Change-Id: Ifd00bcd77a838dfa560096ad95af5cf6065bfb5d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114100
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Reviewed-by: Ben Clayton <bclayton@google.com >
Kokoro: Kokoro <noreply+kokoro@google.com >
2022-12-13 22:36:04 +00:00
dan sinclair
10182c46d9
Move sem::Constant to constant::Constant
...
This CL splits the base constant code out of sem into their own folder.
This will allow re-using the constants in the IR. The concrete
implementations from the resolver will move in followup CLs.
Bug: tint:1718
Change-Id: Ic370db76dce34e3e6eca56a9c2a8df607492b4a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113802
Reviewed-by: Ben Clayton <bclayton@google.com >
Commit-Queue: Dan Sinclair <dsinclair@chromium.org >
Kokoro: Kokoro <noreply+kokoro@google.com >
2022-12-13 14:17:50 +00:00