Commit Graph

754 Commits

Author SHA1 Message Date
David Neto 25b856aa64 [spirv-reader] Avoid certain hoisting cases
If a definition occurs in the first block of an IfSelection or
SwitchSelection, then it should count as belonging to the scope of the
parent of that if or switch selection.  This prevents some bad hoisting
decisions.

Bug: tint:3, tint:213
Change-Id: I89df5e8cbc163577e19e78c2bf393eb1eec4a0aa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27660
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: David Neto <dneto@google.com>
2020-08-28 19:58:12 +00:00
David Neto fed63103f5 [spirv-reader] Follow non-canonicalized SPIR-V type for composite extract
Follow the actual SPIR-V type when computing a composite extract
instad of the canonicalized view in the optimizer's type manager.
Do this so we can generate the correct member name for a struct,
rather than using the member name for the other representative
struct type. The optimizer's type canonicalizer is insensitive to
struct member names.

Prompted by tint:213, for which the original case was an
access chain.

Bug: tint:3, tint:213
Change-Id: I8705c7ee655fe47c8b7a3658db524fe18833efdb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27603
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-28 16:28:42 +00:00
David Neto 53b1c39036 [spirv-reader] Follow non-canonicalized SPIR-V type for access chains
Follow the actual SPIR-V type when computing an access chain expression,
instead of the canonicalized view in the optimizer's type manager.
Do this so we can generate the correct member name for a struct,
rather than using the member name for the other representative
struct type. The optimizer's type canonicalizer is insensitive to
struct member names.

Fixes tint:213

Bug: tint:3, tint:213
Change-Id: I88ec42a4cb049b011a59d5522e4cb39bc181a4fb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27602
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-28 15:49:31 +00:00
dan sinclair 46252ec3ba [wgsl-parser] Consume empty struct closing brace.
This CL updates the WGSL parser to consume the closing } of an empty
struct.

Bug: tint:218
Change-Id: I0b17d2178b1b4b7f44fcf007da867db07dc2a6ae
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27600
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-27 18:17:10 +00:00
Sarah Mashayekhi 5f915f1f92 [validation] check if at least one of vertex, fragment or compute shader is peresent
Bug: tint: 6
Change-Id: I826d951c374409699082f38fb65225f5b4a83f2d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27483
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-27 18:05:00 +00:00
Sarah Mashayekhi 4bc38c3f63 [validation] Add a helper function to create a fake entry point
Change-Id: I234c04315bec006597caed38f1872baf348a3651
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27482
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-27 17:59:20 +00:00
dan sinclair 8d72a2bc4e Add missing doc comments.
This cl adds some missing doc comments.

Change-Id: Ic5452c2f9a40ddcc4642062a338f602632f3e057
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27520
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: David Neto <dneto@google.com>
2020-08-26 20:38:46 +00:00
dan sinclair 63b007d34f [hlsl-writer] Move test helper to a template.
This CL updates TestHelper to be a templated class and converts the test
suites into using statements based off that template.

Bug: tint:7
Change-Id: I747434e7c6a8ecae353df448f06153e982dcec44
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27500
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-26 20:02:26 +00:00
dan sinclair 663be30b55 [hlsl-writer] Support matrices in storage buffers.
This CL adds the needed code to load matrix data from a storage buffer.

Bug: tint:7
Change-Id: I850b03adc7fa957b7babbad40d07ec3544b0617f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27442
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
2020-08-26 19:55:46 +00:00
dan sinclair fea2636945 [hlsl-writer] Emit numthreads for compute shaders.
This CL adds the numthreads annotation when emitting compute shaders.

Bug: tint:7
Change-Id: Ie0f47adfca0a0684f701f280958163b3da0019b4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27480
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-26 19:24:26 +00:00
dan sinclair 42b0e2d5af [hlsl-writer] Emit zero matrix values.
This CL extends the zero emission to support matrices.

Bug: tint:7
Change-Id: I7e39a68c83edb096fc4b365c66539e8a8b7cb1db
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27443
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-26 19:24:16 +00:00
dan sinclair 04746d930d [hlsl-writer] Extract storage buffer index generation.
This CL extracts the index string for a storage buffer access.

Bug: tint:7
Change-Id: Ibc0d7dd5b532bbd6141cce4a82495732452d1414
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27441
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-26 19:22:56 +00:00
dan sinclair 43915bd0a1 Emit structs when emitting the aliases.
This Cl updates the AST dump command to emit struct members after
emitting the type alias.

Change-Id: I5e0c3d8f2cc56525586646c613839c2e014d471f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27320
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-26 19:09:26 +00:00
dan sinclair df503f0e85 [hlsl-writer] Refactor output emission.
This CL updates the HLSL backend to take the output stream as a
parameter. This is needed because there are cases where we have to
generate the resulting stream out of order. This will allow that to
happen.

Bug: tint:7
Change-Id: Id1877a07e536a84da0555f207d1030588d44c034
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27440
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-26 19:05:46 +00:00
dan sinclair bdb86723e8 [hlsl-writer] StorageBuffer support.
This Cl adds support for storage buffers to the HLSL backend.

Bug: tint:7
Change-Id: I7adb655de8ccfcb6771fa661ff205c543b4efe66
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27001
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-25 21:22:37 +00:00
Sarah Mashayekhi fc1327f1d9 [validation] implement the pair of entry point stage and name must be unique
This CL implements the following rule:
v-0020: The pair of <entry point name, pipeline stage> must be unique in the module

Bug: tint: 6
Change-Id: Id0c50438861b251d48a9f8dcb8a23556327c965c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27380
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
2020-08-25 21:22:07 +00:00
Sarah Mashayekhi 6a0e28b624 [valdiation] Add disable test for v-0020, the <entry point name, pipeline stage> must be unique
Bug: tint: 6
Change-Id: I3fa9c1427ee99c9a442369516ddef0c11f33304f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27280
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-25 16:06:24 +00:00
Sarah Mashayekhi 4fb431c90e [validation] validates if global variables have a storage class
This CL moves the global variables checks to a function
Adds tests and checks for validation rule v-0022:
Global variables must have a storage class.

Bug: tint: 6
Change-Id: I2f2cd7df6e849bfd1ddfbca35568c6fc3345efa6
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27283
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-25 15:04:53 +00:00
dan sinclair deea295fc1 [wgsl-parser] Set max recursion depth on const_expr
The `const_expr` can recurse into itself if there are type declarations
inside the const_expr (e.g. vec2<f32>(f32(1.0), f32(2.0))). Currently
there is no limit on the amount of recursion which can be triggered.

This CL sets a limit of 128 nested type declarations at which point an
error will be emitted.

Bug: chromium:1112144
Change-Id: Ifae45034dc9de35aed78ba8eddf584a46c7a55ce
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27340
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-25 14:58:33 +00:00
Ryan Harrison a291fc1e7f Ran 'git cl format' over an empty CL
Change-Id: Ied8585a4d266900925a81836db45f7525cd5f628
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27181
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-25 14:55:53 +00:00
Sarah Mashayekhi 3765a24060 [validation] clean up: using ValidatorImpl member instead of creating one
Change-Id: I9a35319a33b5c9c0508d1fdc38c8678ca204b4ce
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27285
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-25 14:09:03 +00:00
Sarah Mashayekhi 3fad211a8f [validation] Add a validator test helper class
Change-Id: I12d225dbbda3ceffda6f0f0dbf264a6a6b249fb2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27284
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-25 14:06:05 +00:00
Tomek Ponitka 63a5aa7d58 [wgsl-reader] Adding for loops
Implementing ParserImpl::for_stmt(). Also adding
for_stmt and body_stmt to ParserImpl::statement().

Bug: tint:138
Change-Id: Idc3f901648ca115f4d94b3614a940263ef841282
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27261
Commit-Queue: Tomek Ponitka <tommek@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-24 18:22:22 +00:00
Ryan Harrison 4641d76a2e Rolling 6 dependencies
Roll build/ 6c915ac2a..aae8259e7 (164 commits)

6c915ac2af..aae8259e75

$ git log 6c915ac2a..aae8259e7 --date=short --no-merges --format='%ad %ae %s'
2020-08-24 chromium-autoroll Roll Fuchsia SDK from 0.20200823.3.1 to 0.20200824.0.1
2020-08-24 sdefresne [ios] Add support for building .swift files
2020-08-24 chromium-autoroll Roll Fuchsia SDK from 0.20200823.2.1 to 0.20200823.3.1
2020-08-23 smcallis Refactor OS_LINUX preprocessor directive for LaCrOS effort.
2020-08-23 chromium-autoroll Roll Fuchsia SDK from 0.20200823.1.1 to 0.20200823.2.1
2020-08-23 chromium-autoroll Roll Fuchsia SDK from 0.20200822.3.1 to 0.20200823.1.1
2020-08-23 chromium-autoroll Roll Fuchsia SDK from 0.20200822.2.1 to 0.20200822.3.1
2020-08-22 chromium-autoroll Roll Fuchsia SDK from 0.20200822.1.1 to 0.20200822.2.1
2020-08-22 chromium-autoroll Roll Fuchsia SDK from 0.20200821.3.1 to 0.20200822.1.1
2020-08-22 chromium-autoroll Roll Fuchsia SDK from 0.20200821.2.1 to 0.20200821.3.1
2020-08-21 estade Move //chrome/common/media_router to //components/media_router/common
2020-08-21 thomasanderson [XProto] Remove usage of all Xlib and XCB extensions
2020-08-21 chromium-autoroll Roll Fuchsia SDK from 0.20200821.1.1 to 0.20200821.2.1
2020-08-21 liaoyuke [lacros] Add documentation for use with xvfb
2020-08-21 agrieve Reland #2: Add -noverify to build commands to improve runtime (local builds only)
2020-08-21 bsheedy Add Gold CRS arg
2020-08-21 dpranke Roll GN from e327ffdc..6f13aaac and update BUILD files.
2020-08-21 chromium-autoroll Roll Fuchsia SDK from 0.20200821.0.1 to 0.20200821.1.1
2020-08-21 chromium-autoroll Roll Fuchsia SDK from 0.20200820.3.2 to 0.20200821.0.1
2020-08-21 wychen Revert "Reland "Add -noverify to build commands to improve runtime (local builds only)""
2020-08-21 chromium-autoroll Roll Fuchsia SDK from 0.20200820.2.1 to 0.20200820.3.2
2020-08-20 uekawa install-build-deps: lib32gcc1 to lib32gcc-s1
2020-08-20 tcwang [build] Provide a GN arg to enable call-graph-profile-sort
2020-08-20 agrieve Reland "Add -noverify to build commands to improve runtime (local builds only)"
2020-08-20 agrieve Android expectations: Improve node sort order
2020-08-20 jeffyoon [ios/infra] move xcode-parallelization to testing/buildbot
2020-08-20 chromium-autoroll Roll Fuchsia SDK from 0.20200820.1.1 to 0.20200820.2.1
2020-08-20 chromium-autoroll Roll Fuchsia SDK from 0.20200819.3.1 to 0.20200820.1.1
2020-08-20 aeubanks Roll clang llvmorg-12-init-1771-g1bd7046e-5 : llvmorg-12-init-3492-ga1caa302-1.
2020-08-20 dpranke Add a python2_action() template and use it in :histograms_xml.
2020-08-20 chromium-autoroll Roll Fuchsia SDK from 0.20200819.1.1 to 0.20200819.3.1
2020-08-19 dpranke Reland "Rework generated_script handling in MB."
2020-08-19 mheikal Make doubledown rolled packages private
2020-08-19 mheikal [Android] Ignore trailing whitespace in expectation diff-patch lines
2020-08-19 bjoyce Fix flakey test_server.
2020-08-19 agrieve Android: When lint fails, print hint about treat_warnings_as_errors=false
2020-08-19 smcallis Refactor OS_LINUX preprocessor directive for LaCrOS effort.
2020-08-19 chromium-autoroll Roll Fuchsia SDK from 0.20200819.0.1 to 0.20200819.1.1
2020-08-19 sebmarchand Make the Linux PGO build use the archived profiles
2020-08-19 justincohen Revert "Rework generated_script handling in MB."
2020-08-19 mark mac/arm64: Update to Xcode 12b5 (12A8189h)
2020-08-19 mark mac/arm64: Compile with -mcpu=apple-a12
2020-08-19 chromium-autoroll Roll Fuchsia SDK from 0.20200818.4.1 to 0.20200819.0.1
2020-08-19 dewittj JDK Lib Dexer: Ignore keep file if none is generated.
2020-08-19 agrieve Android: Capture more tombstones in instrumentation tests
2020-08-19 hajimehoshi Revert "Add -noverify to build commands to improve runtime (local builds only)"
2020-08-18 chromium-autoroll Roll Fuchsia SDK from 0.20200818.1.1 to 0.20200818.4.1
2020-08-18 agrieve Add -noverify to build commands to improve runtime (local builds only)
2020-08-18 rjascani [Fuchsia] Use isolated-cache for the cdm_data_directory
2020-08-18 smcallis Refactor OS_LINUX preprocessor directive for LaCrOS effort.
(...)
2020-08-10 svenzheng Using latest file to determine latest version for lacros runner
2020-08-10 chromium-autoroll Roll Fuchsia SDK from 0.20200810.1.1 to 0.20200810.2.1
2020-08-10 chonggu [Fuchsia] Remove loglistener from DeviceTarget.
2020-08-10 agrieve Reland "build_vars.txt: Changed to build_vars.json"
2020-08-10 mheikal Fix bug where chrome's app icon is missing in AGSA
2020-08-10 ntfschr Android: treat WebView like one word for java_cpp_utils
2020-08-10 wnwen Android: Remove unnecessary manifest_package
2020-08-10 boliu aw: Batch AwSettingsTest
2020-08-10 wnwen Android: Allow targets to specify baseline.xml
2020-08-10 benmason Revert "build_vars.txt: Changed to build_vars.json"
2020-08-10 chromium-autoroll Roll Fuchsia SDK from 0.20200810.0.1 to 0.20200810.1.1
2020-08-10 perrier [Android] add language decouple strings
2020-08-10 chromium-autoroll Roll Fuchsia SDK from 0.20200809.3.1 to 0.20200810.0.1
2020-08-09 chromium-autoroll Roll Fuchsia SDK from 0.20200809.1.1 to 0.20200809.3.1
2020-08-09 wychen Handle Unicode characters in adb log in Android tests
2020-08-09 chromium-autoroll Roll Fuchsia SDK from 0.20200809.0.1 to 0.20200809.1.1
2020-08-09 chromium-autoroll Roll Fuchsia SDK from 0.20200808.2.1 to 0.20200809.0.1
2020-08-09 chromium-autoroll Roll Fuchsia SDK from 0.20200808.1.1 to 0.20200808.2.1
2020-08-08 chromium-autoroll Roll Fuchsia SDK from 0.20200808.0.1 to 0.20200808.1.1
2020-08-08 chromium-autoroll Roll Fuchsia SDK from 0.20200807.5.1 to 0.20200808.0.1
2020-08-08 chromium-autoroll Roll Fuchsia SDK from 0.20200807.4.1 to 0.20200807.5.1
2020-08-07 bjoyce Combine two jacoco reports.
2020-08-07 dpranke Remove all remaining references to the jumbo build.
2020-08-07 agrieve build_vars.txt: Changed to build_vars.json
2020-08-07 agrieve Report the value of concurrent_links from "gn gen" when on bots
2020-08-07 chromium-autoroll Roll Fuchsia SDK from 0.20200807.3.1 to 0.20200807.4.1
2020-08-07 agrieve diff_utils.py: Fix typo in URL (expecations)
2020-08-07 agrieve AndroidManifest.xml: Tweak DIFF-ANCHOR computation
2020-08-07 chromium-autoroll Roll Fuchsia SDK from 0.20200806.2.1 to 0.20200807.3.1
2020-08-07 dewittj Exclude empty AndroidManifest.xml from resources in an AAR prebuilt.
2020-08-06 benmason Updating XTBs based on .GRDs from branch master
2020-08-06 chromium-autoroll Roll Fuchsia SDK from 0.20200806.1.1 to 0.20200806.2.1
2020-08-06 titouan Block private network requests from insecure contexts.
2020-08-06 Pavel.Iliin Enable whole-program devirtualization for arm64 Android build.
2020-08-06 chromium-autoroll Roll Fuchsia SDK from 0.20200806.0.1 to 0.20200806.1.1
2020-08-06 chromium-autoroll Roll Fuchsia SDK from 0.20200805.3.1 to 0.20200806.0.1
2020-08-06 mark mac/arm64: Update to Xcode 12b4 (12A8179i)
2020-08-06 bokan [Cleanup] Remove dead SpatialNavigationHost
2020-08-05 chromium-autoroll Roll Fuchsia SDK from 0.20200805.0.1 to 0.20200805.3.1
2020-08-05 liaoyuke [lacros] Use xvfb to run interactive_ui_tests
2020-08-05 sokcevic Use inclusive parameter names in PRESUBMIT.py
2020-08-05 wnwen Android: Clean up baseline.xml for downstream
2020-08-05 chromium-autoroll Roll Fuchsia SDK from 0.20200804.3.1 to 0.20200805.0.1
2020-08-05 chromium-autoroll Roll Fuchsia SDK from 0.20200804.2.1 to 0.20200804.3.1
2020-08-05 cduvall Reland "Move getPacProcessor() to GlueApiHelperForR"
2020-08-05 bjoyce Add option to limit batch sizes.
2020-08-04 chromium-autoroll Roll Fuchsia SDK from 0.20200804.1.1 to 0.20200804.2.1
2020-08-04 dpranke Remove 'dpranke@chromium.org' from OWNERS.
2020-08-04 liaoyuke [lacros] Use new gs location
2020-08-04 steveroe Add chrome-bot ps output to system statistics log.

Roll buildtools/ 613921787..ff93f3ea1 (3 commits)

6139217878..ff93f3ea1a

$ git log 613921787..ff93f3ea1 --date=short --no-merges --format='%ad %ae %s'
2020-08-21 dpranke Roll GN from e327ffdc..6f13aaac and update BUILD files.
2020-08-07 sdefresne Roll GN from 3028c6a4..e327ffdc
2020-08-04 dpranke Remove 'dpranke@chromium.org' from OWNERS.

Roll testing/ dc9b1969e..3a36cd6d9 (198 commits)

dc9b1969e7..3a36cd6d92

$ git log dc9b1969e..3a36cd6d9 --date=short --no-merges --format='%ad %ae %s'
2020-08-24 msisov X11: disable some dnd tests through DISABLED_
2020-08-24 msisov Ozone/Linux: use pangocairo and fix *TrueTypeFont tests
2020-08-24 yuzus [bfcache] Remove SWonUI flag from bfcache bots
2020-08-22 wuwang Enable WPR test again and add to CQ bot android-marshmallow-x86-rel.
2020-08-22 xhwang Revert "[ios] noncq to run tests on 14.0 simulators"
2020-08-21 jeffyoon [ios] noncq to run tests on 14.0 simulators
2020-08-21 kimstephanie mac 11.0 FYI bots src changes
2020-08-21 fdoray [blink scheduler] Add OptOutWebRTCFromAllThrottling to testing config.
2020-08-21 adoneria [updater] LUCI configs for omaha 4 mac builders.
2020-08-21 jeffyoon [ios] remove the xctest arg with enable_unittests_xctest
2020-08-21 msisov X11 and ozone: enable dndozone tests
2020-08-21 toyoshim WebView: remove WebViewOriginCheckForStreamReader experiment
2020-08-21 lindsayw [ios] Remove 12 and 13 coverage from ios14-sdk-sim
2020-08-21 liaoyuke [code coverage] Do not retry invalid shards in coverage build
2020-08-20 zhaoyangli [iOS][infra] Output iOS disabled tests from coverage builder.
2020-08-20 zhaoyangli [iOS][infra] Roll all iOS builders to Xcode 12 beta 5 12a8189h.
2020-08-20 jeffyoon [ios/infra] move xcode-parallelization to testing/buildbot
2020-08-20 ricea Add base::Feature for TransferableStreams
2020-08-20 jeffyoon [ios] ios-simulator-cronet sim sdk from 13.6->13.4
2020-08-20 sreejakshetty [bfcache] Cleanup BackForwardCache test filters
2020-08-20 sreejakshetty [bfcache] Cleanup filtered content_browsertest tests
2020-08-19 dpranke Reland "Rework generated_script handling in MB."
2020-08-19 zhaoyangli [iOS] Append `(1st generation)` to iPhone SE test variant.
2020-08-19 chonggu [Fuchsia] Add maps test suite to Fuchsia FYI bot
2020-08-19 juanmojica Update parameters for shopping experiments in field trial config.
2020-08-19 alexmos Revert "[omnibox] Add tests for dedicated row and pedals a11y"
2020-08-19 svenzheng Enable more gtest pixel tests on fyi bot only
2020-08-19 adoneria [updater] add swarming dimensions for win10 tests.
2020-08-19 zhaoyangli [iOS][infra] Roll all iOS bots to Xcode 12 12a8179i_audio.
2020-08-19 hypan emulator: promote content_browsertests on MM to non-FYI
2020-08-19 olesiamarukhno [omnibox] Add tests for dedicated row and pedals a11y
2020-08-19 sujiezhu Remove AutofillEnableSurfacingServerCardNickname from field trial testing config
2020-08-19 johnchen [Perf] Change android-pixel2-perf to 28 shards
2020-08-19 jeffyoon [ios] ios14 roll to xcode 12 beta 5 12a8189h
2020-08-19 lukasza Enable CorbAllowlistAlsoAppliesToOorCors via fieldtrial...config.json.
2020-08-19 lukasza Remove stale fieldtrial_testing_configs.
2020-08-19 lpz Add support to wpt_metadata_builder for using checked-in wpt metadata.
2020-08-19 justincohen Revert "Rework generated_script handling in MB."
2020-08-19 jiwan Add personal info experiment to field trial config.
2020-08-18 dpranke Add --isolated-outdir flag to test executable API.
2020-08-18 jonahr Enable metal webgl testing on ANGLE/optional/FYI Mac bots
2020-08-18 sinansahin [Offline indicator v2] Add command-line switch to force online state
2020-08-18 liaoyuke [lacros] Move interactive_ui_tests out of experimental
2020-08-18 liaoyuke [lacros] Run interactive_ui_tests on linux-lacros-rel
2020-08-18 pbos Enable SessionCrashedBubbleViewTest.* pixel tests
2020-08-18 liaoyuke [lacros] Disable a few flaky tests and refactor
2020-08-18 dtrainor Updated the reengagement test config.
2020-08-18 fgorski [OSL-RV] Enable Omnibox Suggestions in Recycler View by default
2020-08-18 kimstephanie check_static_initializers should use hermetic xcode paths
2020-08-18 bsheedy Add GPU arm64 Mac builder
(...)
2020-08-10 msisov Ozone: Add --enable-features=UseOzonePlatform to bot variants.
2020-08-08 bpastene Move linux & android bfcache builders to main waterfalls.
2020-08-08 bpastene Mark all Tast and brower-sanity tests as experimental on new arc-r bot.
2020-08-07 isamsonov Remove blink mac10.10/11 configurations.
2020-08-07 svenzheng Get pixel_browser_tests out of experimental
2020-08-07 svenzheng Disable more browser_tests tests for lacros
2020-08-07 toyoshim WebViewOriginCheckForStreamReader: enable it in variation tests
2020-08-07 bpastene Add several basic gtest & integration tests to new eve-arc-r bot.
2020-08-07 isamsonov Remove blink web tests from mac10.10/11.
2020-08-07 svenzheng Disable more browser_tests tests on lacros tester
2020-08-07 domfc Add trial config for WebProtectConnectors
2020-08-07 pmarko Treat PK11_ListCertsInSlot returning nullptr as no certs on slot
2020-08-07 bpastene Remove all experimental tests from android-pie-arm64-rel.
2020-08-07 cthomp Add testing config for iOS legacy TLS interstitial
2020-08-07 isamsonov Remove WebKit Mac10.13 retina configurations.
2020-08-06 svenzheng Enable experiment for browser_tests on lacros tester
2020-08-06 gatong Infra: Renaming mac-arm64 to mac-arm64-rel
2020-08-06 justincohen [ios] Upstream roll Xcode 12 beta 4 (with audio workaround)
2020-08-06 svenzheng Disable more browser_tests for lacros
2020-08-06 ftirelo Revert "Infra: Rename mac-arm64 builder to mac-arm64-rel"
2020-08-06 hans testing/libfuzzer/reproducing.md Fix broken link
2020-08-06 gatong Infra: Rename mac-arm64 builder to mac-arm64-rel
2020-08-06 lizeb Enable ParkableStringsToDisk in fieldtrial_testing_config.json.
2020-08-06 lizeb Enable Background purge on mac in fieldtrial_testing_config.json.
2020-08-06 talp Exclude CrOS from per-agent scheduling experiment.
2020-08-06 svenzheng Enable browser_tests on lacros ci builder
2020-08-06 martiniss Fix mac-arm64 test config
2020-08-05 martiniss Add tests to mac-arm64 builder
2020-08-05 bsheedy Target new Win NVIDIA driver
2020-08-05 rockot Remove sandboxed storage service test suites
2020-08-05 bsheedy Fix and Re-Enable Gold
2020-08-05 sreejakshetty [bfcache] Cleanup and fix content_unittest
2020-08-05 siyua [Nickname Management] Add feature flag to fieldtrial_testing_config
2020-08-05 steveroe Add a cpu x86 dimension to android and android_arm64 resource tests.
2020-08-05 meacer Update field trial config for SafeBrowsing delayed warnings
2020-08-05 tikuta testing: revert whitespace change
2020-08-05 mohsen Reland "Re-add field trial testing config for DisableLatencyRecoveryDesktop"
2020-08-05 ayaelattar Revert "Re-add field trial testing config for DisableLatencyRecoveryDesktop"
2020-08-05 liaoyuke [lacros] Re-enable interactive_ui_tests on linux-lacros
2020-08-05 wenbinzhang [benchmarking] stop running reference build for system_health.common
2020-08-05 pasthana Reland "Bring parity between mac coverage and non-coverage build"
2020-08-05 mohsen Reland "Re-add field trial testing config for DisableLatencyRecoveryDesktop"
2020-08-05 svenzheng Fix linux-lacros-builder-rel compile error
2020-08-05 bpastene Add a test_env.py no-op change to reset swarming's task duplication.
2020-08-05 ynovikov Revert "Shard SwANGLE angle_deqp_egl_tests"
2020-08-05 hypan emulator: Disabld flaky test in StartSurfaceLayoutTest on MM
2020-08-05 hypan emulator: Disable flaky autofill tests on MM
2020-08-04 bsheedy Bypass Skia Gold functionality
2020-08-04 dpranke Remove 'dpranke@chromium.org' from OWNERS.
2020-08-04 aliceywang [Android][Test] Enable AccountPickerBottomSheetTest on MM

Roll third_party/googletest/ e6e2d3b76..1e315c5b1 (25 commits)

e6e2d3b761..1e315c5b1a

$ git log e6e2d3b76..1e315c5b1 --date=short --no-merges --format='%ad %ae %s'
2020-08-20 absl-team Googletest export
2020-08-17 absl-team Googletest export
2020-08-12 krzysio Googletest export
2020-08-12 robert.earhart Export LICENSE
2020-08-11 absl-team Googletest export
2020-08-11 dmauro Googletest export
2020-08-10 absl-team Googletest export
2020-08-05 absl-team Googletest export
2020-08-03 absl-team Googletest export
2020-08-03 absl-team Googletest export
2020-08-05 zumix.cpp fix endif comment
2020-08-03 amatanhead Remove ThrowsMessageHasSubstr and fix some nits after review
2020-07-13 amatanhead Cleanup a bulky expression, document implementation details
2020-07-07 amatanhead Fix build under msvc
2020-07-07 amatanhead Update tests after changing an error message
2020-07-07 amatanhead Fix build under msvc
2020-07-07 amatanhead Add a test to ensure that the `Throws` matcher only invokes its argument once.
2020-07-07 amatanhead Add a test for duplicate catch clauses in throw matchers, fix a couple of nitpicks.
2020-07-03 amatanhead Add missing documentation piece
2020-06-20 amatanhead Small improvements: code style and property name
2020-06-20 amatanhead Add matchers for testing exception properties
2020-08-02 zumix.cpp fix tests
2020-07-29 franciscogthiesen Removing tiny-dnn from "Who is using.."
2020-07-29 zumix.cpp fix GTEST_REMOVE_LEGACY_TEST_CASEAPI_ typo
2018-05-01 lantw44 Avoid using environ on FreeBSD

Roll third_party/spirv-tools/ d9c73ebd9..4dd122392 (39 commits)

d9c73ebd9e..4dd122392f

$ git log d9c73ebd9..4dd122392 --date=short --no-merges --format='%ad %ae %s'
2020-08-21 andreperezmaselco.developer spirv-fuzz: Add words instead of logical operands (#3728)
2020-08-20 dnovillo CCP should mark IR changed if it created new constants. (#3732)
2020-08-19 antonikarp spirv-fuzz: add FuzzerPassAddCompositeInserts (#3606)
2020-08-19 antonikarp spirv-fuzz: Support pointer types in FuzzerPassAddParameters (#3627)
2020-08-18 jaebaek Let ADCE pass check DebugScope (#3703)
2020-08-18 andreperezmaselco.developer spirv-opt: Implement opt::Function::HasEarlyReturn function (#3711)
2020-08-17 andreperezmaselco.developer spirv-fuzz: Check termination instructions when donating modules (#3710)
2020-08-17 jackoalan Fix -Wrange-loop-analysis warning (#3712)
2020-08-17 andreperezmaselco.developer spirv-fuzz: Check header dominance when adding dead block (#3694)
2020-08-16 jaebaek Allow DebugTypeTemplate for Type operand (#3702)
2020-08-14 antonikarp spirv-fuzz: Improve code coverage of tests (#3686)
2020-08-14 stefanomil spirv-fuzz: Fuzzer pass to randomly apply loop preheaders (#3668)
2020-08-14 vasniktel spirv-fuzz: Support identical predecessors in TransformationPropagateInstructionUp (#3689)
2020-08-13 alanbaker Improve non-semantic instruction handling in the optimizer (#3693)
2020-08-13 vasniktel Fix the bug (#3680)
2020-08-12 andreperezmaselco.developer spirv-fuzz: Check integer and float width capabilities (#3670)
2020-08-12 andreperezmaselco.developer spirv-fuzz: consider additional access chain instructions (#3672)
2020-08-12 andreperezmaselco.developer spirv-fuzz: Ignore specialization constants (#3664)
2020-08-12 vasniktel Fix the bug (#3683)
2020-08-12 vasniktel spirv-fuzz: Fix width in FuzzerPassAddEquationInstructions (#3685)
2020-08-12 jaebaek Preserve debug info in dead-insert-elim pass (#3652)
2020-08-12 jaebaek Validate more OpenCL.DebugInfo.100 instructions (#3684)
2020-08-11 alanbaker Only validation locations for appropriate execution models (#3656)
2020-08-11 andreperezmaselco.developer spirv-fuzz: Fix in operand type assertion (#3666)
2020-08-11 andreperezmaselco.developer spirv-opt: Add spvOpcodeIsAccessChain (#3682)
2020-08-11 vasniktel spirv-fuzz: FuzzerPassPropagateInstructionsUp (#3478)
2020-08-10 stevenperron Handle no index access chain in local access chain convert (#3678)
2020-08-10 rharrison Roll 2 dependencies (#3677)
2020-08-10 stevenperron Avoid using /MP4 for clang on windows. (#3662)
2020-08-06 antonikarp spirv-fuzz: TransformationReplaceAddSubMulWithCarryingExtended (#3598)
2020-08-06 andreperezmaselco.developer spirv-fuzz: Add TransformationMakeVectorOperationDynamic (#3597)
2020-08-06 andreperezmaselco.developer spirv-fuzz: iterate over blocks in replace linear algebra pass (#3654)
2020-08-06 stefanomil spirv-fuzz: make outliner pass use additional transformations (#3604)
2020-08-05 jaebaek OpenCL.DebugInfo.100 DebugTypeArray with variable size (#3549)
2020-08-05 andreperezmaselco.developer spirv-opt: Improve the code of the Instruction class (#3610)
2020-08-05 vasniktel spirv-fuzz: Handle OpPhis in livesafe functions (#3642)
2020-08-05 vasniktel spirv-fuzz: Handle OpPhi during constant obfuscation (#3640)
2020-08-05 vasniktel spirv-fuzz: Fix FuzzerPassCopyObjects (#3638)
2020-08-04 vasniktel spirv-fuzz: Remove OpFunctionCall operands in correct order (#3630)

Roll tools/clang/ 1078c4141..9784c4f72 (15 commits)

1078c4141a..9784c4f72a

$ git log 1078c4141..9784c4f72 --date=short --no-merges --format='%ad %ae %s'
2020-08-21 lukasza CheckedPtr rewriter: Skip fields resulting in global destructors.
2020-08-21 karelkral Implement a tool to annotate methods with tracing
2020-08-20 aeubanks Roll clang llvmorg-12-init-1771-g1bd7046e-5 : llvmorg-12-init-3492-ga1caa302-1.
2020-08-18 aeubanks Move file modification to after branch checkout
2020-08-16 sidereal remove copybara initialization artifacts
2020-08-16 sidereal Copybara Service Migration Initialization.
2020-08-16 sidereal Revert "Roll clang llvmorg-12-init-1771-g1bd7046e-5 : llvmorg-12-init-3132-g95fad44e-1."
2020-08-16 aeubanks Roll clang llvmorg-12-init-1771-g1bd7046e-5 : llvmorg-12-init-3132-g95fad44e-1.
2020-08-14 aeubanks Build Clang with ThinLTO on Linux
2020-08-10 karelkral Fix empty_string tool
2020-08-09 lukasza Generalize path exclusions by supporting --exclude-paths parameter.
2020-08-07 aeubanks Fix upload_revision.py
2020-08-06 aeubanks Use `git description` as CLANG_REVISION, remove references to SVN
2020-08-06 akhuang Set ENABLE_X86_RELAX_RELOCATIONS=NO in clang build script.
2020-08-05 hans Clang build.py: Verify zlib support after building

Created with:
  roll-dep build buildtools testing third_party/googletest third_party/gpuweb-cts third_party/spirv-headers third_party/spirv-tools tools/clang

Change-Id: I5bf8624e6390c4a8899fe8d5ab856c3f5d247344
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27282
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-24 17:28:37 +00:00
Sarah Mashayekhi f70065f622 [validation] Validate if entry point functions accept parameters
Bug: tint: 6
Change-Id: I7e9f50759e65ed6ef3dc25a6c004bec3dfbd4648
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27122
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-24 16:03:36 +00:00
Sarah Mashayekhi c3038ddfa6 [validation] Adds disable test for v-0023, entry point functions accept no params
Bug: tint: 6
Change-Id: I7ea874e90f4dbd213ff35275823342027340e348
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27121
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-24 15:00:46 +00:00
Tomek Ponitka 43c2a6c7d4 [wgsl-reader] Adding body_statement to statement grammar
Block statements will now be parsed in ParserImpl::statement()

Change-Id: I28f63d4a53c85c0306c57df545f78b4562c6ea7b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27262
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2020-08-24 13:43:16 +00:00
Corentin Wallez 04f5166ac1 Fix triangle.wgsl's floating point literals.
Bug: None
Change-Id: I76a4df338e6354915844822ac1d40cece10ac9e0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27241
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-24 13:04:36 +00:00
David Neto c189b1d479 Re-enable float emission tests
Test a value that should stably convert to decimal exponent
representation.  This might be working around a bug in the MSVC runtime
library.

Bug: tint:201
Change-Id: I37200cef815cafc35284c8c873dfbb8a5312360e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27160
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2020-08-21 21:19:33 +00:00
Sarah Mashayekhi e871e48df0 [validation] validate if entry point functions return void
This CL validates following validation rule:
v-0024: Entry point functions return void

Bug: tint: 6
Change-Id: I420781008016af110cb0d3d65fc018a1301efeae
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27120
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-21 15:40:43 +00:00
Sarah Mashayekhi 1026fe3d27 [validation] Add disabled test for v-0024-entry point functions return void
Bug: tint: 6
Change-Id: Iae865125b30952a9422261fbfe14e9b6fb74e16f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27101
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-20 21:51:39 +00:00
Sarah Mashayekhi 3c9fee13b9 [validation] checks if function used in entry point exists
This CL check validation rule v-0019: Functions used in entry points must exist.

Bug: tint: 6
Change-Id: Ic4d4702cac53dcdaa1207425a6214d53cacb2442
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27100
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-20 21:25:39 +00:00
Sarah Mashayekhi 255cfe829f [validation] Add disabled test for v-0019-entry point functions must exist
Bug: tint: 6
Change-Id: I303fab6e0cd4a807173bef8f69e14220480fbb9a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27080
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-20 20:52:29 +00:00
Sarah Mashayekhi 8db00dffa2 [validation] Checks if recursions exist
This CL validates the following rule. ie. As functions must be defined before use (v-0005), self-recursion is only case that has to be invalidated.
v-0004: Recursions are not allowed.

Bug: tint: 6
Change-Id: Icfb040907c5ea0abb6359dade74dcfc30a0db7d9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26980
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-20 17:00:09 +00:00
dan sinclair d38df397e3 [hlsl-writer] Add support for import statements.
This Cl adds support for imported methods to the HLSL backend.

Bug: tint:7
Change-Id: Ib906542915670dcc916d48d9e5d64d7032ba829a
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26928
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 19:19:04 +00:00
dan sinclair a1087ee513 [hlsl-writer] Generate intrinsics.
This CL adds the beginning of intrinsic emission for the HLSL backend.
The `outer_product`, `is_normal` and `select` intrinsics are currently
missing.

Bug: tint:7
Change-Id: Ice7a2b285eeb52041e3accd9751e127d6c5a0177
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26927
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 19:17:54 +00:00
dan sinclair 3739a23f24 [hlsl-writer] Emit cast expressions.
This CL adds support for cast expressions to the HLSL backend.

Bug: tint:7
Change-Id: Ie7e180dc89abf137ab7d9b8790cc4206b3d5a672
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26926
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 19:14:44 +00:00
dan sinclair 10585f0ac3 [hlsl-writer] Add tests for entry point data.
This CL adds the missing tests for emission of Entry Point Data
structures.

Bug: tint:7
Change-Id: If21071b07584780243ccd0629a92efa653640251
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26925
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 19:04:54 +00:00
dan sinclair 6fdc77a966 [hlsl-writer] Emit module constants.
This CL adds emission of module constants to the HLSL backend.

Bug: tint:7
Change-Id: Iff07b0c0de7351f400dc35ca2ac07b44b22f8499
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26924
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 19:03:24 +00:00
dan sinclair 1811639709 [hlsl-writer] Fix emission of struct aliases.
You can only typedef builtin types in HLSL. This Cl updates the struct
emission to emit named structs instead of typedef'd structs.

Bug: tint:7
Change-Id: I835b7f4d23bc225c730ef3f39c4572c043a58156
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26921
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 19:00:21 +00:00
dan sinclair bfaa6f8e57 [hlsl-writer] Emit uniform variables.
This CL adds emission of uniform storage class variables to the HLSL
backend. If the variable is a base type (float, int, etc) it is emitted
as a `cbuffer`. If the variable is a struct it will emit as a
`ConstantBuffer`.

Bug: tint:7
Change-Id: I9932d30df24c023c58d3a2ba4167bcb7ccb85dae
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26920
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 18:57:09 +00:00
dan sinclair 7df4a845d9 [hlsl-writer] Add CallExpression.
This Cl adds support for call expressions into the HLSL backend.

Bug: tint:7
Change-Id: Id07e3d95e745aa016a658c3ec5d099f74f21a80e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26781
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
2020-08-19 17:44:45 +00:00
dan sinclair 34fd95ced0 [hlsl-writer] Add support for input locations and builtins.
This CL adds the beginning of support for input/output locations and
builtins in the HLSL backend.

Bug: tint:7
Change-Id: I8fb01707b50635a800b0d7317cf4a8f62f12cfca
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26780
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: David Neto <dneto@google.com>
2020-08-19 17:37:25 +00:00
dan sinclair be89a06b03 [hlsl-writer] Add function handling.
This CL adds the beginning of function handling to the HLSL generator.

Bug: tint:7
Change-Id: Id40109c342e7a128b1fe79a0c50967e1dbd125eb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26662
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: David Neto <dneto@google.com>
2020-08-19 17:32:25 +00:00
dan sinclair 94a374fa84 Add missing block decoration.
The uniform buffer in the test/cube.wgsl needs a block attribute in
order to translate correct.

Change-Id: I2a245cffbe9f4c66b9d6ebcd66617a7fbdd98af2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26922
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
2020-08-18 16:08:43 +00:00
Sarah Mashayekhi 844f632785 [type-determiner] return false when type determining an undeclared function
Change-Id: Ia7e43be64675528037f92026a6c239d1e5220fc0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26941
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-18 02:10:03 +00:00
Sarah Mashayekhi 8fcf269d4b [validation] Add Disabled test for detecting recursion
This CL adds a disabled test for validating following rule:
v-0004: Recursion is not allowed

Bug: tint: 6
Change-Id: I35d51b08174ac23a4b1def9f762e80c5950a726d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26942
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-17 21:01:28 +00:00
dan sinclair dd99471420 [spirv-writer] Output name for constant global variables.
When emitting a global constant we'd early exit the emission code before
emitting the debug statement for the constants name. This Cl adds the
needed code to emit names for global constants.

Change-Id: I1a7a3660b4ff31879393a6a776a9f00e895de216
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26923
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2020-08-17 20:00:48 +00:00
Sarah Mashayekhi b08e253886 [validation] Validates if return statement type matches function return type
This CL checks if the return statement type matches the function return type

Bug: tint 6
Change-Id: I621d67086291c392b68261673a25c0e6caca71ae
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26860
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-17 15:46:07 +00:00
Sarah Mashayekhi eec1a6e628 [validation] Validates function name uniqueness
This CL implements and add a test for the following validation rule:
v-0016: Function names must be unique

Bug: tint: 6
Change-Id: I9f135dd577863e41f03a2d02adebe4347a9922eb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26782
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-08-17 15:32:38 +00:00