Commit Graph

5 Commits

Author SHA1 Message Date
Vadim Shtayura 12e51f6efa Declare "role/configs.validator" binding.
It defines who is allowed to call LUCI Config validation API to
validate this LUCI project's configs. This is usually done by
presubmit jobs, and thus configs.validator role is assigned to
try job task accounts.

Previously this ACL was defined in the global "config-validation"
group. It is deprecated and being replaced with per-project ACLs
defined in per-project configs (like in this CL).

There's still a global ACL to allow any googler to call
the validation API in any LUCI project they are allowed to see.
Thus the per-project binding applies only to service accounts
(they are not googlers).

Note: this CL was generated semi-automatically and reviewers are
picked automatically based on OWNERS file.

BUG=chromium:1068817

Change-Id: I57dec27982676553e40ad5dbae2b4642bb3bc935
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/69180
Auto-Submit: Vadim Shtayura <vadimsh@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2021-11-13 17:53:14 +00:00
Corentin Wallez 2f8a68ce21 Infra: Use Python 3 for the Dawn recipe.
Bug: chromium:1256411
Change-Id: Iab6cf738a2a25cd15006bbc9291328ca74357179
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67820
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2021-10-29 09:07:43 +00:00
Ryan Harrison cac1d35f71 Add Starlark based configs to Dawn
This does no remove the existing configs, since there is a chrome
infrastructure change that needs to occur to point LUCI at the new
configs.

BUG=dawn:734

Change-Id: I33608165d27be2d61eff5ff7155386df84379fa3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53181
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2021-06-03 19:34:01 +00:00
Ryan Harrison ed47190729 Revert "Convert Dawn to use Starlark script to generate configs"
This reverts commit fec575ca7b.

Reason for revert: Need to change external configs before removing old *.cfg files

Original change's description:
> Convert Dawn to use Starlark script to generate configs
>
> BUG=dawn:734
>
> Change-Id: I293d04a7b585f5ffd6e91813607ff20b1935af58
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/52981
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

TBR=cwallez@chromium.org,enga@chromium.org,rharrison@chromium.org,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I4321b1caa2a1137a8f4f9fcaa3ffd88b690345a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:734
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53260
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2021-06-03 18:48:27 +00:00
Ryan Harrison fec575ca7b Convert Dawn to use Starlark script to generate configs
BUG=dawn:734

Change-Id: I293d04a7b585f5ffd6e91813607ff20b1935af58
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/52981
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2021-06-03 18:13:17 +00:00