66fbd2c1ec
Roll ANGLE from 0d5ba4dc4c0b to 6b248a6886ad (2 revisions)
...
0d5ba4dc4c..6b248a6886penghuang@chromium.org Use angle::FastVector in ImageEGL::initialize to avoid heap allocation
2022-08-06 penghuang@chromium.org Remove not used mImageLastUseFences in ImageVk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Idf583d3dc4dad4529a4b14ebd987b0476f514ac4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98443
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-07 04:38:59 +00:00
e06266e0e0
Roll ANGLE from 928c5016b64d to 0d5ba4dc4c0b (1 revision)
...
928c5016b6..0d5ba4dc4cpenghuang@chromium.org Minor performance improvement
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Ib9b7cd2427ab25850ec1c4d05e7fd17476ec2d45
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98442
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-06 15:01:58 +00:00
8c60a92d5c
Roll vulkan-deps from a8e1c32b6111 to 4b211a6a98e6 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/a8e1c32b6111..4b211a6a98e6
Changed dependencies:
* vulkan-headers: 2b55157592..c896e2f92043b340ca57..eb7156a963https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: If2498c71ee69008ba998c131581f305cd4838eca
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98441
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-06 11:07:38 +00:00
4b9ebb1465
D3D12: Workaround buffer-texture copy with depth-stencil on some platforms
...
On the D3D12 platforms that don't support programmable sample positions,
the source box specifying a portion of the depth texture must all be 0, or
an error and a device lost will occur. This patch adds a workaround for this
issue by splitting the original buffer-texture copy into two copies:
1. copy from the source resource into a temporary buffer at offset 0
2. copy from the temporary buffer at offset 0 into the destination resource.
In the next patch we will fix the corresponding issue in Queue.WriteTexture.
Note that on newer version of D3D12 the restrictions about
D3D12_TEXTURE_DATA_PLACEMENT_ALIGNMENT and D3D12_TEXTURE_DATA_PITCH_ALIGNMENT
have all been lifted out, so the workaround added in this patch will also be
disabled on the platforms that don't support programmable sample positions
but the restrictions about D3D12_TEXTURE_DATA_PLACEMENT_ALIGNMENT and
D3D12_TEXTURE_DATA_PITCH_ALIGNMENT are no longer available.
Bug: dawn:727
Test: dawn_end2end_test
Change-Id: I9f1d848a0eeac5bd52c9219af6992a2821307746
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97182
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-06 04:36:08 +00:00
40647c72af
Roll ANGLE from dbfab1595b8a to 928c5016b64d (6 revisions)
...
dbfab1595b..928c5016b6syoussefi@chromium.org Vulkan: Fix garbage collection vs outside-RP-only flush
2022-08-05 syoussefi@chromium.org Test for ARM bug with dynamic stencil write mask
2022-08-05 jmadill@chromium.org run_perf_tests: Allow passing flags to the test.
2022-08-05 romanl@google.com Add a note about "internal swarming failure"
2022-08-05 ffz@google.com Add Variable Initialization in Base Instance Tests
2022-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a443029375b to fa6a3bcb6169 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I23b5b4d0847ec97a9b0fc020f57ad0489809d5f7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98460
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-06 01:08:29 +00:00
601d3c5f2a
Roll SwiftShader from eedcf55ec853 to ed9d5ae1e79c (3 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/eedcf55ec853..ed9d5ae1e79c
2022-08-05 sugoi@google.com Temporarily allow unsupported structures in PhysicalDevice::getFeatures2()
2022-08-05 sugoi@google.com Workaround for dEQP-VK.info.device_mandatory_features failure
2022-08-05 sugoi@google.com Workaround vkGetPhysicalDeviceProperties2() issue
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I2b17d7f977f6042b3f5653f856ff30f9f2eb6cdc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98440
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-06 00:16:18 +00:00
b8710f5ce3
Roll vulkan-deps from fa6a3bcb6169 to a8e1c32b6111 (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/fa6a3bcb6169..a8e1c32b6111
Changed dependencies:
* vulkan-validation-layers: 07851b8a0c..43b340ca57https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Iffefbcf056872fc45be266739cfbe859b1f61cc0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98400
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-05 22:09:47 +00:00
a0df1384f2
Cache WGSL -> DXBC/DXIL compilation
...
Bug: dawn:1480
Change-Id: I858111f62be457c2e7cd5017bbf4c10e76395e83
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95340
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-05 20:09:07 +00:00
9443cebd53
tint: End-to-end tests for f16 built-in
...
This patch add Tint end-to-end tests for built-ins using f16 types.
Bug: tint:1473, tint:1502
Change-Id: I09db6e0b7e90541fb246e11d475e27be96a6d07e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97340
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
2022-08-05 15:15:17 +00:00
20cddbf04c
tint: Implement modf and frexp built-ins for f16 types
...
This patch implement modf and frexp built-ins for f16 types, and also
simplify their implementation for f32 in MSL and HLSL, and clean up
deprecated code in GLSL writer. Corresponding unittests are also
implemented, but end-to-end tests for f16 are not implemented yet.
Bug: tint:1473, tint:1502
Change-Id: I12887ae5303c6dc032a51f619e1afeb19b4603b6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98102
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-08-05 15:11:44 +00:00
1cd4706f85
Sync the `statement` grammar element.
...
This CL updates a few names in the statement element to match the
spec. The `body_stmt` is now `compound_statement`.
Bug: tint:1633
Change-Id: I23a622fc8587641d3b6c5ff2641f29a3471fa4e1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98280
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-08-05 14:53:47 +00:00
7d8307122e
Cleanup some strings; Reorder `attribute` rule.
...
This CL inlines some strings which were listed at the top of the
parser. In general, we've inlined the strings there were just a few
which ended up being declared at the top of file.
The `attribute` rule is re-ordered to sort the attributes in
alphabetical order so they're easier to locate.
The `expect_storage_class` rule is renamed `expect_address_space`
Bug: tint:1633
Change-Id: Ie659742b9758142b6971493be6d0d62a092999b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98262
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-08-05 14:47:57 +00:00
e29b4000ae
Roll ANGLE from de5c6c791fa0 to dbfab1595b8a (1 revision)
...
de5c6c791f..dbfab1595bangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d7560fcbdf63 to 2bf3e35d7a4c (416 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I433600d3496e767de3458e5dd4afb953bcbe8686
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98381
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-05 12:14:30 +00:00
127288b742
Roll SwiftShader from dcaef10ef0ad to eedcf55ec853 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/dcaef10ef0ad..eedcf55ec853
2022-08-04 sugoi@google.com Update Vulkan headers to version 1.3.224
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I89516b6172a5ddb497fe8b35b430ec2714fc50f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98380
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-05 11:14:19 +00:00
9cfa216c7f
Roll vulkan-deps from 70d9544c1454 to fa6a3bcb6169 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/70d9544c1454..fa6a3bcb6169
Changed dependencies:
* vulkan-loader: d4801c93c5..a0ab2f162e8ac3b50e9d..497f23268009fbe8a479..07851b8a0chttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Ia7d822e05174348f4278126f18bcb73a02660519
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98340
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-05 08:45:27 +00:00
73ecc66e47
Roll ANGLE from e6fcb2a9a9a4 to de5c6c791fa0 (3 revisions)
...
e6fcb2a9a9..de5c6c791fjonahr@google.com Remove unused ANGLE histograms
2022-08-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3ee9789f25ed to 3a443029375b (8 revisions)
2022-08-04 chris@rive.app Make PLS coherent on desktop OpenGL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: If214885f44fd4abc79cd499e9f77e254f78945a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98320
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-04 22:41:36 +00:00
a8bae0fc04
Roll SwiftShader from a07b3fb6b3bd to dcaef10ef0ad (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/a07b3fb6b3bd..dcaef10ef0ad
2022-08-04 sugoi@google.com Fix VulkanWrapper compilation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Idf5f59850f874d42ac87e3aa71a12779fe0f7da7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98300
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-04 22:16:37 +00:00
69a9415084
Extract interpolation sample and type name parsing
...
This CL pulls the interpolation sample and type name parsing out
to methods to closer match the WGSL spec. This will also make it simpler
to convert to using generated parsing for these strings if desired.
Bug: tint:1633
Change-Id: Ib7b663a3eeef7f3ecacae8bf160d41641b5474f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98260
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-04 21:21:37 +00:00
737fd8223e
Add `expression` into the WGSL parser.
...
The parser skipped over the `expression` node and went straight
to `logical_or_expression`. This CL adds `expression` which just
calls `logical_or_expression`. This will allow moving the rest of the
parser to more closely match the WGSL spec.
Bug: tint:1633
Change-Id: I994a186ea50f3b3196c9ded77d9c478cb08b019b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98220
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-04 21:06:07 +00:00
cd0622c823
Roll vulkan-deps from e76913f77204 to 70d9544c1454 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/e76913f77204..70d9544c1454
Changed dependencies:
* spirv-tools: 08c542d344..b362d2b7d4ff92049ebd..2b551575923a10ae8223..09fbe8a479https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Ic600dfaf4ebd3577ade4b214c05a1bf880ce9da4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98201
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-04 19:51:56 +00:00
7e9f571814
tint: const eval of binary add
...
Bug: tint:1581
Change-Id: Ie34ee52bdd4a4c5d45a5f6c0d8d923cc690c8b2c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98021
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-04 19:48:27 +00:00
b8893b4c2f
Sync the `global_decl` grammar rule
...
This Cl updates the parser implementation of the `global_decl` rule.
The `type_alias` rule is renamed to `type_alias_decl` and the `struct`
parsing is moved out of the synchronization to `;` code as a `struct`
no longer has a trailling `;`.
Bug: tint:1633
Change-Id: I44b25035cbe0ea0963ec73400986205e1623060e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98065
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-04 17:57:26 +00:00
c2a052eaa4
tint: Allow ConstEval functions to fail
...
They now return a utils::Result so they can add an error to diagnostics
and return Failure. Returning nullptr still means cannot evaluate at
compile time, but not a failure.
Bug: tint:1581
Change-Id: Ic30d782fb9fa725ec2faf89a87f74de6282d0304
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98107
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-04 13:59:36 +00:00
6091d838a7
Roll ANGLE from 00a9787e3242 to e6fcb2a9a9a4 (8 revisions)
...
00a9787e32..e6fcb2a9a9angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 54b1e2bc5d71 to d7560fcbdf63 (301 revisions)
2022-08-04 penghuang@chromium.org Protect ImageState::targets with a std::mutex
2022-08-04 jmadill@chromium.org dEQP: Fix X11 display config name.
2022-08-03 eddiehatfield@google.com Get desktop GL conformance tests to build
2022-08-03 kbr@chromium.org (Reland) [Metal] Disable ANGLE's Metal backend on older GPUs.
2022-08-03 boliu@google.com Make limit_max_texture_size_to_4096 webgl only
2022-08-03 romanl@google.com Use globals in android_helper to simplify flow.
2022-08-03 hailinzhang@google.com Vulkan: fix default msaa framebuffer resolve issue.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: Iac170b76dfc1179e9acb9f8c12b75bc4b2c71e2a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98180
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-04 09:45:16 +00:00
c20fa4eae5
Triage some entries in expectations.txt
...
Change-Id: I51db1f499db3037a0ff572434efd141610dd0542
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98066
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-08-04 03:39:07 +00:00
5574521a42
Roll vulkan-deps from 3ee9789f25ed to e76913f77204 (7 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/3ee9789f25ed..e76913f77204
Changed dependencies:
* glslang: fb64704060..adf7bf011354cd5e1963..08c542d344aa7ee26f15..3a10ae8223https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I245488f35bf5a3e5ee881ae76d7dc68474881b94
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98160
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-04 03:25:06 +00:00
0671fe28bf
Cache WGSL -> MSL compilation
...
Bug: dawn:1480
Change-Id: Ie2ef7860b38d7f350c99cf2c5451299b23413ec6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97882
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
2022-08-04 01:12:56 +00:00
e40bd8e964
Suppresses failing CTS tests for tint:1632
...
Bug: tint:1632
Change-Id: Ic21ce0e401a4af2f7b3aebc6d1823fad7e3b9643
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98067
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-03 22:06:36 +00:00
50bddbffca
tint: Fix dxc on Linux
...
Fixes "dxc failed : unable to parse shader model.".
On windows the called program is responsible for splitting arguments
from one joined string. Command line arguments on 'nix systems need to
be passed as separate strings. This CL makes it so that we pass in the
arg separately, and support ignoring empty string args to make writing
this code easier.
Change-Id: Ia9618c2a743f8fdb49913572e2bbfc4bd1519d3a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98110
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-03 21:40:46 +00:00
50940aeef1
tint: add CheckedAdd AFloat overload
...
Bug: tint:1581
Change-Id: I3d346a5ced345dbd720cce3404b4a0a402e71838
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98106
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-03 21:20:26 +00:00
7692f3a5e2
Roll ANGLE from 05d86e06003b to 00a9787e3242 (8 revisions)
...
05d86e0600..00a9787e32angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fe6c14e1fc75 to 54b1e2bc5d71 (162 revisions)
2022-08-03 ianelliott@google.com Roll VMA to version 3.0.1 + Google patches
2022-08-03 romanl@google.com Ignore all .gclient* files.
2022-08-03 jmadill@chromium.org Revert "Skip multi draw indirect tests on Linux/Intel/Vulkan."
2022-08-03 jmadill@chromium.org Retry flaky failures on SwiftShader *SAN builds.
2022-08-03 romanl@google.com Fix local gold runs broken by previous refactoring.
2022-08-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9501e63393f3 to 3ee9789f25ed (3 revisions)
2022-08-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0920d63e6fcc to fe6c14e1fc75 (234 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I3404c2f5e1e680a3e9f85e13f3e65bf534c5882a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98109
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-03 20:48:36 +00:00
3c797eba3b
Add tests about clearing with big integer values
...
This patch adds several dawn_end2end_tests as a preparation to support
clearing color attachments with arbitrary 32-bit integer values on
D3D12.
Bug: dawn:537
Test: dawn_end2end_tests
Change-Id: I5e5232d4ebb2ed0e0da007fea101ed13f972ce9e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98103
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-03 15:54:35 +00:00
0e141c2d86
Add reserved words to the origin trial changes.
...
This CL updates the origin trial changes list to include the
deprecation of reserved words.
Bug: tint: 1463
Change-Id: I70aef6cdd68573413878d595928a7d92b40a275c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98064
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-03 14:34:16 +00:00
78a28459ab
Roll vulkan-deps from c9c304a87f47 to 3ee9789f25ed (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/c9c304a87f47..3ee9789f25ed
Changed dependencies:
* glslang: f0ce653a25..fb64704060https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I21e5cbf6f1fa1b522f78820d078da2e93920859d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98105
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-03 14:01:25 +00:00
f7953083e1
docs/tint: Documented addition of 'static_assert'
...
Bug: tint:1625
Change-Id: I20c51bd137796ea03e0085d69d46181e243970e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97964
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-03 12:12:25 +00:00
f3015a81cc
tint/reader: Parse static_assert
...
Bug: tint:1625
Change-Id: I440de9a5f0f6817520d59d0d918acc6ac0555c42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97963
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-03 10:08:46 +00:00
fc013af417
Roll SwiftShader from 0296680c782c to a07b3fb6b3bd (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/0296680c782c..a07b3fb6b3bd
2022-08-02 capn@google.com Support AddressSanitizer instrumentation of LLVM JIT routines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I7e721266f8a964459e1c3cdb94279d280290cc48
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98101
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-03 09:49:45 +00:00
52f852fa28
test/tint: Regenerate SKIP expectations
...
`./test/tint/test-all.sh ./out/active/tint --generate-skip`
A bunch of these got missed by https://dawn-review.googlesource.com/c/dawn/+/98020 , as I assumed only `glsl` and `spvasm` backends would be affected.
Some are just refreshes of existing skips
Bug: tint:1632
Change-Id: I1b003a56143b52e8e47bef8a10fec2878a48be06
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98120
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-03 09:47:48 +00:00
7d7976d590
tint: Add end-to-end tests for expressions using f16 types
...
This patch add DXC compile flag "-enable-16bit-types" and change profile
to SM6.2 when validating generated HLSL using DXC if f16 extension is
enabled in the WGSL program.
The patch add Tint end-to-end test cases for expressions using f16 type,
including constructor, binary operator, splat, zero-init, and others.
Testcases that use f16 types in uniform or storage buffer are SKIPped,
because such usage is not implemented yet.
Bug: tint:1473, tint:1502
Change-Id: I481ab3d12cbb822f11ef85ba807bca3f9770089b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96252
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@chromium.org>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
2022-08-03 08:45:25 +00:00
7d04cedce3
tint/resolver: Pre-allocate containers
...
Reserve the memory for the dependency graph containers.
Reduces expensive heap allocations.
Change-Id: Ia650fcb9f9e461afb8b240c9472a9a478a9968d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98081
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-03 08:43:15 +00:00
6d66921053
tint/resolver: Reduce small-vector sizes
...
The vector sizes for expression traversal were excessive.
Reduce.
Change-Id: I3a2b7e7ba4cd82310565b883f85322834275ea8a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98082
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-03 08:00:15 +00:00
04e68a7032
Roll ANGLE from 6e6f3e6da27c to 05d86e06003b (9 revisions)
...
6e6f3e6da2..05d86e0600romanl@google.com Add temporary logging of gold_session.Initialize stdout.
2022-08-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d268b4c8a6b1 to 0920d63e6fcc (256 revisions)
2022-08-02 jmadill@chromium.org Skip multi draw indirect tests on Linux/Intel/Vulkan.
2022-08-02 romanl@google.com Refactoring: move a few common functions to angle_test_util.
2022-08-02 cnorthrop@google.com Tests: Add Octopath Traveler trace
2022-08-02 jmadill@chromium.org Skip TimerQueriesTest flakes on NV/Linux.
2022-08-02 jmadill@chromium.org Skip flaky tests on Linux/Vulkan.
2022-08-02 jmadill@chromium.org Skip flaky image load/store tests on Win/D3D11.
2022-08-02 jmadill@chromium.org Skip flaky test on SwiftShader.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I41d9df0eb65a6679d23781af0868da6c2f818ed0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98100
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-03 07:11:35 +00:00
b4744ac359
tint/writer: Handle static_asserts
...
These (with exception to the WGSL writer) are not emitted.
Bug: tint:1625
Change-Id: Id8b36b5c83a6fe2dab042cf46b0c3dbca75e0926
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97962
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-03 07:01:08 +00:00
759ac33cd1
tint/resolver: Optimize intrinsic lookups
...
Replace use of std::unordered_map with a utils::Vector.
Significantly reduces heap allocations.
Change-Id: I501bfffb7620df9b4e09cd8569c39e418b25e32a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98080
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-03 06:55:57 +00:00
6f8d945dd6
Sync reserved token list to WGSL spec.
...
This CL updates the list of reserved words to match the WGSL spec. The
use of a reserved word is changed from an error to a deprecation at the
moment be cause the majority of the list would be new errors.
Bug: tint:1633 tint:1624
Change-Id: I498db41689cdd666dfb291b1a6761a1182c87ec8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98042
Reviewed-by: David Neto <dneto@google.com>
Reviewed-by: Ben Clayton <bclayton@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-03 02:49:28 +00:00
cc5dc15304
Roll vulkan-deps from 2d409ca4e3b6 to c9c304a87f47 (17 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/2d409ca4e3b6..c9c304a87f47
Changed dependencies:
* spirv-tools: 8dc0030ecb..54cd5e19630bcddf345f..d4801c93c5e734be0bb5..8ac3b50e9dcbdb019150..aa7ee26f15https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC lokokung@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: lokokung@google.com
Change-Id: I16e313e655236f9f02255582db4da08a13f4e304
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98023
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-03 00:52:05 +00:00
16ee6f8566
Suppresses failing tests due to tint:1632.
...
Bug: tint:1632
Change-Id: I432cc08d5a7f9e47bcd5381e144a7d8195d3e45e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98062
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Loko Kung <lokokung@google.com>
2022-08-02 23:35:45 +00:00
02791e95f3
tint/resolver: Resolve static_assert
...
No readers produce this, yet.
Bug: tint:1625
Change-Id: I94ce3e5afd7bd81b0a5059451136aa0eed7e9283
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97961
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-02 23:28:28 +00:00
bfd1a81364
tint/ast: Add StaticAssert node
...
Nothing uses this, yet.
Bug: tint:1625
Change-Id: I93aa21d2a8090bebbbfbbe3dba7d60818a0e3a5c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97960
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-02 23:16:25 +00:00
462f648896
Make adapter info device matching more flexible
...
Previously all of the device IDs I was aware of for a given vendor could
be comfortably filtered with a single mask, but there's at least one
exception that has come up since that indicates that support for
multiple different masks per vendor is necessary.
This change allows devices to be identified in groups, with each group
being given a different mask or no mask at all. Architectures may be
shared between groups.
Also added the ability to mark a device group as internal, which will
generate the helper functions (like `IsVendorArchitecture()`) for the
internal architectures but not allow them to be exposed in
GPUAdapterInfo. Internal device IDs may overlap with non-internal ones.
Finally, added some validation logic to prevent duplicate deviceIds or
conflicts between device sets/architectures. This was actually supposed
to be in an earlier CL but somehow got omitted from the version that
eventually landed.
Bug: dawn:1498
Change-Id: Icb8bfbee47324cbd9791f63089877ace86c763db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96900
Reviewed-by: Yunchao He <yunchao.he@intel.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2022-08-02 22:14:35 +00:00
Dawn Autoroller
Jiawei Shao
Austin Eng
Zhaoming Jiang
dan sinclair
Antonio Maiorano
Loko Kung
Ben Clayton
Brandon Jones