821f9bb525
FXC fails to compile when it determines that the rhs of an integral division is zero with "error X4010: Unsigned integer divide by zero". bclayton's fix (https://dawn-review.googlesource.com/c/tint/+/60500) addressed cases for division by an integer constant 0. This CL adds the missing support for division by integral vectors with 0 components. FXC also fails on division by integral expressions that it can fold to 0. To handle these cases, we now emit a runtime check for 0 and replace by 1. In the cases I've tested, FXC seems able to optimize these checks away. Bug: tint:1083 Change-Id: I02f08e9077882f03c1e42b62dacb742a48fa48ba Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/73580 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> |
||
---|---|---|
.. | ||
scalar-scalar | ||
scalar-vec3 | ||
vec3-scalar | ||
vec3-vec3 |