encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/tint/vk-gl-cts/spirv_assembly/instruction
History
Stephen White 66abf3ed14 GLSL: don't emit structs w/runtime-sized arrays. 
In GLSL, runtime-sized arrays are only valid in interface blocks, not
in structs. The existing code was attempting to avoid emitting structs
containing runtime-sized arrays but was confused by type aliases in
the AST resulting in arrays being missed.

The fix is to do the work on the semantic types instead, where type
aliases have been resolved.

Bug: tint:1339
Change-Id: I8c305ee9bddd75f975dd13f1d19d623d71410693
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/82360
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
 		2022-03-02 14:09:22 +00:00
..
compute GLSL: don't emit structs w/runtime-sized arrays. 2022-03-02 14:09:22 +00:00
float32/comparison/frexpstruct_1_frag tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
graphics tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
spirv1p4/hlsl_functionality1/decorate_string tint->dawn: Shuffle source tree in preperation of merging repos 2022-02-21 15:19:07 +00:00
terminate_invocation GLSL: don't emit structs w/runtime-sized arrays. 2022-03-02 14:09:22 +00:00