mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-13 10:51:35 +00:00
Despite `tint::ast::type::Type` being in the AST namespace, these classes are clearly not AST nodes: * They don't derive from ast::Node * They're deduplicated by the type manager * None of the types have an Source - they have no lexical declaration point * The fact we have `ast::Struct` and `ast::type::Struct` clearly demonstrates what is an AST node, and what is a type. * We have code scattered in the codebase (TypeDeterminer, writers, etc) that create new types after parsing - so clearly not part of the original syntax tree. Types in tint are closer to being semantic info, but due to the parse-time generation of types, and tight dependency of ast::Nodes to types, I'd be reluctant to class these as semantic info. Instead, put these into a separate root level `tint::type` namespace and `src/tint` directory. The fact that types exist in the ast::Module has already caused bugs (https://dawn-review.googlesource.com/c/tint/+/37261). This is a first step in separating out types from the ast::Module. Bug: tint:390 Change-Id: I8349bbbd1b19597b8e6d51d5cda0890de46ecaec Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/38002 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
168 lines
4.9 KiB
C++
168 lines
4.9 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/variable.h"
|
|
|
|
#include "src/ast/constant_id_decoration.h"
|
|
#include "src/ast/identifier_expression.h"
|
|
#include "src/ast/test_helper.h"
|
|
#include "src/type/f32_type.h"
|
|
#include "src/type/i32_type.h"
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
namespace {
|
|
|
|
using VariableTest = TestHelper;
|
|
|
|
TEST_F(VariableTest, Creation) {
|
|
auto* v = Var("my_var", StorageClass::kFunction, ty.i32);
|
|
|
|
EXPECT_EQ(v->symbol(), Symbol(1));
|
|
EXPECT_EQ(v->storage_class(), StorageClass::kFunction);
|
|
EXPECT_EQ(v->type(), ty.i32);
|
|
EXPECT_EQ(v->source().range.begin.line, 0u);
|
|
EXPECT_EQ(v->source().range.begin.column, 0u);
|
|
EXPECT_EQ(v->source().range.end.line, 0u);
|
|
EXPECT_EQ(v->source().range.end.column, 0u);
|
|
}
|
|
|
|
TEST_F(VariableTest, CreationWithSource) {
|
|
auto* v = Var(
|
|
Source{Source::Range{Source::Location{27, 4}, Source::Location{27, 5}}},
|
|
"i", StorageClass::kPrivate, ty.f32, nullptr, VariableDecorationList{});
|
|
|
|
EXPECT_EQ(v->symbol(), Symbol(1));
|
|
EXPECT_EQ(v->storage_class(), StorageClass::kPrivate);
|
|
EXPECT_EQ(v->type(), ty.f32);
|
|
EXPECT_EQ(v->source().range.begin.line, 27u);
|
|
EXPECT_EQ(v->source().range.begin.column, 4u);
|
|
EXPECT_EQ(v->source().range.end.line, 27u);
|
|
EXPECT_EQ(v->source().range.end.column, 5u);
|
|
}
|
|
|
|
TEST_F(VariableTest, CreationEmpty) {
|
|
auto* v = Var(
|
|
Source{Source::Range{Source::Location{27, 4}, Source::Location{27, 7}}},
|
|
"a_var", StorageClass::kWorkgroup, ty.i32, nullptr,
|
|
VariableDecorationList{});
|
|
|
|
EXPECT_EQ(v->symbol(), Symbol(1));
|
|
EXPECT_EQ(v->storage_class(), StorageClass::kWorkgroup);
|
|
EXPECT_EQ(v->type(), ty.i32);
|
|
EXPECT_EQ(v->source().range.begin.line, 27u);
|
|
EXPECT_EQ(v->source().range.begin.column, 4u);
|
|
EXPECT_EQ(v->source().range.end.line, 27u);
|
|
EXPECT_EQ(v->source().range.end.column, 7u);
|
|
}
|
|
|
|
TEST_F(VariableTest, IsValid) {
|
|
auto* v = Var("my_var", StorageClass::kNone, ty.i32);
|
|
EXPECT_TRUE(v->IsValid());
|
|
}
|
|
|
|
TEST_F(VariableTest, IsValid_WithConstructor) {
|
|
auto* v = Var("my_var", StorageClass::kNone, ty.i32, Expr("ident"),
|
|
ast::VariableDecorationList{});
|
|
EXPECT_TRUE(v->IsValid());
|
|
}
|
|
|
|
TEST_F(VariableTest, IsValid_MissingSymbol) {
|
|
auto* v = Var("", StorageClass::kNone, ty.i32);
|
|
EXPECT_FALSE(v->IsValid());
|
|
}
|
|
|
|
TEST_F(VariableTest, IsValid_MissingType) {
|
|
auto* v = Var("x", StorageClass::kNone, nullptr);
|
|
EXPECT_FALSE(v->IsValid());
|
|
}
|
|
|
|
TEST_F(VariableTest, IsValid_MissingBoth) {
|
|
auto* v = Var("", StorageClass::kNone, nullptr);
|
|
EXPECT_FALSE(v->IsValid());
|
|
}
|
|
|
|
TEST_F(VariableTest, IsValid_InvalidConstructor) {
|
|
auto* v = Var("my_var", StorageClass::kNone, ty.i32, Expr(""),
|
|
ast::VariableDecorationList{});
|
|
EXPECT_FALSE(v->IsValid());
|
|
}
|
|
|
|
TEST_F(VariableTest, to_str) {
|
|
auto* v = Var("my_var", StorageClass::kFunction, ty.f32, nullptr,
|
|
ast::VariableDecorationList{});
|
|
std::ostringstream out;
|
|
v->to_str(out, 2);
|
|
EXPECT_EQ(demangle(out.str()), R"( Variable{
|
|
my_var
|
|
function
|
|
__f32
|
|
}
|
|
)");
|
|
}
|
|
|
|
TEST_F(VariableTest, WithDecorations) {
|
|
auto* var = Var("my_var", StorageClass::kFunction, ty.i32, nullptr,
|
|
VariableDecorationList{
|
|
create<LocationDecoration>(1),
|
|
create<BuiltinDecoration>(Builtin::kPosition),
|
|
create<ConstantIdDecoration>(1200),
|
|
});
|
|
|
|
EXPECT_TRUE(var->HasLocationDecoration());
|
|
EXPECT_TRUE(var->HasBuiltinDecoration());
|
|
EXPECT_TRUE(var->HasConstantIdDecoration());
|
|
|
|
auto* location = var->GetLocationDecoration();
|
|
ASSERT_NE(nullptr, location);
|
|
EXPECT_EQ(1u, location->value());
|
|
}
|
|
|
|
TEST_F(VariableTest, ConstantId) {
|
|
auto* var = Var("my_var", StorageClass::kFunction, ty.i32, nullptr,
|
|
VariableDecorationList{
|
|
create<ConstantIdDecoration>(1200),
|
|
});
|
|
|
|
EXPECT_EQ(var->constant_id(), 1200u);
|
|
}
|
|
|
|
TEST_F(VariableTest, Decorated_to_str) {
|
|
auto* var = Var("my_var", StorageClass::kFunction, ty.f32, Expr("expr"),
|
|
VariableDecorationList{
|
|
create<BindingDecoration>(2),
|
|
create<GroupDecoration>(1),
|
|
});
|
|
|
|
std::ostringstream out;
|
|
var->to_str(out, 2);
|
|
EXPECT_EQ(demangle(out.str()), R"( Variable{
|
|
Decorations{
|
|
BindingDecoration{2}
|
|
GroupDecoration{1}
|
|
}
|
|
my_var
|
|
function
|
|
__f32
|
|
{
|
|
Identifier[not set]{expr}
|
|
}
|
|
}
|
|
)");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace ast
|
|
} // namespace tint
|