mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-14 03:11:29 +00:00
207b5e2de1
Despite `tint::ast::type::Type` being in the AST namespace, these classes are clearly not AST nodes: * They don't derive from ast::Node * They're deduplicated by the type manager * None of the types have an Source - they have no lexical declaration point * The fact we have `ast::Struct` and `ast::type::Struct` clearly demonstrates what is an AST node, and what is a type. * We have code scattered in the codebase (TypeDeterminer, writers, etc) that create new types after parsing - so clearly not part of the original syntax tree. Types in tint are closer to being semantic info, but due to the parse-time generation of types, and tight dependency of ast::Nodes to types, I'd be reluctant to class these as semantic info. Instead, put these into a separate root level `tint::type` namespace and `src/tint` directory. The fact that types exist in the ast::Module has already caused bugs (https://dawn-review.googlesource.com/c/tint/+/37261). This is a first step in separating out types from the ast::Module. Bug: tint:390 Change-Id: I8349bbbd1b19597b8e6d51d5cda0890de46ecaec Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/38002 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
227 lines
7.1 KiB
C++
227 lines
7.1 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <memory>
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "src/ast/binary_expression.h"
|
|
#include "src/ast/binding_decoration.h"
|
|
#include "src/ast/builtin.h"
|
|
#include "src/ast/builtin_decoration.h"
|
|
#include "src/ast/float_literal.h"
|
|
#include "src/ast/group_decoration.h"
|
|
#include "src/ast/location_decoration.h"
|
|
#include "src/ast/scalar_constructor_expression.h"
|
|
#include "src/ast/storage_class.h"
|
|
#include "src/ast/struct.h"
|
|
#include "src/type/access_control_type.h"
|
|
#include "src/type/f32_type.h"
|
|
#include "src/type/struct_type.h"
|
|
#include "src/type/vector_type.h"
|
|
#include "src/ast/type_constructor_expression.h"
|
|
#include "src/ast/variable.h"
|
|
#include "src/ast/variable_decoration.h"
|
|
#include "src/type_determiner.h"
|
|
#include "src/writer/spirv/builder.h"
|
|
#include "src/writer/spirv/spv_dump.h"
|
|
#include "src/writer/spirv/test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace writer {
|
|
namespace spirv {
|
|
namespace {
|
|
|
|
using BuilderTest = TestHelper;
|
|
|
|
TEST_F(BuilderTest, FunctionVar_NoStorageClass) {
|
|
auto* v = Var("var", ast::StorageClass::kNone, ty.f32);
|
|
|
|
b.push_function(Function{});
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v)) << b.error();
|
|
EXPECT_EQ(DumpInstructions(b.debug()), R"(OpName %1 "var"
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.types()), R"(%3 = OpTypeFloat 32
|
|
%2 = OpTypePointer Function %3
|
|
%4 = OpConstantNull %3
|
|
)");
|
|
|
|
const auto& func = b.functions()[0];
|
|
EXPECT_EQ(DumpInstructions(func.variables()),
|
|
R"(%1 = OpVariable %2 Function %4
|
|
)");
|
|
}
|
|
|
|
TEST_F(BuilderTest, FunctionVar_WithConstantConstructor) {
|
|
auto* init = vec3<f32>(1.f, 1.f, 3.f);
|
|
EXPECT_TRUE(td.DetermineResultType(init)) << td.error();
|
|
|
|
auto* v = Var("var", ast::StorageClass::kOutput, ty.f32, init,
|
|
ast::VariableDecorationList{});
|
|
td.RegisterVariableForTesting(v);
|
|
|
|
b.push_function(Function{});
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v)) << b.error();
|
|
ASSERT_FALSE(b.has_error()) << b.error();
|
|
|
|
EXPECT_EQ(DumpInstructions(b.debug()), R"(OpName %6 "var"
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.types()), R"(%2 = OpTypeFloat 32
|
|
%1 = OpTypeVector %2 3
|
|
%3 = OpConstant %2 1
|
|
%4 = OpConstant %2 3
|
|
%5 = OpConstantComposite %1 %3 %3 %4
|
|
%7 = OpTypePointer Function %2
|
|
%8 = OpConstantNull %2
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].variables()),
|
|
R"(%6 = OpVariable %7 Function %8
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].instructions()), R"(OpStore %6 %5
|
|
)");
|
|
}
|
|
|
|
TEST_F(BuilderTest, FunctionVar_WithNonConstantConstructor) {
|
|
auto* init = vec2<f32>(1.f, Add(3.f, 3.f));
|
|
EXPECT_TRUE(td.DetermineResultType(init)) << td.error();
|
|
|
|
auto* v = Var("var", ast::StorageClass::kFunction, ty.vec2<f32>(), init,
|
|
ast::VariableDecorationList{});
|
|
|
|
td.RegisterVariableForTesting(v);
|
|
b.push_function(Function{});
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v)) << b.error();
|
|
ASSERT_FALSE(b.has_error()) << b.error();
|
|
|
|
EXPECT_EQ(DumpInstructions(b.debug()), R"(OpName %7 "var"
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.types()), R"(%2 = OpTypeFloat 32
|
|
%1 = OpTypeVector %2 2
|
|
%3 = OpConstant %2 1
|
|
%4 = OpConstant %2 3
|
|
%8 = OpTypePointer Function %1
|
|
%9 = OpConstantNull %1
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].variables()),
|
|
R"(%7 = OpVariable %8 Function %9
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].instructions()),
|
|
R"(%5 = OpFAdd %2 %4 %4
|
|
%6 = OpCompositeConstruct %1 %3 %5
|
|
OpStore %7 %6
|
|
)");
|
|
}
|
|
|
|
TEST_F(BuilderTest, FunctionVar_WithNonConstantConstructorLoadedFromVar) {
|
|
// var v : f32 = 1.0;
|
|
// var v2 : f32 = v; // Should generate the load and store automatically.
|
|
|
|
auto* v = Var("v", ast::StorageClass::kFunction, ty.f32, Expr(1.f),
|
|
ast::VariableDecorationList{});
|
|
td.RegisterVariableForTesting(v);
|
|
|
|
auto* v2 = Var("v2", ast::StorageClass::kFunction, ty.f32, Expr("v"),
|
|
ast::VariableDecorationList{});
|
|
td.RegisterVariableForTesting(v2);
|
|
|
|
ASSERT_TRUE(td.DetermineResultType(v->constructor())) << td.error();
|
|
ASSERT_TRUE(td.DetermineResultType(v2->constructor())) << td.error();
|
|
|
|
b.push_function(Function{});
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v)) << b.error();
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v2)) << b.error();
|
|
ASSERT_FALSE(b.has_error()) << b.error();
|
|
|
|
EXPECT_EQ(DumpInstructions(b.debug()), R"(OpName %3 "v"
|
|
OpName %7 "v2"
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.types()), R"(%1 = OpTypeFloat 32
|
|
%2 = OpConstant %1 1
|
|
%4 = OpTypePointer Function %1
|
|
%5 = OpConstantNull %1
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].variables()),
|
|
R"(%3 = OpVariable %4 Function %5
|
|
%7 = OpVariable %4 Function %5
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].instructions()),
|
|
R"(OpStore %3 %2
|
|
%6 = OpLoad %1 %3
|
|
OpStore %7 %6
|
|
)");
|
|
}
|
|
|
|
TEST_F(BuilderTest, FunctionVar_ConstWithVarInitializer) {
|
|
// var v : f32 = 1.0;
|
|
// const v2 : f32 = v; // Should generate the load
|
|
|
|
auto* v = Var("v", ast::StorageClass::kFunction, ty.f32, Expr(1.f),
|
|
ast::VariableDecorationList{});
|
|
td.RegisterVariableForTesting(v);
|
|
|
|
auto* v2 = Var("v2", ast::StorageClass::kFunction, ty.f32, Expr("v"),
|
|
ast::VariableDecorationList{});
|
|
td.RegisterVariableForTesting(v2);
|
|
|
|
ASSERT_TRUE(td.DetermineResultType(v->constructor())) << td.error();
|
|
ASSERT_TRUE(td.DetermineResultType(v2->constructor())) << td.error();
|
|
|
|
b.push_function(Function{});
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v)) << b.error();
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v2)) << b.error();
|
|
ASSERT_FALSE(b.has_error()) << b.error();
|
|
|
|
EXPECT_EQ(DumpInstructions(b.debug()), R"(OpName %3 "v"
|
|
OpName %7 "v2"
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.types()), R"(%1 = OpTypeFloat 32
|
|
%2 = OpConstant %1 1
|
|
%4 = OpTypePointer Function %1
|
|
%5 = OpConstantNull %1
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].variables()),
|
|
R"(%3 = OpVariable %4 Function %5
|
|
%7 = OpVariable %4 Function %5
|
|
)");
|
|
EXPECT_EQ(DumpInstructions(b.functions()[0].instructions()),
|
|
R"(OpStore %3 %2
|
|
%6 = OpLoad %1 %3
|
|
OpStore %7 %6
|
|
)");
|
|
}
|
|
|
|
TEST_F(BuilderTest, FunctionVar_Const) {
|
|
auto* init = vec3<f32>(1.f, 1.f, 3.f);
|
|
EXPECT_TRUE(td.DetermineResultType(init)) << td.error();
|
|
|
|
auto* v = Const("var", ast::StorageClass::kOutput, ty.f32, init,
|
|
ast::VariableDecorationList{});
|
|
|
|
td.RegisterVariableForTesting(v);
|
|
|
|
EXPECT_TRUE(b.GenerateFunctionVariable(v)) << b.error();
|
|
ASSERT_FALSE(b.has_error()) << b.error();
|
|
|
|
EXPECT_EQ(DumpInstructions(b.types()), R"(%2 = OpTypeFloat 32
|
|
%1 = OpTypeVector %2 3
|
|
%3 = OpConstant %2 1
|
|
%4 = OpConstant %2 3
|
|
%5 = OpConstantComposite %1 %3 %3 %4
|
|
)");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace spirv
|
|
} // namespace writer
|
|
} // namespace tint
|