mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-01 20:21:23 +00:00
This solves an issues where when switching swapchains the previous one was destroyed before the new one was created, doing so detached itself from the Surface, which in turn made the new swapchain not do a graceful transition via vkSwapchainCreateInfoKHR::oldSwapchain. Keeping the reference on the surface makes sure we always have knowledge of the previous swapchain when replacing it. It requires re-working the lifetime model of NewSwapChainBase to not require a call to DetachFromSurface in the destructor, and having the Device explicitly tell a swapchain it got attached on creation (otherwise there are ASSERTs firing when swapchain creation fails). In addition, backends are changed to use a SwapChain::Create method and fail with a validation error (for now) when the previous swapchain didn't use the same API. vulkan::SwapChain is updated to use the previous swapchain's device's fenced deleter to destroy it which is important in the device switching tests. The SwapChainValidationTests are updated because with the lifetime changes the texture view can be kept alive after the application has lost the last reference to the wgpu::SwapChain. TBRing since it was reviewed in a different CL (but for the wrong branch). TBR=enga@chromium.org TBR=senorblanco@chromium.org Bug: dawn:269 Change-Id: Ie4374b5685af990d68969ab9cd7767e53c287ace Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/31041 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
169 lines
6.5 KiB
C++
169 lines
6.5 KiB
C++
// Copyright 2017 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef DAWNNATIVE_SWAPCHAIN_H_
|
|
#define DAWNNATIVE_SWAPCHAIN_H_
|
|
|
|
#include "dawn_native/Error.h"
|
|
#include "dawn_native/Forward.h"
|
|
#include "dawn_native/ObjectBase.h"
|
|
|
|
#include "dawn/dawn_wsi.h"
|
|
#include "dawn_native/dawn_platform.h"
|
|
|
|
namespace dawn_native {
|
|
|
|
MaybeError ValidateSwapChainDescriptor(const DeviceBase* device,
|
|
const Surface* surface,
|
|
const SwapChainDescriptor* descriptor);
|
|
|
|
TextureDescriptor GetSwapChainBaseTextureDescriptor(NewSwapChainBase* swapChain);
|
|
|
|
class SwapChainBase : public ObjectBase {
|
|
public:
|
|
SwapChainBase(DeviceBase* device);
|
|
|
|
static SwapChainBase* MakeError(DeviceBase* device);
|
|
|
|
// Dawn API
|
|
virtual void Configure(wgpu::TextureFormat format,
|
|
wgpu::TextureUsage allowedUsage,
|
|
uint32_t width,
|
|
uint32_t height) = 0;
|
|
virtual TextureViewBase* GetCurrentTextureView() = 0;
|
|
virtual void Present() = 0;
|
|
|
|
protected:
|
|
SwapChainBase(DeviceBase* device, ObjectBase::ErrorTag tag);
|
|
~SwapChainBase() override;
|
|
};
|
|
|
|
// The base class for implementation-based SwapChains that are deprecated.
|
|
class OldSwapChainBase : public SwapChainBase {
|
|
public:
|
|
OldSwapChainBase(DeviceBase* device, const SwapChainDescriptor* descriptor);
|
|
|
|
static SwapChainBase* MakeError(DeviceBase* device);
|
|
|
|
// Dawn API
|
|
void Configure(wgpu::TextureFormat format,
|
|
wgpu::TextureUsage allowedUsage,
|
|
uint32_t width,
|
|
uint32_t height) override;
|
|
TextureViewBase* GetCurrentTextureView() override;
|
|
void Present() override;
|
|
|
|
protected:
|
|
~OldSwapChainBase() override;
|
|
const DawnSwapChainImplementation& GetImplementation();
|
|
virtual TextureBase* GetNextTextureImpl(const TextureDescriptor*) = 0;
|
|
virtual MaybeError OnBeforePresent(TextureViewBase* view) = 0;
|
|
|
|
private:
|
|
MaybeError ValidateConfigure(wgpu::TextureFormat format,
|
|
wgpu::TextureUsage allowedUsage,
|
|
uint32_t width,
|
|
uint32_t height) const;
|
|
MaybeError ValidateGetCurrentTextureView() const;
|
|
MaybeError ValidatePresent() const;
|
|
|
|
DawnSwapChainImplementation mImplementation = {};
|
|
wgpu::TextureFormat mFormat = {};
|
|
wgpu::TextureUsage mAllowedUsage;
|
|
uint32_t mWidth = 0;
|
|
uint32_t mHeight = 0;
|
|
Ref<TextureBase> mCurrentTexture;
|
|
Ref<TextureViewBase> mCurrentTextureView;
|
|
};
|
|
|
|
// The base class for surface-based SwapChains that aren't ready yet.
|
|
class NewSwapChainBase : public SwapChainBase {
|
|
public:
|
|
NewSwapChainBase(DeviceBase* device,
|
|
Surface* surface,
|
|
const SwapChainDescriptor* descriptor);
|
|
|
|
// This is called when the swapchain is detached when one of the following happens:
|
|
//
|
|
// - The surface it is attached to is being destroyed.
|
|
// - The swapchain is being replaced by another one on the surface.
|
|
//
|
|
// Note that the surface has a Ref on the last swapchain that was used on it so the
|
|
// SwapChain destructor will only be called after one of the things above happens.
|
|
//
|
|
// The call for the detaching previous swapchain should be called inside the backend
|
|
// implementation of SwapChains. This is to allow them to acquire any resources before
|
|
// calling detach to make a seamless transition from the previous swapchain.
|
|
//
|
|
// Likewise the call for the swapchain being destroyed must be done in the backend's
|
|
// swapchain's destructor since C++ says it is UB to call virtual methods in the base class
|
|
// destructor.
|
|
void DetachFromSurface();
|
|
|
|
void SetIsAttached();
|
|
|
|
// Dawn API
|
|
void Configure(wgpu::TextureFormat format,
|
|
wgpu::TextureUsage allowedUsage,
|
|
uint32_t width,
|
|
uint32_t height) override;
|
|
TextureViewBase* GetCurrentTextureView() override;
|
|
void Present() override;
|
|
|
|
uint32_t GetWidth() const;
|
|
uint32_t GetHeight() const;
|
|
wgpu::TextureFormat GetFormat() const;
|
|
wgpu::TextureUsage GetUsage() const;
|
|
wgpu::PresentMode GetPresentMode() const;
|
|
Surface* GetSurface() const;
|
|
bool IsAttached() const;
|
|
wgpu::BackendType GetBackendType() const;
|
|
|
|
protected:
|
|
~NewSwapChainBase() override;
|
|
|
|
private:
|
|
bool mAttached;
|
|
uint32_t mWidth;
|
|
uint32_t mHeight;
|
|
wgpu::TextureFormat mFormat;
|
|
wgpu::TextureUsage mUsage;
|
|
wgpu::PresentMode mPresentMode;
|
|
|
|
// This is a weak reference to the surface. If the surface is destroyed it will call
|
|
// DetachFromSurface and mSurface will be updated to nullptr.
|
|
Surface* mSurface = nullptr;
|
|
Ref<TextureViewBase> mCurrentTextureView;
|
|
|
|
MaybeError ValidatePresent() const;
|
|
MaybeError ValidateGetCurrentTextureView() const;
|
|
|
|
// GetCurrentTextureViewImpl and PresentImpl are guaranteed to be called in an interleaved
|
|
// manner, starting with GetCurrentTextureViewImpl.
|
|
|
|
// The returned texture view must match the swapchain descriptor exactly.
|
|
virtual ResultOrError<TextureViewBase*> GetCurrentTextureViewImpl() = 0;
|
|
// The call to present must destroy the current view's texture so further access to it are
|
|
// invalid.
|
|
virtual MaybeError PresentImpl() = 0;
|
|
|
|
// Guaranteed to be called exactly once during the lifetime of the SwapChain. After it is
|
|
// called no other virtual method can be called.
|
|
virtual void DetachFromSurfaceImpl() = 0;
|
|
};
|
|
|
|
} // namespace dawn_native
|
|
|
|
#endif // DAWNNATIVE_SWAPCHAIN_H_
|