dawn-cmake/test/tint/builtins/atomics/from_gen/var/atomicLoad
James Price 0e22bdbae7 tint/msl: Fix emission of private variables
In order to avoid declaring too many function parameters, we
previously modified this transform to redeclare private variables that
are only used inside a single function as function-scope
variables. This was broken as it meant that their values did not
persist across multiple calls to the same function.

Instead, wrap all private variables in a structure and pass it around
as a pointer.

Fixed: tint:1875
Change-Id: I83f5eb1071d57b9c6af56d6cf21b3a32c6e94260
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124800
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>
2023-03-20 21:46:01 +00:00
..
storage_i32.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
storage_i32.spvasm.expected.dxc.hlsl tint/transform: Inline HLSL uniform / storage buffers 2023-02-24 17:16:55 +00:00
storage_i32.spvasm.expected.fxc.hlsl tint/transform: Inline HLSL uniform / storage buffers 2023-02-24 17:16:55 +00:00
storage_i32.spvasm.expected.glsl tint/writer/glsl: Set default precision to highp 2023-03-09 19:58:23 +00:00
storage_i32.spvasm.expected.msl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
storage_i32.spvasm.expected.spvasm Tint/transform: make AddBlockAttribute always do wrapping if possible 2022-11-02 02:25:38 +00:00
storage_i32.spvasm.expected.wgsl tint/writer/wgsl: Print @offset attributes as comment 2022-12-01 17:37:56 +00:00
storage_u32.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
storage_u32.spvasm.expected.dxc.hlsl tint/transform: Inline HLSL uniform / storage buffers 2023-02-24 17:16:55 +00:00
storage_u32.spvasm.expected.fxc.hlsl tint/transform: Inline HLSL uniform / storage buffers 2023-02-24 17:16:55 +00:00
storage_u32.spvasm.expected.glsl tint/writer/glsl: Set default precision to highp 2023-03-09 19:58:23 +00:00
storage_u32.spvasm.expected.msl tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
storage_u32.spvasm.expected.spvasm Tint/transform: make AddBlockAttribute always do wrapping if possible 2022-11-02 02:25:38 +00:00
storage_u32.spvasm.expected.wgsl tint/writer/wgsl: Print @offset attributes as comment 2022-12-01 17:37:56 +00:00
workgroup_i32.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
workgroup_i32.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_i32.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_i32.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_i32.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
workgroup_i32.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_i32.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_u32.spvasm tint: Add support for atomic ops to spirv reader 2022-06-24 22:28:23 +00:00
workgroup_u32.spvasm.expected.dxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_u32.spvasm.expected.fxc.hlsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_u32.spvasm.expected.glsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_u32.spvasm.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
workgroup_u32.spvasm.expected.spvasm tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00
workgroup_u32.spvasm.expected.wgsl tint: Resolve @builtin() args as expressions 2023-02-21 17:33:54 +00:00