mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-16 11:33:43 +00:00
744d0eb4aa
Discard statements no longer affect the behavior or uniformity analysis. Update the resolver, validator, and several tests to reflect this. Some E2E tests were removed as they had loops that are now considered to be infinite. Use the DemoteToHelper transform to emulate the correct semantics on platforms where discard is (or may) terminate the invocation in a manner that would affect derivative operations. We no longer need the UnwindDiscardFunctions transform for HLSL, which already implements the correct semantics. However, we still run the DemoteToHelper transform for the HLSL backend due to issues with FXC's handling of discard statements (see crbug.com/tint/1118). Fixed: tint:1723 Change-Id: Ib49ff187919ae81c4af8675e1b66acd57e2ff7d2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109003 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com>
48 lines
1.7 KiB
C++
48 lines
1.7 KiB
C++
// Copyright 2022 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef SRC_TINT_TRANSFORM_DEMOTE_TO_HELPER_H_
|
|
#define SRC_TINT_TRANSFORM_DEMOTE_TO_HELPER_H_
|
|
|
|
#include "src/tint/transform/transform.h"
|
|
|
|
namespace tint::transform {
|
|
|
|
/// Implement demote-to-helper semantics for discard statements.
|
|
///
|
|
/// For backend targets that implement discard by terminating the invocation, we need to change the
|
|
/// program to ensure that discarding the fragment does not affect uniformity with respect to
|
|
/// derivative operations. We do this by setting a global flag and masking all writes to storage
|
|
/// buffers and textures.
|
|
///
|
|
/// @note Depends on the following transforms to have been run first:
|
|
/// * PromoteSideEffectsToDecl
|
|
/// * ExpandCompoundAssignment
|
|
class DemoteToHelper final : public Castable<DemoteToHelper, Transform> {
|
|
public:
|
|
/// Constructor
|
|
DemoteToHelper();
|
|
/// Destructor
|
|
~DemoteToHelper() override;
|
|
|
|
/// @copydoc Transform::Apply
|
|
ApplyResult Apply(const Program* program,
|
|
const DataMap& inputs,
|
|
DataMap& outputs) const override;
|
|
};
|
|
|
|
} // namespace tint::transform
|
|
|
|
#endif // SRC_TINT_TRANSFORM_DEMOTE_TO_HELPER_H_
|