mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-05 14:13:39 +00:00
8758f10a20
TypeDecls (alias, structure) are not a types - they declare types. ast::TypeName is what's used for a ast::Type. Previously we were trying to automatically convert these to TypeNames in the builder, but having these inherit from ast::Type was extremely error prone. reader/spirv was actually constructing ast::Structs and using them as types, which is invalid. Change-Id: I05773ad6d488626606019015b84217a5a55a8e8a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/53802 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
120 lines
3.4 KiB
C++
120 lines
3.4 KiB
C++
// Copyright 2021 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/struct_block_decoration.h"
|
|
#include "src/resolver/resolver.h"
|
|
#include "src/resolver/resolver_test_helper.h"
|
|
#include "src/sem/reference_type.h"
|
|
|
|
#include "gmock/gmock.h"
|
|
|
|
namespace tint {
|
|
namespace resolver {
|
|
namespace {
|
|
|
|
struct ResolverPtrRefValidationTest : public resolver::TestHelper,
|
|
public testing::Test {};
|
|
|
|
TEST_F(ResolverPtrRefValidationTest, AddressOfLiteral) {
|
|
// &1
|
|
|
|
auto* expr = AddressOf(Expr(Source{{12, 34}}, 1));
|
|
|
|
WrapInFunction(expr);
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
|
|
EXPECT_EQ(r()->error(), "12:34 error: cannot take the address of expression");
|
|
}
|
|
|
|
TEST_F(ResolverPtrRefValidationTest, AddressOfLet) {
|
|
// let l : i32 = 1;
|
|
// &l
|
|
auto* l = Const("l", ty.i32(), Expr(1));
|
|
auto* expr = AddressOf(Expr(Source{{12, 34}}, "l"));
|
|
|
|
WrapInFunction(l, expr);
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
|
|
EXPECT_EQ(r()->error(), "12:34 error: cannot take the address of expression");
|
|
}
|
|
|
|
TEST_F(ResolverPtrRefValidationTest, DerefOfLiteral) {
|
|
// *1
|
|
|
|
auto* expr = Deref(Expr(Source{{12, 34}}, 1));
|
|
|
|
WrapInFunction(expr);
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
|
|
EXPECT_EQ(r()->error(),
|
|
"12:34 error: cannot dereference expression of type 'i32'");
|
|
}
|
|
|
|
TEST_F(ResolverPtrRefValidationTest, DerefOfVar) {
|
|
// var v : i32 = 1;
|
|
// *1
|
|
auto* v = Var("v", ty.i32());
|
|
auto* expr = Deref(Expr(Source{{12, 34}}, "v"));
|
|
|
|
WrapInFunction(v, expr);
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
|
|
EXPECT_EQ(r()->error(),
|
|
"12:34 error: cannot dereference expression of type 'i32'");
|
|
}
|
|
|
|
TEST_F(ResolverPtrRefValidationTest, InferredPtrAccessMismatch) {
|
|
// struct Inner {
|
|
// arr: array<i32, 4>;
|
|
// }
|
|
// [[block]] struct S {
|
|
// inner: Inner;
|
|
// }
|
|
// [[group(0), binding(0)]] var<storage, read_write> s : S;
|
|
// fn f() {
|
|
// let p : pointer<storage, i32> = &s.inner.arr[2];
|
|
// }
|
|
auto* inner = Structure("Inner", {Member("arr", ty.array<i32, 4>())});
|
|
auto* buf = Structure("S", {Member("inner", ty.Of(inner))},
|
|
{create<ast::StructBlockDecoration>()});
|
|
auto* storage = Global("s", ty.Of(buf), ast::StorageClass::kStorage,
|
|
ast::Access::kReadWrite,
|
|
ast::DecorationList{
|
|
create<ast::BindingDecoration>(0),
|
|
create<ast::GroupDecoration>(0),
|
|
});
|
|
|
|
auto* expr =
|
|
IndexAccessor(MemberAccessor(MemberAccessor(storage, "inner"), "arr"), 4);
|
|
auto* ptr =
|
|
Const(Source{{12, 34}}, "p", ty.pointer<i32>(ast::StorageClass::kStorage),
|
|
AddressOf(expr));
|
|
|
|
WrapInFunction(ptr);
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
EXPECT_EQ(r()->error(),
|
|
"12:34 error: cannot initialize let of type "
|
|
"'ptr<storage, i32>' with value of type "
|
|
"'ptr<storage, i32, read_write>'");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace resolver
|
|
} // namespace tint
|