mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-17 17:31:47 +00:00
3a2a279714
When enabling the SPIR-V reader or SPIR-V writer we were suppressing -Wnewline-eof, -Wold-style-cast, -Wsign-conversion, and -Wweak-vtables for the `libtint` cmake target and anything that depended on that target. Because we'd build all readers/ writers by default this caused us to never hit those warnings. A recent change to the cmake build sets the Tint backend based on the Dawn backend. So, there is a much higher chance of not building the SPIR-V support if you're on a Mac or Windows machine. This CL removes the suppression of the warnings, adds specific pragmas into the SPIR-V reader code which imports the SPIRV-Tools headers and fixes up the warnings which were then firing due to checking for the new warnings. Change-Id: I0d0be6aa3d0b692e939ce8ff924dfb82c82792fc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94901 Reviewed-by: Ben Clayton <bclayton@google.com> Auto-Submit: Dan Sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
96 lines
4.2 KiB
C
96 lines
4.2 KiB
C
// Copyright 2022 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/tint/utils/concat.h"
|
|
|
|
#ifndef SRC_TINT_UTILS_COMPILER_MACROS_H_
|
|
#define SRC_TINT_UTILS_COMPILER_MACROS_H_
|
|
|
|
#define TINT_REQUIRE_SEMICOLON static_assert(true)
|
|
|
|
#if defined(_MSC_VER)
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// MSVC
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
#define TINT_DISABLE_WARNING_CONSTANT_OVERFLOW __pragma(warning(disable : 4756))
|
|
#define TINT_DISABLE_WARNING_MAYBE_UNINITIALIZED /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_NEWLINE_EOF /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_OLD_STYLE_CAST /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_SIGN_CONVERSION /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_UNREACHABLE_CODE __pragma(warning(disable : 4702))
|
|
#define TINT_DISABLE_WARNING_WEAK_VTABLES /* currently no-op */
|
|
|
|
// clang-format off
|
|
#define TINT_BEGIN_DISABLE_WARNING(name) \
|
|
__pragma(warning(push)) \
|
|
TINT_CONCAT(TINT_DISABLE_WARNING_, name) \
|
|
TINT_REQUIRE_SEMICOLON
|
|
#define TINT_END_DISABLE_WARNING(name) \
|
|
__pragma(warning(pop)) \
|
|
TINT_REQUIRE_SEMICOLON
|
|
// clang-format on
|
|
#elif defined(__clang__)
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// Clang
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
#define TINT_DISABLE_WARNING_CONSTANT_OVERFLOW /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_MAYBE_UNINITIALIZED /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_NEWLINE_EOF _Pragma("clang diagnostic ignored \"-Wnewline-eof\"")
|
|
#define TINT_DISABLE_WARNING_OLD_STYLE_CAST _Pragma("clang diagnostic ignored \"-Wold-style-cast\"")
|
|
#define TINT_DISABLE_WARNING_SIGN_CONVERSION \
|
|
_Pragma("clang diagnostic ignored \"-Wsign-conversion\"")
|
|
#define TINT_DISABLE_WARNING_UNREACHABLE_CODE /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_WEAK_VTABLES _Pragma("clang diagnostic ignored \"-Wweak-vtables\"")
|
|
|
|
// clang-format off
|
|
#define TINT_BEGIN_DISABLE_WARNING(name) \
|
|
_Pragma("clang diagnostic push") \
|
|
TINT_CONCAT(TINT_DISABLE_WARNING_, name) \
|
|
TINT_REQUIRE_SEMICOLON
|
|
#define TINT_END_DISABLE_WARNING(name) \
|
|
_Pragma("clang diagnostic pop") \
|
|
TINT_REQUIRE_SEMICOLON
|
|
// clang-format on
|
|
#elif defined(__GNUC__)
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// GCC
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
#define TINT_DISABLE_WARNING_CONSTANT_OVERFLOW /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_MAYBE_UNINITIALIZED \
|
|
_Pragma("GCC diagnostic ignored \"-Wmaybe-uninitialized\"")
|
|
#define TINT_DISABLE_WARNING_NEWLINE_EOF /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_OLD_STYLE_CAST /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_SIGN_CONVERSION /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_UNREACHABLE_CODE /* currently no-op */
|
|
#define TINT_DISABLE_WARNING_WEAK_VTABLES /* currently no-op */
|
|
|
|
// clang-format off
|
|
#define TINT_BEGIN_DISABLE_WARNING(name) \
|
|
_Pragma("GCC diagnostic push") \
|
|
TINT_CONCAT(TINT_DISABLE_WARNING_, name) \
|
|
TINT_REQUIRE_SEMICOLON
|
|
#define TINT_END_DISABLE_WARNING(name) \
|
|
_Pragma("GCC diagnostic pop") \
|
|
TINT_REQUIRE_SEMICOLON
|
|
// clang-format on
|
|
#else
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// Other
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
#define TINT_BEGIN_DISABLE_WARNING(name) TINT_REQUIRE_SEMICOLON
|
|
#define TINT_END_DISABLE_WARNING(name) TINT_REQUIRE_SEMICOLON
|
|
#endif
|
|
|
|
#endif // SRC_TINT_UTILS_COMPILER_MACROS_H_
|