dawn-cmake

mirror of https://github.com/encounter/dawn-cmake.git synced 2025-08-04 11:15:46 +00:00

History

Austin Eng 8c58491d25 dawn_wire: Skip device inject error if the client drops the device

If the client drops the last reference to the device, it would
dereference an invalid pointer upon calling InjectError. So, skip the
call. We can't keep the device alive if the Buffer is still alive
because we intend to make all objects internally null if you delete
their device.

It is ok to skip error injection because if the client deletes the
device, it should not expect to receive any more error callbacks.

Bug: dawn:384
Change-Id: I4c694310e4395b06cd49603fc5d4cd846799decb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/37580
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>

2021-01-14 00:51:58 +00:00

client

dawn_wire: Skip device inject error if the client drops the device

2021-01-14 00:51:58 +00:00

server

Ensure all wire child objects are destroyed before their device

2021-01-13 20:58:18 +00:00

BUILD.gn

Track and destroy all child objects on wire client destruction

2020-11-11 19:46:18 +00:00

ChunkedCommandHandler.cpp

Use a common helper for std::nothrow