mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-04 19:25:47 +00:00
0e22bdbae7
In order to avoid declaring too many function parameters, we previously modified this transform to redeclare private variables that are only used inside a single function as function-scope variables. This was broken as it meant that their values did not persist across multiple calls to the same function. Instead, wrap all private variables in a structure and pass it around as a pointer. Fixed: tint:1875 Change-Id: I83f5eb1071d57b9c6af56d6cf21b3a32c6e94260 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124800 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com>
56 lines
1.6 KiB
Plaintext
56 lines
1.6 KiB
Plaintext
#include <metal_stdlib>
|
|
|
|
using namespace metal;
|
|
|
|
struct atomic_compare_exchange_resulti32 {
|
|
int old_value;
|
|
bool exchanged;
|
|
};
|
|
atomic_compare_exchange_resulti32 atomicCompareExchangeWeak_1(device atomic_int* atomic, int compare, int value) {
|
|
int old_value = compare;
|
|
bool exchanged = atomic_compare_exchange_weak_explicit(atomic, &old_value, value, memory_order_relaxed, memory_order_relaxed);
|
|
return {old_value, exchanged};
|
|
}
|
|
|
|
struct tint_private_vars_struct {
|
|
bool tint_discarded;
|
|
};
|
|
|
|
struct tint_symbol_2 {
|
|
int old_value;
|
|
bool exchanged;
|
|
};
|
|
|
|
struct tint_symbol {
|
|
int value [[color(0)]];
|
|
};
|
|
|
|
int foo_inner(thread tint_private_vars_struct* const tint_private_vars, device atomic_int* const tint_symbol_4) {
|
|
(*(tint_private_vars)).tint_discarded = true;
|
|
int x = 0;
|
|
tint_symbol_2 tint_symbol_1 = {};
|
|
if (!((*(tint_private_vars)).tint_discarded)) {
|
|
atomic_compare_exchange_resulti32 const tint_symbol_3 = atomicCompareExchangeWeak_1(tint_symbol_4, 0, 1);
|
|
tint_symbol_1.old_value = tint_symbol_3.old_value;
|
|
tint_symbol_1.exchanged = tint_symbol_3.exchanged;
|
|
}
|
|
tint_symbol_2 const result = tint_symbol_1;
|
|
if (result.exchanged) {
|
|
x = result.old_value;
|
|
}
|
|
return x;
|
|
}
|
|
|
|
fragment tint_symbol foo(device atomic_int* tint_symbol_5 [[buffer(0)]]) {
|
|
thread tint_private_vars_struct tint_private_vars = {};
|
|
tint_private_vars.tint_discarded = false;
|
|
int const inner_result = foo_inner(&(tint_private_vars), tint_symbol_5);
|
|
tint_symbol wrapper_result = {};
|
|
wrapper_result.value = inner_result;
|
|
if (tint_private_vars.tint_discarded) {
|
|
discard_fragment();
|
|
}
|
|
return wrapper_result;
|
|
}
|
|
|