mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-25 16:03:38 +00:00
4a92a3c904
Add a 'NodeID' to each ast::Node which is the sequentially allocated
index of the node. Use this in sem::Info to map the AST node to the
semantic node, instead of using a std::unordered_map.
Optimised very hot code by entirely eliminating map lookups, and
dramatically reducing cache misses (lookups are usually sequentually
ordered).
Timings running
'webgpu:shader,execution,expression,call,builtin,atan2:f32:inputSource="const";vectorize="_undef_"'
with dawn/node, using SwiftShader:
Without change: 3.22647107s
With change: 3.10578879s
Bug: tint:1613
Change-Id: I22ec48d933b2e5f9da04494bff4e979e6f7b1982
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96140
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
126 lines
4.4 KiB
C++
126 lines
4.4 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/tint/ast/struct.h"
|
|
#include "gtest/gtest-spi.h"
|
|
#include "src/tint/ast/alias.h"
|
|
#include "src/tint/ast/array.h"
|
|
#include "src/tint/ast/bool.h"
|
|
#include "src/tint/ast/f32.h"
|
|
#include "src/tint/ast/i32.h"
|
|
#include "src/tint/ast/matrix.h"
|
|
#include "src/tint/ast/pointer.h"
|
|
#include "src/tint/ast/sampler.h"
|
|
#include "src/tint/ast/test_helper.h"
|
|
#include "src/tint/ast/texture.h"
|
|
#include "src/tint/ast/u32.h"
|
|
#include "src/tint/ast/vector.h"
|
|
#include "src/tint/transform/add_spirv_block_attribute.h"
|
|
|
|
namespace tint::ast {
|
|
namespace {
|
|
|
|
using AstStructTest = TestHelper;
|
|
using SpirvBlockAttribute = transform::AddSpirvBlockAttribute::SpirvBlockAttribute;
|
|
|
|
TEST_F(AstStructTest, Creation) {
|
|
auto name = Sym("s");
|
|
auto* s = create<Struct>(name, StructMemberList{Member("a", ty.i32())}, AttributeList{});
|
|
EXPECT_EQ(s->name, name);
|
|
EXPECT_EQ(s->members.size(), 1u);
|
|
EXPECT_TRUE(s->attributes.empty());
|
|
EXPECT_EQ(s->source.range.begin.line, 0u);
|
|
EXPECT_EQ(s->source.range.begin.column, 0u);
|
|
EXPECT_EQ(s->source.range.end.line, 0u);
|
|
EXPECT_EQ(s->source.range.end.column, 0u);
|
|
}
|
|
|
|
TEST_F(AstStructTest, Creation_WithAttributes) {
|
|
auto name = Sym("s");
|
|
AttributeList attrs;
|
|
attrs.push_back(ASTNodes().Create<SpirvBlockAttribute>(ID(), AllocateNodeID()));
|
|
|
|
auto* s = create<Struct>(name, StructMemberList{Member("a", ty.i32())}, attrs);
|
|
EXPECT_EQ(s->name, name);
|
|
EXPECT_EQ(s->members.size(), 1u);
|
|
ASSERT_EQ(s->attributes.size(), 1u);
|
|
EXPECT_TRUE(s->attributes[0]->Is<SpirvBlockAttribute>());
|
|
EXPECT_EQ(s->source.range.begin.line, 0u);
|
|
EXPECT_EQ(s->source.range.begin.column, 0u);
|
|
EXPECT_EQ(s->source.range.end.line, 0u);
|
|
EXPECT_EQ(s->source.range.end.column, 0u);
|
|
}
|
|
|
|
TEST_F(AstStructTest, CreationWithSourceAndAttributes) {
|
|
auto name = Sym("s");
|
|
auto* s = create<Struct>(
|
|
Source{Source::Range{Source::Location{27, 4}, Source::Location{27, 8}}}, name,
|
|
StructMemberList{Member("a", ty.i32())},
|
|
AttributeList{ASTNodes().Create<SpirvBlockAttribute>(ID(), AllocateNodeID())});
|
|
EXPECT_EQ(s->name, name);
|
|
EXPECT_EQ(s->members.size(), 1u);
|
|
ASSERT_EQ(s->attributes.size(), 1u);
|
|
EXPECT_TRUE(s->attributes[0]->Is<SpirvBlockAttribute>());
|
|
EXPECT_EQ(s->source.range.begin.line, 27u);
|
|
EXPECT_EQ(s->source.range.begin.column, 4u);
|
|
EXPECT_EQ(s->source.range.end.line, 27u);
|
|
EXPECT_EQ(s->source.range.end.column, 8u);
|
|
}
|
|
|
|
TEST_F(AstStructTest, Assert_Null_StructMember) {
|
|
EXPECT_FATAL_FAILURE(
|
|
{
|
|
ProgramBuilder b;
|
|
b.create<Struct>(b.Sym("S"), StructMemberList{b.Member("a", b.ty.i32()), nullptr},
|
|
AttributeList{});
|
|
},
|
|
"internal compiler error");
|
|
}
|
|
|
|
TEST_F(AstStructTest, Assert_Null_Attribute) {
|
|
EXPECT_FATAL_FAILURE(
|
|
{
|
|
ProgramBuilder b;
|
|
b.create<Struct>(b.Sym("S"), StructMemberList{b.Member("a", b.ty.i32())},
|
|
AttributeList{nullptr});
|
|
},
|
|
"internal compiler error");
|
|
}
|
|
|
|
TEST_F(AstStructTest, Assert_DifferentProgramID_StructMember) {
|
|
EXPECT_FATAL_FAILURE(
|
|
{
|
|
ProgramBuilder b1;
|
|
ProgramBuilder b2;
|
|
b1.create<Struct>(b1.Sym("S"), StructMemberList{b2.Member("a", b2.ty.i32())},
|
|
AttributeList{});
|
|
},
|
|
"internal compiler error");
|
|
}
|
|
|
|
TEST_F(AstStructTest, Assert_DifferentProgramID_Attribute) {
|
|
EXPECT_FATAL_FAILURE(
|
|
{
|
|
ProgramBuilder b1;
|
|
ProgramBuilder b2;
|
|
b1.create<Struct>(b1.Sym("S"), StructMemberList{b1.Member("a", b1.ty.i32())},
|
|
AttributeList{b2.ASTNodes().Create<SpirvBlockAttribute>(
|
|
b2.ID(), b2.AllocateNodeID())});
|
|
},
|
|
"internal compiler error");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace tint::ast
|