mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-14 19:31:25 +00:00
4b0b7a532a
This patch factors resource usage tracking so it is separate from command validation, allowing the bulk of command validation to be completely skipped. In DrawCallPerfRun/Vulkan_DynamicPipeline_DynamicBindGroup, disabling validation cuts roughly 74 nanoseconds (20%) of CPU time, per draw. In DrawCallPerfRun/Vulkan_DynamicBindGroup, disabling validation cuts roughly 35 nanoseconds (17%) of CPU time, per draw. In DrawCallPerfRun/Vulkan_MultipleBindGroups, disabling validation cuts roughly 45 nanoseconds (14%) of CPU time, per draw. Bug: dawn:271 Change-Id: I517b85840ba18c6a554b83f34a1d0aef1a8c56a6 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13520 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
124 lines
4.4 KiB
C++
124 lines
4.4 KiB
C++
// Copyright 2017 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "dawn_native/Queue.h"
|
|
|
|
#include "dawn_native/Buffer.h"
|
|
#include "dawn_native/CommandBuffer.h"
|
|
#include "dawn_native/Device.h"
|
|
#include "dawn_native/ErrorScope.h"
|
|
#include "dawn_native/ErrorScopeTracker.h"
|
|
#include "dawn_native/Fence.h"
|
|
#include "dawn_native/FenceSignalTracker.h"
|
|
#include "dawn_native/Texture.h"
|
|
#include "dawn_platform/DawnPlatform.h"
|
|
#include "dawn_platform/tracing/TraceEvent.h"
|
|
|
|
namespace dawn_native {
|
|
|
|
// QueueBase
|
|
|
|
QueueBase::QueueBase(DeviceBase* device) : ObjectBase(device) {
|
|
}
|
|
|
|
void QueueBase::Submit(uint32_t commandCount, CommandBufferBase* const* commands) {
|
|
DeviceBase* device = GetDevice();
|
|
TRACE_EVENT0(device->GetPlatform(), General, "Queue::Submit");
|
|
if (device->IsValidationEnabled() &&
|
|
device->ConsumedError(ValidateSubmit(commandCount, commands))) {
|
|
return;
|
|
}
|
|
ASSERT(!IsError());
|
|
|
|
if (device->ConsumedError(SubmitImpl(commandCount, commands))) {
|
|
return;
|
|
}
|
|
device->GetErrorScopeTracker()->TrackUntilLastSubmitComplete(
|
|
device->GetCurrentErrorScope());
|
|
}
|
|
|
|
void QueueBase::Signal(Fence* fence, uint64_t signalValue) {
|
|
DeviceBase* device = GetDevice();
|
|
if (device->ConsumedError(ValidateSignal(fence, signalValue))) {
|
|
return;
|
|
}
|
|
ASSERT(!IsError());
|
|
|
|
fence->SetSignaledValue(signalValue);
|
|
device->GetFenceSignalTracker()->UpdateFenceOnComplete(fence, signalValue);
|
|
device->GetErrorScopeTracker()->TrackUntilLastSubmitComplete(
|
|
device->GetCurrentErrorScope());
|
|
}
|
|
|
|
Fence* QueueBase::CreateFence(const FenceDescriptor* descriptor) {
|
|
if (GetDevice()->ConsumedError(ValidateCreateFence(descriptor))) {
|
|
return Fence::MakeError(GetDevice());
|
|
}
|
|
|
|
return new Fence(this, descriptor);
|
|
}
|
|
|
|
MaybeError QueueBase::ValidateSubmit(uint32_t commandCount,
|
|
CommandBufferBase* const* commands) {
|
|
TRACE_EVENT0(GetDevice()->GetPlatform(), Validation, "Queue::ValidateSubmit");
|
|
DAWN_TRY(GetDevice()->ValidateObject(this));
|
|
|
|
for (uint32_t i = 0; i < commandCount; ++i) {
|
|
DAWN_TRY(GetDevice()->ValidateObject(commands[i]));
|
|
|
|
const CommandBufferResourceUsage& usages = commands[i]->GetResourceUsages();
|
|
|
|
for (const PassResourceUsage& passUsages : usages.perPass) {
|
|
for (const BufferBase* buffer : passUsages.buffers) {
|
|
DAWN_TRY(buffer->ValidateCanUseInSubmitNow());
|
|
}
|
|
for (const TextureBase* texture : passUsages.textures) {
|
|
DAWN_TRY(texture->ValidateCanUseInSubmitNow());
|
|
}
|
|
}
|
|
|
|
for (const BufferBase* buffer : usages.topLevelBuffers) {
|
|
DAWN_TRY(buffer->ValidateCanUseInSubmitNow());
|
|
}
|
|
for (const TextureBase* texture : usages.topLevelTextures) {
|
|
DAWN_TRY(texture->ValidateCanUseInSubmitNow());
|
|
}
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
MaybeError QueueBase::ValidateSignal(const Fence* fence, uint64_t signalValue) {
|
|
DAWN_TRY(GetDevice()->ValidateObject(this));
|
|
DAWN_TRY(GetDevice()->ValidateObject(fence));
|
|
|
|
if (fence->GetQueue() != this) {
|
|
return DAWN_VALIDATION_ERROR(
|
|
"Fence must be signaled on the queue on which it was created.");
|
|
}
|
|
if (signalValue <= fence->GetSignaledValue()) {
|
|
return DAWN_VALIDATION_ERROR("Signal value less than or equal to fence signaled value");
|
|
}
|
|
return {};
|
|
}
|
|
|
|
MaybeError QueueBase::ValidateCreateFence(const FenceDescriptor* descriptor) {
|
|
DAWN_TRY(GetDevice()->ValidateObject(this));
|
|
DAWN_TRY(ValidateFenceDescriptor(descriptor));
|
|
|
|
return {};
|
|
}
|
|
|
|
} // namespace dawn_native
|