mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-05 06:03:34 +00:00
I added the forcing of the "loop" attribute to all loops to address FXC failing on uniformity errors related to gradients in loops. Since then, Tint now implements UA and it recently became an error, so we no longer need this hack. As a result, FXC is now better able to cope with loops that it determines executes 0 times. Most e2e tests are affected because so many use loops, but 27 tests that were previously failing are now passing with this change: tint/bug/tint/1538.wgsl.expected.fxc.hlsl tint/bug/tint/1604.wgsl.expected.fxc.hlsl tint/bug/tint/1605.wgsl.expected.fxc.hlsl tint/unittest/reader/spirv/SpvParserCFGTest_ClassifyCFGEdges_LoopBreak_FromLoopHeader_SingleBlockLoop_TrueBranch.spvasm.expected.fxc.hlsl tint/unittest/reader/spirv/SpvParserCFGTest_ComputeBlockOrder_Loop_HeaderHasBreakUnless.spvasm.expected.fxc.hlsl tint/unittest/reader/spirv/SpvParserCFGTest_EmitBody_IfSelection_TrueBranch_LoopBreak.spvasm.expected.fxc.hlsl tint/unittest/reader/spirv/SpvParserCFGTest_FindIfSelectionInternalHeaders_TrueBranch_LoopBreak_Ok.spvasm.expected.fxc.hlsl tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_MultiBlockLoopIndex.spvasm.expected.fxc.hlsl tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_SingleBlockLoopIndex.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.wgsl.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.spvasm.expected.fxc.hlsl tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.wgsl.expected.fxc.hlsl Bug: tint:1522 Bug: tint:1538 Bug: tint:1604 Bug: tint:1605 Change-Id: I530b846b6b8df122ab351ff7b85d3e1c9ac11526 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104121 Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
66 lines
2.6 KiB
HLSL
66 lines
2.6 KiB
HLSL
cbuffer cbuffer_s : register(b0, space0) {
|
|
uint4 s[96];
|
|
};
|
|
|
|
struct tint_symbol_1 {
|
|
uint idx : SV_GroupIndex;
|
|
};
|
|
|
|
float2x3 tint_symbol_9(uint4 buffer[96], uint offset) {
|
|
const uint scalar_offset = ((offset + 0u)) / 4;
|
|
const uint scalar_offset_1 = ((offset + 16u)) / 4;
|
|
return float2x3(asfloat(buffer[scalar_offset / 4].xyz), asfloat(buffer[scalar_offset_1 / 4].xyz));
|
|
}
|
|
|
|
float3x2 tint_symbol_10(uint4 buffer[96], uint offset) {
|
|
const uint scalar_offset_2 = ((offset + 0u)) / 4;
|
|
uint4 ubo_load = buffer[scalar_offset_2 / 4];
|
|
const uint scalar_offset_3 = ((offset + 8u)) / 4;
|
|
uint4 ubo_load_1 = buffer[scalar_offset_3 / 4];
|
|
const uint scalar_offset_4 = ((offset + 16u)) / 4;
|
|
uint4 ubo_load_2 = buffer[scalar_offset_4 / 4];
|
|
return float3x2(asfloat(((scalar_offset_2 & 2) ? ubo_load.zw : ubo_load.xy)), asfloat(((scalar_offset_3 & 2) ? ubo_load_1.zw : ubo_load_1.xy)), asfloat(((scalar_offset_4 & 2) ? ubo_load_2.zw : ubo_load_2.xy)));
|
|
}
|
|
|
|
typedef int4 tint_symbol_12_ret[4];
|
|
tint_symbol_12_ret tint_symbol_12(uint4 buffer[96], uint offset) {
|
|
int4 arr_1[4] = (int4[4])0;
|
|
{
|
|
for(uint i_1 = 0u; (i_1 < 4u); i_1 = (i_1 + 1u)) {
|
|
const uint scalar_offset_5 = ((offset + (i_1 * 16u))) / 4;
|
|
arr_1[i_1] = asint(buffer[scalar_offset_5 / 4]);
|
|
}
|
|
}
|
|
return arr_1;
|
|
}
|
|
|
|
void main_inner(uint idx) {
|
|
const uint scalar_offset_6 = ((192u * idx)) / 4;
|
|
const int3 a = asint(s[scalar_offset_6 / 4].xyz);
|
|
const uint scalar_offset_7 = (((192u * idx) + 12u)) / 4;
|
|
const int b = asint(s[scalar_offset_7 / 4][scalar_offset_7 % 4]);
|
|
const uint scalar_offset_8 = (((192u * idx) + 16u)) / 4;
|
|
const uint3 c = s[scalar_offset_8 / 4].xyz;
|
|
const uint scalar_offset_9 = (((192u * idx) + 28u)) / 4;
|
|
const uint d = s[scalar_offset_9 / 4][scalar_offset_9 % 4];
|
|
const uint scalar_offset_10 = (((192u * idx) + 32u)) / 4;
|
|
const float3 e = asfloat(s[scalar_offset_10 / 4].xyz);
|
|
const uint scalar_offset_11 = (((192u * idx) + 44u)) / 4;
|
|
const float f = asfloat(s[scalar_offset_11 / 4][scalar_offset_11 % 4]);
|
|
const uint scalar_offset_12 = (((192u * idx) + 48u)) / 4;
|
|
uint4 ubo_load_3 = s[scalar_offset_12 / 4];
|
|
const int2 g = asint(((scalar_offset_12 & 2) ? ubo_load_3.zw : ubo_load_3.xy));
|
|
const uint scalar_offset_13 = (((192u * idx) + 56u)) / 4;
|
|
uint4 ubo_load_4 = s[scalar_offset_13 / 4];
|
|
const int2 h = asint(((scalar_offset_13 & 2) ? ubo_load_4.zw : ubo_load_4.xy));
|
|
const float2x3 i = tint_symbol_9(s, ((192u * idx) + 64u));
|
|
const float3x2 j = tint_symbol_10(s, ((192u * idx) + 96u));
|
|
const int4 k[4] = tint_symbol_12(s, ((192u * idx) + 128u));
|
|
}
|
|
|
|
[numthreads(1, 1, 1)]
|
|
void main(tint_symbol_1 tint_symbol) {
|
|
main_inner(tint_symbol.idx);
|
|
return;
|
|
}
|