mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-22 11:42:17 +00:00
545c9742d5
In C++ argument evaluation order is undefined. MSVC and Clang evaluate these in different orders, leading to hilarity when writing tests that expect a deterministic ordering. Pull out all the argument expressions to create() in the clone functions so a cloned program is deterministic in its ordering between compilers. Change-Id: I8e2de31398960c480ce7ee1dfaac4f67652d2dbc Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41544 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org> Auto-Submit: Ben Clayton <bclayton@google.com>
113 lines
2.9 KiB
C++
113 lines
2.9 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/if_statement.h"
|
|
|
|
#include "src/ast/else_statement.h"
|
|
#include "src/clone_context.h"
|
|
#include "src/program_builder.h"
|
|
|
|
TINT_INSTANTIATE_CLASS_ID(tint::ast::IfStatement);
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
|
|
IfStatement::IfStatement(const Source& source,
|
|
Expression* condition,
|
|
BlockStatement* body,
|
|
ElseStatementList else_stmts)
|
|
: Base(source),
|
|
condition_(condition),
|
|
body_(body),
|
|
else_statements_(std::move(else_stmts)) {}
|
|
|
|
IfStatement::IfStatement(IfStatement&&) = default;
|
|
|
|
IfStatement::~IfStatement() = default;
|
|
|
|
IfStatement* IfStatement::Clone(CloneContext* ctx) const {
|
|
// Clone arguments outside of create() call to have deterministic ordering
|
|
auto src = ctx->Clone(source());
|
|
auto* cond = ctx->Clone(condition_);
|
|
auto* b = ctx->Clone(body_);
|
|
auto el = ctx->Clone(else_statements_);
|
|
return ctx->dst->create<IfStatement>(src, cond, b, el);
|
|
}
|
|
|
|
bool IfStatement::IsValid() const {
|
|
if (condition_ == nullptr || !condition_->IsValid()) {
|
|
return false;
|
|
}
|
|
if (body_ == nullptr || !body_->IsValid()) {
|
|
return false;
|
|
}
|
|
|
|
bool found_else = false;
|
|
for (auto* el : else_statements_) {
|
|
// Else statement must be last
|
|
if (found_else)
|
|
return false;
|
|
|
|
if (el == nullptr || !el->IsValid())
|
|
return false;
|
|
|
|
if (el->condition() == nullptr)
|
|
found_else = true;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
void IfStatement::to_str(const semantic::Info& sem,
|
|
std::ostream& out,
|
|
size_t indent) const {
|
|
make_indent(out, indent);
|
|
out << "If{" << std::endl;
|
|
|
|
// Open if conditional
|
|
make_indent(out, indent + 2);
|
|
out << "(" << std::endl;
|
|
|
|
condition_->to_str(sem, out, indent + 4);
|
|
|
|
// Close if conditional
|
|
make_indent(out, indent + 2);
|
|
out << ")" << std::endl;
|
|
|
|
// Open if body
|
|
make_indent(out, indent + 2);
|
|
out << "{" << std::endl;
|
|
|
|
if (body_ != nullptr) {
|
|
for (auto* stmt : *body_) {
|
|
stmt->to_str(sem, out, indent + 4);
|
|
}
|
|
}
|
|
|
|
// Close the if body
|
|
make_indent(out, indent + 2);
|
|
out << "}" << std::endl;
|
|
|
|
// Close the If
|
|
make_indent(out, indent);
|
|
out << "}" << std::endl;
|
|
|
|
for (auto* e : else_statements_) {
|
|
e->to_str(sem, out, indent);
|
|
}
|
|
}
|
|
|
|
} // namespace ast
|
|
} // namespace tint
|