20a6ca0041
The generator_lib.py processing of file renders would check that the output directory doesn't exist and if needed, would create it. However by default makedirs errors if the path already exists. This caused issues when multiple generator_lib.py generators with the same output dir would run in parallel in builds, because there can be a race where: - GeneratorA: Check os.path.exists -> returns False - GeneratorB: Check os.path.exists -> returns False - GeneratorB: os.makedirs -> Ok - GeneratorA: os.makedirs -> Exception, fails the build. Instead use os.makedirs(exist_ok=True) inconditionally to remove this racy behavior. Bug: None Change-Id: I5cb401a1df11a3640faeea94c15cb54236edc05a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114521 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> |
||
|---|---|---|
| .. | ||
| templates | ||
| CMakeLists.txt | ||
| dawn_generator.gni | ||
| dawn_gpu_info_generator.py | ||
| dawn_json_generator.py | ||
| dawn_version_generator.py | ||
| extract_json.py | ||
| generator_lib.gni | ||
| generator_lib.py | ||
| opengl_loader_generator.py | ||