dawn-cmake

mirror of https://github.com/encounter/dawn-cmake.git synced 2025-10-09 19:39:03 +00:00

History

Takahiro 35df626efa Refcount check in Buffer map async in Wire

If buffer is released and the external refcount reaches 0 while
buffer map state is pending map in Wire, the map async callback
is fired with destroyed-before-callback status from the buffer
destructor.

It is possible to call another MapAsync in the callback. At that
time the pointer is still valid because the internal refcount is
not 0 yet.

The behavior of MapAsync should be undefined if external refcount
is 0. This commit adds an assert to check whether external
refcount is 0 in Buffer::MapAsync() in Wire. Ending up with
assertion error may be reasonable.

This commit also adds protected GetRefcount() method to
ObjectBase to allow derived classes to check the refcount.

bug: dawn:1624
Change-Id: I95411a7be2093ba7bb2bb45b466f17f1ebac0ca9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119961
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

2023-02-27 15:14:13 +00:00

client

Refcount check in Buffer map async in Wire

2023-02-27 15:14:13 +00:00

server

Add wire serialized command buffer padding.

2022-11-22 23:19:43 +00:00

BufferConsumer_impl.h

Fix condition for memory allocation to check for nullopt.

2022-11-30 22:35:09 +00:00

BufferConsumer.h

Add wire serialized command buffer padding.